)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30106,"name":"Matt Carter","email":"matt.coach.carter@gmail.com","username":"MattCarter"},"change_message_id":"7c426c2a1c69d56ccf3b39f169f3d2c88d25763f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ahmad Mahmoudi \u003cahmad.mahmoudi@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-23 20:45:12 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[AICUNDRC-1746] - WIP: Build airflow image from ssh repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added capability to be able to build airflow image from a"},{"line_number":10,"context_line":"private git repo over ssh."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_5a6bf383","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":14},"updated":"2019-09-24 17:42:48.000000000","message":"Please remove this internal reference","commit_id":"54bc21ee5300d6d865e9a5813cd96411e9ccefcf"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"7c0d8cca780acea7f01f3fdecaab08e8a3523a15","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ahmad Mahmoudi \u003cahmad.mahmoudi@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-28 23:23:00 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"(airflow) - WIP: Build image from repo on local FS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added capability to be able to build airflow image from the"},{"line_number":10,"context_line":"private git repo already cloned on the local file system."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3fa7e38b_0c8ba9c2","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"updated":"2019-09-30 18:42:32.000000000","message":"WIP?","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"1ef4ec6c52bc9d8fbc9cca31209d56493183351f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ahmad Mahmoudi \u003cahmad.mahmoudi@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-28 23:23:00 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"(airflow) - WIP: Build image from repo on local FS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added capability to be able to build airflow image from the"},{"line_number":10,"context_line":"private git repo already cloned on the local file system."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3fa7e38b_c7d80a1f","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"in_reply_to":"3fa7e38b_0c8ba9c2","updated":"2019-09-30 20:00:48.000000000","message":"Yeah, if this is WIP I would really like to see a -1 WF","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"}],"images/airflow/Dockerfile.opensuse_15":[{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"1226d2e7eb0772a04474e79b057ce8cff5b87e71","unresolved":false,"context_lines":[{"line_number":91,"context_line":"COPY images/airflow/requirements.txt /tmp/"},{"line_number":92,"context_line":"# copy the local host context to docker context, in case"},{"line_number":93,"context_line":"# AIRFLOW_SRC is the local file system."},{"line_number":94,"context_line":"COPY . /temp_ctx"},{"line_number":95,"context_line":"RUN pip3 install -r /tmp/requirements.txt --no-cache-dir \\"},{"line_number":96,"context_line":"    \u0026\u0026 pip3 install $AIRFLOW_SRC --no-cache-dir \\"},{"line_number":97,"context_line":"    \u0026\u0026 pip3 uninstall -y snakebite || true \\"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_073e22c0","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":16},"updated":"2019-09-30 19:00:25.000000000","message":"Where is the usage of this dir?","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"},{"author":{"_account_id":28664,"name":"Ahmad Mahmoudi","email":"ahmad.mahmoudi@att.com","username":"ahmad"},"change_message_id":"94a464a605549b72ce0101a5640660ffca7de814","unresolved":false,"context_lines":[{"line_number":91,"context_line":"COPY images/airflow/requirements.txt /tmp/"},{"line_number":92,"context_line":"# copy the local host context to docker context, in case"},{"line_number":93,"context_line":"# AIRFLOW_SRC is the local file system."},{"line_number":94,"context_line":"COPY . /temp_ctx"},{"line_number":95,"context_line":"RUN pip3 install -r /tmp/requirements.txt --no-cache-dir \\"},{"line_number":96,"context_line":"    \u0026\u0026 pip3 install $AIRFLOW_SRC --no-cache-dir \\"},{"line_number":97,"context_line":"    \u0026\u0026 pip3 uninstall -y snakebite || true \\"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_5985de05","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":16},"in_reply_to":"3fa7e38b_073e22c0","updated":"2019-09-30 20:55:02.000000000","message":"/temp_ctx is the root of the AIRFLOW_SRC it airflow is to be installed from the local file system.","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"},{"author":{"_account_id":23781,"name":"Stanislav Egorov","email":"realsystem@gmail.com","username":"StasEgorov"},"change_message_id":"7c0d8cca780acea7f01f3fdecaab08e8a3523a15","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# AIRFLOW_SRC is the local file system."},{"line_number":94,"context_line":"COPY . /temp_ctx"},{"line_number":95,"context_line":"RUN pip3 install -r /tmp/requirements.txt --no-cache-dir \\"},{"line_number":96,"context_line":"    \u0026\u0026 pip3 install $AIRFLOW_SRC --no-cache-dir \\"},{"line_number":97,"context_line":"    \u0026\u0026 pip3 uninstall -y snakebite || true \\"},{"line_number":98,"context_line":"    \u0026\u0026 rm -rf /temp_ctx"},{"line_number":99,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_4c9d2108","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":19},"updated":"2019-09-30 18:42:32.000000000","message":"Why not include all packages in requirements.txt and call install once?","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"},{"author":{"_account_id":28664,"name":"Ahmad Mahmoudi","email":"ahmad.mahmoudi@att.com","username":"ahmad"},"change_message_id":"94a464a605549b72ce0101a5640660ffca7de814","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# AIRFLOW_SRC is the local file system."},{"line_number":94,"context_line":"COPY . /temp_ctx"},{"line_number":95,"context_line":"RUN pip3 install -r /tmp/requirements.txt --no-cache-dir \\"},{"line_number":96,"context_line":"    \u0026\u0026 pip3 install $AIRFLOW_SRC --no-cache-dir \\"},{"line_number":97,"context_line":"    \u0026\u0026 pip3 uninstall -y snakebite || true \\"},{"line_number":98,"context_line":"    \u0026\u0026 rm -rf /temp_ctx"},{"line_number":99,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_19920658","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":19},"in_reply_to":"3fa7e38b_27c9de57","updated":"2019-09-30 20:55:02.000000000","message":"I moved this out because if airflow is installed from local file system, it will need the /temp_ctx as the source for the repo. other packages won\u0027t need the local context.","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"},{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"1ef4ec6c52bc9d8fbc9cca31209d56493183351f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# AIRFLOW_SRC is the local file system."},{"line_number":94,"context_line":"COPY . /temp_ctx"},{"line_number":95,"context_line":"RUN pip3 install -r /tmp/requirements.txt --no-cache-dir \\"},{"line_number":96,"context_line":"    \u0026\u0026 pip3 install $AIRFLOW_SRC --no-cache-dir \\"},{"line_number":97,"context_line":"    \u0026\u0026 pip3 uninstall -y snakebite || true \\"},{"line_number":98,"context_line":"    \u0026\u0026 rm -rf /temp_ctx"},{"line_number":99,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_27c9de57","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":19},"in_reply_to":"3fa7e38b_4c9d2108","updated":"2019-09-30 20:00:48.000000000","message":"The feature to separate the installation of the airflow source was added here [0] it looks like Ahmad is just moving it to a different location in the Dockerfile\n\n[0] https://review.opendev.org/#/c/679840/5","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"}],"images/airflow/Dockerfile.ubuntu_xenial":[{"author":{"_account_id":28628,"name":"Michael Beaver","email":"mibeaver@microsoft.com","username":"MichaelBeaver"},"change_message_id":"1ef4ec6c52bc9d8fbc9cca31209d56493183351f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"COPY images/airflow/requirements.txt /tmp/"},{"line_number":91,"context_line":"# copy the local host context to docker context, in case"},{"line_number":92,"context_line":"# AIRFLOW_SRC is the local file system."},{"line_number":93,"context_line":"COPY . /temp_ctx"},{"line_number":94,"context_line":"RUN pip3 install -r /tmp/requirements.txt --no-cache-dir \\"},{"line_number":95,"context_line":"    \u0026\u0026 pip3 install $AIRFLOW_SRC --no-cache-dir \\"},{"line_number":96,"context_line":"    \u0026\u0026 pip3 uninstall -y snakebite || true \\"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3fa7e38b_c71faab4","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":16},"updated":"2019-09-30 20:00:48.000000000","message":"I don\u0027t think copying the entire local context is the best solution here, if any file is changed that isn\u0027t ignored then the the docker cache will reset to this point. Perhaps an empty dir on the host that is designed for the repository to be in? Not sure if that would be the best either.","commit_id":"60269531333f9e558af3257aab766b5d50e2e726"}]}