)]}'
{"Makefile":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"13fb27bc8fcb0b068eeef0ddd5fe9ca4e59dc5f7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"USE_PROXY                  ?\u003d false"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"AIRFLOW_SRC                ?\u003d"},{"line_number":35,"context_line":"AIRFLOW_HOME               ?\u003d /usr/local/airflow"},{"line_number":36,"context_line":"DISTRO_BASE_IMAGE          ?\u003d"},{"line_number":37,"context_line":"DISTRO                     ?\u003d ubuntu_xenial"},{"line_number":38,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3fa7e38b_c6b3e509","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":48},"updated":"2019-10-22 14:36:45.000000000","message":"can we remove the default here, since it\u0027s already defaulted by the Dockerfile ARG?","commit_id":"4f2a8702495911dca5924a96f5891e8a7cdd15a0"}],"charts/shipyard/values.yaml":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"13fb27bc8fcb0b068eeef0ddd5fe9ca4e59dc5f7","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    # NOTE: Airflow 1.10 introduces a need to declare all config options:"},{"line_number":455,"context_line":"    #     https://issues.apache.org/jira/browse/AIRFLOW-3099"},{"line_number":456,"context_line":"    core:"},{"line_number":457,"context_line":"      # core.airflow_home is not used in 1.10.3 and later."},{"line_number":458,"context_line":"      # Envrionment variable AIRFLOW_HOME is used instead."},{"line_number":459,"context_line":"      #airflow_home: /usr/local/airflow"},{"line_number":460,"context_line":"      dags_folder: /usr/local/airflow/dags"},{"line_number":461,"context_line":"      base_log_folder: /usr/local/airflow/logs"},{"line_number":462,"context_line":"      remote_logging: \"False\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_c632055f","line":459,"range":{"start_line":457,"start_character":6,"end_line":459,"end_character":39},"updated":"2019-10-22 14:36:45.000000000","message":"any reason not to just remove that now?","commit_id":"4f2a8702495911dca5924a96f5891e8a7cdd15a0"},{"author":{"_account_id":28664,"name":"Ahmad Mahmoudi","email":"ahmad.mahmoudi@att.com","username":"ahmad"},"change_message_id":"6f0f79bf1c63a481342aa0a1284b7b3069307eec","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    # NOTE: Airflow 1.10 introduces a need to declare all config options:"},{"line_number":455,"context_line":"    #     https://issues.apache.org/jira/browse/AIRFLOW-3099"},{"line_number":456,"context_line":"    core:"},{"line_number":457,"context_line":"      # core.airflow_home is not used in 1.10.3 and later."},{"line_number":458,"context_line":"      # Envrionment variable AIRFLOW_HOME is used instead."},{"line_number":459,"context_line":"      #airflow_home: /usr/local/airflow"},{"line_number":460,"context_line":"      dags_folder: /usr/local/airflow/dags"},{"line_number":461,"context_line":"      base_log_folder: /usr/local/airflow/logs"},{"line_number":462,"context_line":"      remote_logging: \"False\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_865ded49","line":459,"range":{"start_line":457,"start_character":6,"end_line":459,"end_character":39},"in_reply_to":"3fa7e38b_c632055f","updated":"2019-10-22 14:49:30.000000000","message":"just wanted to keep this for the record. In next update I will remove it.","commit_id":"4f2a8702495911dca5924a96f5891e8a7cdd15a0"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"13fb27bc8fcb0b068eeef0ddd5fe9ca4e59dc5f7","unresolved":false,"context_lines":[{"line_number":499,"context_line":"      parallelism: 32"},{"line_number":500,"context_line":"      dag_concurrency: 8"},{"line_number":501,"context_line":"      dags_are_paused_at_creation: \"False\""},{"line_number":502,"context_line":"      # In 1.10.4, non_pooled_task_slot_count and non_pooled_backfill_task_slot_count are"},{"line_number":503,"context_line":"      # removed in favor of default_pool, which is initialized with 128 slots by default."},{"line_number":504,"context_line":"      #non_pooled_task_slot_count: 128"},{"line_number":505,"context_line":"      max_active_runs_per_dag: 8"},{"line_number":506,"context_line":"      load_examples: \"False\""},{"line_number":507,"context_line":"      plugins_folder: /usr/local/airflow/plugins"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_863c0d31","line":504,"range":{"start_line":502,"start_character":6,"end_line":504,"end_character":38},"updated":"2019-10-22 14:36:45.000000000","message":"any reason not to just remove that now?","commit_id":"4f2a8702495911dca5924a96f5891e8a7cdd15a0"},{"author":{"_account_id":28664,"name":"Ahmad Mahmoudi","email":"ahmad.mahmoudi@att.com","username":"ahmad"},"change_message_id":"6f0f79bf1c63a481342aa0a1284b7b3069307eec","unresolved":false,"context_lines":[{"line_number":499,"context_line":"      parallelism: 32"},{"line_number":500,"context_line":"      dag_concurrency: 8"},{"line_number":501,"context_line":"      dags_are_paused_at_creation: \"False\""},{"line_number":502,"context_line":"      # In 1.10.4, non_pooled_task_slot_count and non_pooled_backfill_task_slot_count are"},{"line_number":503,"context_line":"      # removed in favor of default_pool, which is initialized with 128 slots by default."},{"line_number":504,"context_line":"      #non_pooled_task_slot_count: 128"},{"line_number":505,"context_line":"      max_active_runs_per_dag: 8"},{"line_number":506,"context_line":"      load_examples: \"False\""},{"line_number":507,"context_line":"      plugins_folder: /usr/local/airflow/plugins"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_66547122","line":504,"range":{"start_line":502,"start_character":6,"end_line":504,"end_character":38},"in_reply_to":"3fa7e38b_863c0d31","updated":"2019-10-22 14:49:30.000000000","message":"same as above.","commit_id":"4f2a8702495911dca5924a96f5891e8a7cdd15a0"}],"images/airflow/Dockerfile.opensuse_15":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"29ddfe670c0808954c6754da0b47b1a8131fa10c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"ENV WEB_PORT 8080"},{"line_number":32,"context_line":"ENV FLOWER_PORT 5555"},{"line_number":33,"context_line":"ENV WORKER_PORT 8793"},{"line_number":34,"context_line":"# ENV SLUGIFY_USES_TEXT_UNIDECODE is not needed from 1.10.3."},{"line_number":35,"context_line":"# Airflow will always use text-unidecode, if unicode is not installed."},{"line_number":36,"context_line":"# ENV SLUGIFY_USES_TEXT_UNIDECODE yes"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Expose port for applications"},{"line_number":39,"context_line":"EXPOSE $WEB_PORT"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_791bfa7f","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":37},"updated":"2019-10-16 23:10:12.000000000","message":"What do you think about removing irrelevant variable from image build since we have a specific version configured in our build manifest that does not use it?\n\nSame applies in regards to ubuntu_xenial.","commit_id":"8655f21719dddcc68d731b9e1607f077f27b98f9"},{"author":{"_account_id":28664,"name":"Ahmad Mahmoudi","email":"ahmad.mahmoudi@att.com","username":"ahmad"},"change_message_id":"5911034c6c4508a49172ddfc15e9817367480d3f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"ENV WEB_PORT 8080"},{"line_number":32,"context_line":"ENV FLOWER_PORT 5555"},{"line_number":33,"context_line":"ENV WORKER_PORT 8793"},{"line_number":34,"context_line":"# ENV SLUGIFY_USES_TEXT_UNIDECODE is not needed from 1.10.3."},{"line_number":35,"context_line":"# Airflow will always use text-unidecode, if unicode is not installed."},{"line_number":36,"context_line":"# ENV SLUGIFY_USES_TEXT_UNIDECODE yes"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Expose port for applications"},{"line_number":39,"context_line":"EXPOSE $WEB_PORT"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_2ff0d4fc","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":37},"in_reply_to":"3fa7e38b_791bfa7f","updated":"2019-10-17 01:58:45.000000000","message":"Not necessary at this point. we can wait until airflow 2.0 to remove these.","commit_id":"8655f21719dddcc68d731b9e1607f077f27b98f9"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5fd00985d797ddfb3b6ef5230d577c46b97f5fe0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"ARG ctx_base\u003dsrc/bin"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Kubectl version"},{"line_number":47,"context_line":"ARG KUBECTL_VERSION\u003d1.16.1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Needed from apache-airflow 1.10.2, since core.airflow_home config is deprecated"},{"line_number":50,"context_line":"ENV AIRFLOW_HOME\u003d${AIRFLOW_HOME}"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"3fa7e38b_2baae170","line":47,"range":{"start_line":47,"start_character":19,"end_line":47,"end_character":26},"updated":"2019-10-19 21:10:35.000000000","message":"should this be 1.16.2?","commit_id":"e1e71d17f1b3daafb694dd9263063e93b8a106f7"},{"author":{"_account_id":28664,"name":"Ahmad Mahmoudi","email":"ahmad.mahmoudi@att.com","username":"ahmad"},"change_message_id":"589318a6fb06ef0c6ea9e00c7bc260d7e428cf22","unresolved":false,"context_lines":[{"line_number":44,"context_line":"ARG ctx_base\u003dsrc/bin"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Kubectl version"},{"line_number":47,"context_line":"ARG KUBECTL_VERSION\u003d1.16.1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Needed from apache-airflow 1.10.2, since core.airflow_home config is deprecated"},{"line_number":50,"context_line":"ENV AIRFLOW_HOME\u003d${AIRFLOW_HOME}"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"3fa7e38b_c359a935","line":47,"range":{"start_line":47,"start_character":19,"end_line":47,"end_character":26},"in_reply_to":"3fa7e38b_2baae170","updated":"2019-10-21 15:01:53.000000000","message":"Done","commit_id":"e1e71d17f1b3daafb694dd9263063e93b8a106f7"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"a8cff126f59bc360f599917fe82f4c6e5495754f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Kubectl version"},{"line_number":47,"context_line":"ARG KUBECTL_VERSION\u003d1.16.2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Needed from apache-airflow 1.10.2, since core.airflow_home config is deprecated"},{"line_number":50,"context_line":"ENV AIRFLOW_HOME\u003d${AIRFLOW_HOME}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"RUN set -ex \u0026\u0026 \\"},{"line_number":53,"context_line":"    zypper -q update -y ;\\"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3fa7e38b_20498c8a","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":32},"updated":"2019-10-21 21:34:50.000000000","message":"should we be making this overridable in the chart as env vars to pass to the container as well? or is it statically known at the time of docker build?","commit_id":"e6ded09ffb375b8c46e3462bfd908281e1de863e"}],"images/airflow/Dockerfile.ubuntu_xenial":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5fd00985d797ddfb3b6ef5230d577c46b97f5fe0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"ARG ctx_base\u003dsrc/bin"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Kubectl version"},{"line_number":48,"context_line":"ARG KUBECTL_VERSION\u003d1.16.1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Needed from apache-airflow 1.10.2, since core.airflow_home config is deprecated"},{"line_number":51,"context_line":"ENV AIRFLOW_HOME\u003d${AIRFLOW_HOME}"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"3fa7e38b_4ba71da9","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":26},"updated":"2019-10-19 21:10:35.000000000","message":"ditto","commit_id":"e1e71d17f1b3daafb694dd9263063e93b8a106f7"}]}