)]}'
{"config/crd/bases/airship.airshipit.org_sipclusters.yaml":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"c45013d0fa072beedcd18b7997929145403b2da5","unresolved":true,"context_lines":[{"line_number":207,"context_line":"                            field via refactoring. It is unused for this service since"},{"line_number":208,"context_line":"                            we have the below node port range instead.\u0027"},{"line_number":209,"context_line":"                          properties:"},{"line_number":210,"context_line":"                            offset:"},{"line_number":211,"context_line":"                              description: \u0027Offset is the offset from `Start` of the"},{"line_number":212,"context_line":"                                inclusive ending port number in the range. This is"},{"line_number":213,"context_line":"                                preferred to an e.g. `End` field, so that we can support"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"86f0304d_59fc689b","line":210,"range":{"start_line":210,"start_character":28,"end_line":210,"end_character":34},"updated":"2021-05-10 15:33:23.000000000","message":"When I see \"offset\", it sounds like a modification against the range start, not the definition of the range end.  Maybe something like \"count\" or \"number\" or something be more clear?","commit_id":"637d45e5f537c2aaf056c546bbc9cd772616d45c"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"25f0efc36fdc9cc956cec98743fe0d0ecafb106f","unresolved":true,"context_lines":[{"line_number":207,"context_line":"                            field via refactoring. It is unused for this service since"},{"line_number":208,"context_line":"                            we have the below node port range instead.\u0027"},{"line_number":209,"context_line":"                          properties:"},{"line_number":210,"context_line":"                            offset:"},{"line_number":211,"context_line":"                              description: \u0027Offset is the offset from `Start` of the"},{"line_number":212,"context_line":"                                inclusive ending port number in the range. This is"},{"line_number":213,"context_line":"                                preferred to an e.g. `End` field, so that we can support"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9074276b_7708d6f9","line":210,"range":{"start_line":210,"start_character":28,"end_line":210,"end_character":34},"in_reply_to":"068b1945_962090e9","updated":"2021-05-10 21:24:41.000000000","message":"Can we instead use `--service-node-port-range\u003d\u003cstart\u003e-\u003cend\u003e` format?  That would be a closer match to the nodeport range definitions that we have in the subcluster networking catalogue already.","commit_id":"637d45e5f537c2aaf056c546bbc9cd772616d45c"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"a43ca4ac8fdfb4de3fe484bb6c27066134cae375","unresolved":true,"context_lines":[{"line_number":207,"context_line":"                            field via refactoring. It is unused for this service since"},{"line_number":208,"context_line":"                            we have the below node port range instead.\u0027"},{"line_number":209,"context_line":"                          properties:"},{"line_number":210,"context_line":"                            offset:"},{"line_number":211,"context_line":"                              description: \u0027Offset is the offset from `Start` of the"},{"line_number":212,"context_line":"                                inclusive ending port number in the range. This is"},{"line_number":213,"context_line":"                                preferred to an e.g. `End` field, so that we can support"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"068b1945_962090e9","line":210,"range":{"start_line":210,"start_character":28,"end_line":210,"end_character":34},"in_reply_to":"86f0304d_59fc689b","updated":"2021-05-10 16:16:36.000000000","message":"The issue is that the `--service-node-port-range\u003d\u003cstart\u003e+\u003coffset\u003e` is unfortunately inclusive of the end value, so if we want to substitute in the same value there and here (from the sub-cluster network catalogue), then a \"count\"/\"size\"/\"number\" field won\u0027t work. This is why in the sample SipCluster CR I have `offset: 9` since that leads to a round 10 node ports in the range. I agree we can probably make it more clear that this offset relates to the end value and not the start, e.g. \"endOffset\".","commit_id":"637d45e5f537c2aaf056c546bbc9cd772616d45c"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"086a9d244331cfb9f5f7e406e27b2d32480d6557","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                            field via refactoring. It is unused for this service since"},{"line_number":208,"context_line":"                            we have the below node port range instead.\u0027"},{"line_number":209,"context_line":"                          properties:"},{"line_number":210,"context_line":"                            offset:"},{"line_number":211,"context_line":"                              description: \u0027Offset is the offset from `Start` of the"},{"line_number":212,"context_line":"                                inclusive ending port number in the range. This is"},{"line_number":213,"context_line":"                                preferred to an e.g. `End` field, so that we can support"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"886703d6_887b76cb","line":210,"range":{"start_line":210,"start_character":28,"end_line":210,"end_character":34},"in_reply_to":"9074276b_7708d6f9","updated":"2021-05-11 16:53:39.000000000","message":"There are some trade offs, but I agree that may be the simplest/fastest way. Done.","commit_id":"637d45e5f537c2aaf056c546bbc9cd772616d45c"}]}