)]}'
{"tools/gate/Jenkinsfile":[{"author":{"_account_id":26628,"name":"Kaspars Skels","email":"kaspars.skels@att.com","username":"kskels"},"change_message_id":"7e816794dcf81606c98801a05548c0821e109fee","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    SHIPYARD_PASSWD \u003d shipyard.data"},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def rotate_passphrases \u003d {"},{"line_number":115,"context_line":"    sh \"site/tools/update-passwords.sh ${SITE_NAME}\""},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-groovy","patch_set":2,"id":"9fdfeff1_b7a26c99","line":114,"updated":"2019-02-08 23:21:34.000000000","message":"Should we call this \"update_passphrases\" - as really all we do is updating files.","commit_id":"77aa4b38fe4cf1efa5c1bbf301adaed37a203680"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"44a99194dfdc5032e5d8dc180f320e954ac4552b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    SHIPYARD_PASSWD \u003d shipyard.data"},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def rotate_passphrases \u003d {"},{"line_number":115,"context_line":"    sh \"site/tools/update-passwords.sh ${SITE_NAME}\""},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-groovy","patch_set":2,"id":"9fdfeff1_d78370a8","line":114,"in_reply_to":"9fdfeff1_b7a26c99","updated":"2019-02-08 23:40:40.000000000","message":"Done","commit_id":"77aa4b38fe4cf1efa5c1bbf301adaed37a203680"}],"tools/passphrase.sub":[{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"8eab8e39f51815057cdaac10c34b2403e9264126","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  layeringDefinition:"},{"line_number":7,"context_line":"    abstract: false"},{"line_number":8,"context_line":"    layer: site"},{"line_number":9,"context_line":"  storagePolicy: cleartext"},{"line_number":10,"context_line":"data: ${PP_VALUE}"},{"line_number":11,"context_line":"..."}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7faddb67_6fa788be","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":26},"updated":"2019-08-23 13:35:38.000000000","message":"when are we transitioning to encrypted passphrases?","commit_id":"a1c3deaf171bc65c3597ffad3915963956dd27ea"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"10a2126ca537ae11a3bfefcc3147ea5c8a78c947","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  layeringDefinition:"},{"line_number":7,"context_line":"    abstract: false"},{"line_number":8,"context_line":"    layer: site"},{"line_number":9,"context_line":"  storagePolicy: cleartext"},{"line_number":10,"context_line":"data: ${PP_VALUE}"},{"line_number":11,"context_line":"..."}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7faddb67_5248e55a","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":26},"in_reply_to":"7faddb67_6fa788be","updated":"2019-08-28 20:02:53.000000000","message":"I\u0027m not sure on the plan to transition to encrypted passphrases, but I can first re-work this patch to utilize pegleg here directly with a passphrase catalog, etc.","commit_id":"a1c3deaf171bc65c3597ffad3915963956dd27ea"}],"tools/passphrases.req":[{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"c908c4b5e92dce0be52ac2b4ec38d85a15110cd2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"osh_keystone_ldap_password"},{"line_number":3,"context_line":"ucp_armada_keystone_password"},{"line_number":4,"context_line":"ceph_swift_keystone_password"},{"line_number":5,"context_line":"ucp_postgres_admin_password"},{"line_number":6,"context_line":"ucp_oslo_db_admin_password"},{"line_number":7,"context_line":"ucp_deckhand_postgres_password"},{"line_number":8,"context_line":"ucp_deckhand_keystone_password"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7faddb67_0df400ce","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":27},"updated":"2019-08-22 02:37:39.000000000","message":"The list of current password has been changed, could you please refresh it?","commit_id":"f7630a2fed0bffafe2dc4f58707eb221acbbb90c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"9d0e3b00826cbbf4423b1d5c5de34fb2b3d90a03","unresolved":false,"context_lines":[{"line_number":2,"context_line":"osh_keystone_ldap_password"},{"line_number":3,"context_line":"ucp_armada_keystone_password"},{"line_number":4,"context_line":"ceph_swift_keystone_password"},{"line_number":5,"context_line":"ucp_postgres_admin_password"},{"line_number":6,"context_line":"ucp_oslo_db_admin_password"},{"line_number":7,"context_line":"ucp_deckhand_postgres_password"},{"line_number":8,"context_line":"ucp_deckhand_keystone_password"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7faddb67_520fe187","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":27},"in_reply_to":"7faddb67_0df400ce","updated":"2019-08-22 20:45:06.000000000","message":"Done. Thanks.","commit_id":"f7630a2fed0bffafe2dc4f58707eb221acbbb90c"}],"tools/update-passwords.sh":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c70e8fbbc98d0d9c3001478c0aab04aac969c0be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_47575259","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":44},"updated":"2019-02-15 20:25:46.000000000","message":"Please update header (year and author).","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"b9e1712e8bded4000334a9fe3698f900bbfb48ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_ad5cdd7c","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":44},"in_reply_to":"9fdfeff1_47575259","updated":"2019-02-15 22:02:48.000000000","message":"Done","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c70e8fbbc98d0d9c3001478c0aab04aac969c0be","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set -e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"SOURCE\u003d\"${BASH_SOURCE[0]}\""},{"line_number":20,"context_line":"script_name\u003d\"$SOURCE\""},{"line_number":21,"context_line":"DIR\u003d\"$( cd -P \"$( dirname \"$SOURCE\" )\" \u0026\u0026 pwd )\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"site_list\u003d\"$1\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_47dc32e3","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":21},"updated":"2019-02-15 20:25:46.000000000","message":"This variable is unused.","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"b9e1712e8bded4000334a9fe3698f900bbfb48ae","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set -e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"SOURCE\u003d\"${BASH_SOURCE[0]}\""},{"line_number":20,"context_line":"script_name\u003d\"$SOURCE\""},{"line_number":21,"context_line":"DIR\u003d\"$( cd -P \"$( dirname \"$SOURCE\" )\" \u0026\u0026 pwd )\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"site_list\u003d\"$1\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_4d577159","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":21},"in_reply_to":"9fdfeff1_47dc32e3","updated":"2019-02-15 22:02:48.000000000","message":"Done","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c70e8fbbc98d0d9c3001478c0aab04aac969c0be","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"site_list\u003d\"$1\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"PASSPHRASE_SRC_FILE\u003d\"$DIR/passphrases.req\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"secrets\u003dfalse"},{"line_number":28,"context_line":"for site in $site_list; do"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_67ae162f","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":42},"updated":"2019-02-15 20:25:46.000000000","message":"Should we make this value configurable?","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"b9e1712e8bded4000334a9fe3698f900bbfb48ae","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"site_list\u003d\"$1\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"PASSPHRASE_SRC_FILE\u003d\"$DIR/passphrases.req\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"secrets\u003dfalse"},{"line_number":28,"context_line":"for site in $site_list; do"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_0d4de9c2","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":42},"in_reply_to":"9fdfeff1_0dd8891b","updated":"2019-02-15 22:02:48.000000000","message":"Thanks. fixed","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"7a6ef01c754c130cad0a54832082ef9910062d73","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"site_list\u003d\"$1\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"PASSPHRASE_SRC_FILE\u003d\"$DIR/passphrases.req\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"secrets\u003dfalse"},{"line_number":28,"context_line":"for site in $site_list; do"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_c22fb03c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":42},"in_reply_to":"9fdfeff1_67ae162f","updated":"2019-02-15 20:43:36.000000000","message":"We could but I would think this list is static?","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"3b81e85938c1046bfbaef073090280fe3621e9ed","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"site_list\u003d\"$1\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"PASSPHRASE_SRC_FILE\u003d\"$DIR/passphrases.req\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"secrets\u003dfalse"},{"line_number":28,"context_line":"for site in $site_list; do"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_0dd8891b","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":42},"in_reply_to":"9fdfeff1_c22fb03c","updated":"2019-02-15 21:50:02.000000000","message":"\u003e We could but I would think this list is static?\n\nI meant the location of the file, rather than the concept of a list. I agree, the list should be static.","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"c70e8fbbc98d0d9c3001478c0aab04aac969c0be","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  IFS\u003d$\u0027\\n\u0027"},{"line_number":32,"context_line":"  for p in $(cat $PASSPHRASE_SRC_FILE); do"},{"line_number":33,"context_line":"    export PP_NAME\u003d\"$(echo $p | cut -d\u0027 \u0027 -f1)\""},{"line_number":34,"context_line":"    generate_secret\u003d\"$(echo $p | cut -d\u0027 \u0027 -f2)\""},{"line_number":35,"context_line":"    secrets_file\u003d\"$DIR/../site/$site/secrets/passphrases/${PP_NAME}.yaml\""},{"line_number":36,"context_line":"      # generate passphrase"},{"line_number":37,"context_line":"      pass\u003d$(tr -dc A-Za-z0-9 \u003c /dev/urandom 2\u003e/dev/null | head -c 20)"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_6785b6ac","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":48},"updated":"2019-02-15 20:25:46.000000000","message":"I don\u0027t think this is used elsewhere either.","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"b9e1712e8bded4000334a9fe3698f900bbfb48ae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  IFS\u003d$\u0027\\n\u0027"},{"line_number":32,"context_line":"  for p in $(cat $PASSPHRASE_SRC_FILE); do"},{"line_number":33,"context_line":"    export PP_NAME\u003d\"$(echo $p | cut -d\u0027 \u0027 -f1)\""},{"line_number":34,"context_line":"    generate_secret\u003d\"$(echo $p | cut -d\u0027 \u0027 -f2)\""},{"line_number":35,"context_line":"    secrets_file\u003d\"$DIR/../site/$site/secrets/passphrases/${PP_NAME}.yaml\""},{"line_number":36,"context_line":"      # generate passphrase"},{"line_number":37,"context_line":"      pass\u003d$(tr -dc A-Za-z0-9 \u003c /dev/urandom 2\u003e/dev/null | head -c 20)"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fdfeff1_2d48edb0","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":48},"in_reply_to":"9fdfeff1_6785b6ac","updated":"2019-02-15 22:02:48.000000000","message":"Done","commit_id":"48c4fb2b1ca2fc05e6159d7d65bc20e56185254c"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"b5c33b3d44e77d924b00215f128e7ad7bb259e66","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"site_list\u003d\"$1\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"PASSPHRASE_SRC_FILE\u003d\"${2:-$DIR/passphrases.req}\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"secrets\u003dfalse"},{"line_number":27,"context_line":"for site in $site_list; do"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9fdfeff1_dec20987","line":24,"range":{"start_line":24,"start_character":20,"end_line":24,"end_character":48},"updated":"2019-02-18 18:22:53.000000000","message":"I see an environment variable as a better fit for this, but I do not feel strongly enough to vote negatively.","commit_id":"290147ba4e510d398ac70a2bef4baff2879f688e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"72d4410b6221583b5f6c6c0718d0be7aaeda86f2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  mkdir -p \"$site_dir/secrets/passphrases\""},{"line_number":30,"context_line":"  IFS\u003d$\u0027\\n\u0027"},{"line_number":31,"context_line":"  for p in $(cat $PASSPHRASE_SRC_FILE); do"},{"line_number":32,"context_line":"    export PP_NAME\u003d\"$(echo $p | cut -d\u0027 \u0027 -f1)\""},{"line_number":33,"context_line":"    secrets_file\u003d\"$DIR/../site/$site/secrets/passphrases/${PP_NAME}.yaml\""},{"line_number":34,"context_line":"      # generate passphrase"},{"line_number":35,"context_line":"      pass\u003d$(tr -dc A-Za-z0-9 \u003c /dev/urandom 2\u003e/dev/null | head -c 20)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9fdfeff1_ac49c332","line":32,"range":{"start_line":32,"start_character":32,"end_line":32,"end_character":45},"updated":"2019-02-22 14:02:27.000000000","message":"why is it done? maybe better to fail if PP_NAME contains space?","commit_id":"05aeae52511ad9629df3f0d60807ab4a80735635"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"507d3051d3dbadc5e61b6381fccf418d32be4598","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  mkdir -p \"$site_dir/secrets/passphrases\""},{"line_number":30,"context_line":"  IFS\u003d$\u0027\\n\u0027"},{"line_number":31,"context_line":"  for p in $(cat $PASSPHRASE_SRC_FILE); do"},{"line_number":32,"context_line":"    export PP_NAME\u003d\"$(echo $p | cut -d\u0027 \u0027 -f1)\""},{"line_number":33,"context_line":"    secrets_file\u003d\"$DIR/../site/$site/secrets/passphrases/${PP_NAME}.yaml\""},{"line_number":34,"context_line":"      # generate passphrase"},{"line_number":35,"context_line":"      pass\u003d$(tr -dc A-Za-z0-9 \u003c /dev/urandom 2\u003e/dev/null | head -c 20)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9fdfeff1_40c013e1","line":32,"range":{"start_line":32,"start_character":32,"end_line":32,"end_character":45},"in_reply_to":"9fdfeff1_ac49c332","updated":"2019-02-22 22:32:45.000000000","message":"The idea is that someone can add a comment for that particular entry for example:\n\nubuntu_crypt_password linux-crypt-sha-512\n\nor\n\nipmi_admin_password do_not_generate","commit_id":"05aeae52511ad9629df3f0d60807ab4a80735635"},{"author":{"_account_id":29624,"name":"Alexander Hughes","email":"Alexander.Hughes@pm.me","username":"alexanderhughes"},"change_message_id":"58c544ba3a00c204fc889bd99bd441abba65fc96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2019 The Treasuremap Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ffb9cba7_f015fbe5","line":3,"range":{"start_line":3,"start_character":17,"end_line":3,"end_character":41},"updated":"2019-05-02 01:10:53.000000000","message":"should this read AT\u0026T instead?","commit_id":"517469c2ca1d0ee578fbb796ddb5eaced3c121d9"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"2b1cbb5c8157b30c41915ddfdaf9d7d08473dfe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2019 The Treasuremap Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-sh","patch_set":9,"id":"dfbec78f_ef72b5e3","line":3,"range":{"start_line":3,"start_character":17,"end_line":3,"end_character":41},"in_reply_to":"ffb9cba7_f015fbe5","updated":"2019-05-02 17:32:31.000000000","message":"Done","commit_id":"517469c2ca1d0ee578fbb796ddb5eaced3c121d9"},{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"7a6efe421c50130ce95565fff9875d3b8d2fd967","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      secrets\u003dtrue"},{"line_number":40,"context_line":"      # Update admin keystone password for test tools"},{"line_number":41,"context_line":"      if [ \"${PP_NAME}\" \u003d \"osh_keystone_admin_password\" ]; then"},{"line_number":42,"context_line":"        sed -i -e \"s/password123/${PP_VALUE}/g\" $DIR/openstack"},{"line_number":43,"context_line":"      fi"},{"line_number":44,"context_line":"  done"},{"line_number":45,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":10,"id":"7faddb67_b65bdf51","line":42,"updated":"2019-08-20 17:09:47.000000000","message":"I would feel more confident if here it searches the whole assignemnt expression with the OSH_ADMIN_PASSWD variable name in the search and replacement pattern so it won\u0027t accidentaly break if another password123 occurrence is added in the future. Since the change is low, I don\u0027t feel strongly enough to -1.","commit_id":"898663eb958ae06aaed0ec375e5b19f23c47538a"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"5d1f714a9dead92f27e73dcc98ed1f352e486b62","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      secrets\u003dtrue"},{"line_number":40,"context_line":"      # Update admin keystone password for test tools"},{"line_number":41,"context_line":"      if [ \"${PP_NAME}\" \u003d \"osh_keystone_admin_password\" ]; then"},{"line_number":42,"context_line":"        sed -i -e \"s/password123/${PP_VALUE}/g\" $DIR/openstack"},{"line_number":43,"context_line":"      fi"},{"line_number":44,"context_line":"  done"},{"line_number":45,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":10,"id":"7faddb67_6c89166d","line":42,"in_reply_to":"7faddb67_b65bdf51","updated":"2019-08-20 18:01:38.000000000","message":"Agree on both counts w/ James - preferable but not needed for now","commit_id":"898663eb958ae06aaed0ec375e5b19f23c47538a"}]}