)]}'
{"tools/updater.py":[{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"a5efe522ed417ff1333e4b29650a72afb36baf30","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"                    if skip_list and image in skip_list:"},{"line_number":352,"context_line":"                        LOG.info(\"Ignoring image %s, it is in a \""},{"line_number":353,"context_line":"                                    \"skip list\", image)"},{"line_number":354,"context_line":"                        continue"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"                    new_image_tag \u003d get_image_tag(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_4f750598","line":353,"updated":"2019-07-03 19:13:24.000000000","message":"nit: this formatting seems wrong. The quotes should usually be aligned unless this was done by yapf.","commit_id":"0575191d1277731fc1a015e27d4860c449a92fd9"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"80c39fbfeae2bc54a4060518bff2f29ce84b23f6","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"                    if skip_list and image in skip_list:"},{"line_number":352,"context_line":"                        LOG.info(\"Ignoring image %s, it is in a \""},{"line_number":353,"context_line":"                                    \"skip list\", image)"},{"line_number":354,"context_line":"                        continue"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"                    new_image_tag \u003d get_image_tag(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a1d7e523","line":353,"in_reply_to":"7faddb67_4f750598","updated":"2019-07-04 08:22:03.000000000","message":"No, it\u0027s not by Yapf. Needs to be aligned trough the whole file, I agree.","commit_id":"0575191d1277731fc1a015e27d4860c449a92fd9"},{"author":{"_account_id":30173,"name":"Ian Pittwood","email":"pittwoodian@gmail.com","username":"ianp"},"change_message_id":"a5efe522ed417ff1333e4b29650a72afb36baf30","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                             \"\\\"versions.yaml\\\" (overwrite existing)\")"},{"line_number":510,"context_line":"    parser.add_argument(\"--skip\","},{"line_number":511,"context_line":"                        help\u003d\"comma-delimited list of images and charts \""},{"line_number":512,"context_line":"                             \"to skip during the update; e.g. \\\"ceph\\\" \""},{"line_number":513,"context_line":"                             \"will skip all charts and images which have \""},{"line_number":514,"context_line":"                             \"\\\"ceph\\\" in the name\")"},{"line_number":515,"context_line":"    parser.add_argument(\u0027--tag-filter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6f9fa1b4","line":512,"range":{"start_line":512,"start_character":62,"end_line":512,"end_character":64},"updated":"2019-07-03 19:13:24.000000000","message":"nit: use single quotes to wrap the string if you\u0027re using double quotes inside the string rather than escaping them","commit_id":"0575191d1277731fc1a015e27d4860c449a92fd9"},{"author":{"_account_id":28208,"name":"Roman Gorshunov","email":"roman.gorshunov@att.com","username":"gorshunovr"},"change_message_id":"80c39fbfeae2bc54a4060518bff2f29ce84b23f6","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                             \"\\\"versions.yaml\\\" (overwrite existing)\")"},{"line_number":510,"context_line":"    parser.add_argument(\"--skip\","},{"line_number":511,"context_line":"                        help\u003d\"comma-delimited list of images and charts \""},{"line_number":512,"context_line":"                             \"to skip during the update; e.g. \\\"ceph\\\" \""},{"line_number":513,"context_line":"                             \"will skip all charts and images which have \""},{"line_number":514,"context_line":"                             \"\\\"ceph\\\" in the name\")"},{"line_number":515,"context_line":"    parser.add_argument(\u0027--tag-filter\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_61132d0f","line":512,"range":{"start_line":512,"start_character":62,"end_line":512,"end_character":64},"in_reply_to":"7faddb67_6f9fa1b4","updated":"2019-07-04 08:22:03.000000000","message":"That was your suggestion to use only one type of quotes, so I\u0027ve changed all quotes to double quotes:\n\nhttps://review.opendev.org/#/c/661004/4/tools/updater.py@189\n\n\u003e We\u0027re using \u0027 some places and \" other places.\n\u003e PEP-8 suggests sticking to one or the other","commit_id":"0575191d1277731fc1a015e27d4860c449a92fd9"}]}