)]}'
{"site/airskiff/site-definition.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"ba3f2b30659fa19f64a0deb80245c21b96968c36","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  name: airskiff"},{"line_number":9,"context_line":"  storagePolicy: cleartext"},{"line_number":10,"context_line":"data:"},{"line_number":11,"context_line":"  site_type: skiff"},{"line_number":12,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_e9aad881","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":18},"updated":"2019-08-20 17:47:24.000000000","message":"I like the shortened name!","commit_id":"3d716135124115c185a6cd813ec6419b0174ea60"}],"site/airskiff/software/config/versions.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"ba3f2b30659fa19f64a0deb80245c21b96968c36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7faddb67_09b974ca","updated":"2019-08-20 17:47:24.000000000","message":"We should try and keep the top-level keys in the expected format, i.e.\n\n  ---\n  schema:\n  metadata:\n    name: doc-name\n  data:\n    values: {}\n  ...","commit_id":"3d716135124115c185a6cd813ec6419b0174ea60"},{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"de9fc35109dd290927af940e7765fb3f73145fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7faddb67_accb8e6f","in_reply_to":"7faddb67_09b974ca","updated":"2019-08-20 20:16:17.000000000","message":"Done","commit_id":"3d716135124115c185a6cd813ec6419b0174ea60"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"df7d980d63190441f3db84291385bf462c274f7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"schema: pegleg/SoftwareVersions/v1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  labels:"},{"line_number":5,"context_line":"    name: software-versions-airskiff-ubuntu"},{"line_number":6,"context_line":"  layeringDefinition:"},{"line_number":7,"context_line":"    abstract: false"},{"line_number":8,"context_line":"    layer: site"},{"line_number":9,"context_line":"    parentSelector:"},{"line_number":10,"context_line":"      name: software-versions-global"},{"line_number":11,"context_line":"    actions:"},{"line_number":12,"context_line":"      - method: merge"},{"line_number":13,"context_line":"        path: ."},{"line_number":14,"context_line":"  name: software-versions"},{"line_number":15,"context_line":"  replacement: true"},{"line_number":16,"context_line":"  schema: metadata/Document/v1"},{"line_number":17,"context_line":"  storagePolicy: cleartext"},{"line_number":18,"context_line":"data:"},{"line_number":19,"context_line":"  images:"},{"line_number":20,"context_line":"    ucp:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_2edd406f","line":17,"range":{"start_line":4,"start_character":0,"end_line":17,"end_character":26},"updated":"2019-08-21 14:47:15.000000000","message":"I should have also suggested ordering these keys as well, but it\u0027s not a huge deal. Just a bit unexpected.","commit_id":"c543c43100b6574454ae8e0b8d63dcfb3183a574"}],"type/skiff/manifests/bootstrap.yaml":[{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"ba3f2b30659fa19f64a0deb80245c21b96968c36","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  schema: metadata/Document/v1"},{"line_number":5,"context_line":"  replacement: true"},{"line_number":6,"context_line":"  name: cluster-bootstrap"},{"line_number":7,"context_line":"  labels:"},{"line_number":8,"context_line":"    name: cluster-bootstrap-type"},{"line_number":9,"context_line":"  layeringDefinition:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_292f90f6","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"updated":"2019-08-20 17:47:24.000000000","message":"nit: I\u0027d prefer we stay away from using the term \"cluster-boostrap\" since the K8s cluster is \"bootstrapped\" by minikube in Airskiff.\n\nSomething like airship-bootstrap or ucp-bootstrap is more accurate.","commit_id":"3d716135124115c185a6cd813ec6419b0174ea60"},{"author":{"_account_id":24580,"name":"James Gu","email":"james.gu@microsoft.com","username":"jamesgu"},"change_message_id":"de9fc35109dd290927af940e7765fb3f73145fd0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  schema: metadata/Document/v1"},{"line_number":5,"context_line":"  replacement: true"},{"line_number":6,"context_line":"  name: cluster-bootstrap"},{"line_number":7,"context_line":"  labels:"},{"line_number":8,"context_line":"    name: cluster-bootstrap-type"},{"line_number":9,"context_line":"  layeringDefinition:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_6ce836de","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"in_reply_to":"7faddb67_292f90f6","updated":"2019-08-20 20:16:17.000000000","message":"I agree with your point here. the clsuter-bootstrap is from global, are you suggesting to change the name convention from global?","commit_id":"3d716135124115c185a6cd813ec6419b0174ea60"},{"author":{"_account_id":8749,"name":"Evgeniy L","email":"eli@mirantis.com","username":"evgeniyl"},"change_message_id":"65790e9e0ae00fa2ca5e616cf2e6d2a71ed14164","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  schema: metadata/Document/v1"},{"line_number":5,"context_line":"  replacement: true"},{"line_number":6,"context_line":"  name: cluster-bootstrap"},{"line_number":7,"context_line":"  labels:"},{"line_number":8,"context_line":"    name: cluster-bootstrap-type"},{"line_number":9,"context_line":"  layeringDefinition:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_42e3c134","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"in_reply_to":"7faddb67_292f90f6","updated":"2019-08-20 19:28:22.000000000","message":"I think cluster-bootstrap if fine and it\u0027s consistent with other sites, it\u0027s not necessarily refers to k8s bootstrap, these are manifests that are applied after k8s is installed.","commit_id":"3d716135124115c185a6cd813ec6419b0174ea60"},{"author":{"_account_id":28618,"name":"Drew Walters","email":"drewwalters@microsoft.com","username":"drewwalters96"},"change_message_id":"df7d980d63190441f3db84291385bf462c274f7d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  schema: metadata/Document/v1"},{"line_number":5,"context_line":"  replacement: true"},{"line_number":6,"context_line":"  name: cluster-bootstrap"},{"line_number":7,"context_line":"  labels:"},{"line_number":8,"context_line":"    name: cluster-bootstrap-type"},{"line_number":9,"context_line":"  layeringDefinition:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_0e5ba421","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"in_reply_to":"7faddb67_6ce836de","updated":"2019-08-21 14:47:15.000000000","message":"\u003e are you suggesting to change the name convention from global?\n\nMy mistake! I overlooked that this document is used for layering. Let\u0027s save this for another change, since it\u0027s out-of-scope here.","commit_id":"3d716135124115c185a6cd813ec6419b0174ea60"}]}