)]}'
{"pkg/api/v1/vino_types.go":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"27cbdb04dfd17fb31ec6aa8eca40ae1cd2be2579","unresolved":true,"context_lines":[{"line_number":52,"context_line":"\t// BMCCredentials contain credentials that will be used to create BMH nodes"},{"line_number":53,"context_line":"\t// sushy tools will use these credentials as well, to set up authentication"},{"line_number":54,"context_line":"\tBMCCredentials BMCCredentials `json:\"bmcCredentials\"`"},{"line_number":55,"context_line":"\t// CopyNodeLabelKeys vino controller will get these labels from k8s nodes"},{"line_number":56,"context_line":"\t// and place them on BMHs that correspond to this node"},{"line_number":57,"context_line":"\tCopyNodeLabelKeys []string `json:\"copyNodeLabelKeys,omitempty\"`"},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":2,"id":"53f1714a_7a394b2b","line":55,"range":{"start_line":55,"start_character":47,"end_line":55,"end_character":59},"updated":"2021-03-25 14:57:11.000000000","message":"what do you think about using label key prefixes instead of requiring explicitly listing all keys. That would allow for example copying ALL node label keys by including an empty string prefix, or including a prefix of e.g. `vino.airshipit.org` so that node definitions can easily target vino. If someone still wants to spell out an entire label or set of labels they could still do that with this API. Regexes would be even more powerful, but that\u0027s probably overkill.","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"2d1f8955ff8de2189ec4bad7173b72c46170880b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"\t// BMCCredentials contain credentials that will be used to create BMH nodes"},{"line_number":53,"context_line":"\t// sushy tools will use these credentials as well, to set up authentication"},{"line_number":54,"context_line":"\tBMCCredentials BMCCredentials `json:\"bmcCredentials\"`"},{"line_number":55,"context_line":"\t// CopyNodeLabelKeys vino controller will get these labels from k8s nodes"},{"line_number":56,"context_line":"\t// and place them on BMHs that correspond to this node"},{"line_number":57,"context_line":"\tCopyNodeLabelKeys []string `json:\"copyNodeLabelKeys,omitempty\"`"},{"line_number":58,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":2,"id":"3a96f5b9_d89bce7d","line":55,"range":{"start_line":55,"start_character":47,"end_line":55,"end_character":59},"in_reply_to":"53f1714a_7a394b2b","updated":"2021-03-25 15:28:37.000000000","message":"I was thinking about making it globe. But to be honest I think we rather do it a little later (maybe as a separate field). I want us to actually reach the point where it is required and then change this to fit exactly what we need.\n\nAbout the vino part, i think it is vino will be targeting these nodes, not vice-versa.\n\nI can envision, that when metal3 provider will be able to copy the labels, we will mimic its behavior here.","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"27cbdb04dfd17fb31ec6aa8eca40ae1cd2be2579","unresolved":true,"context_lines":[{"line_number":54,"context_line":"\tBMCCredentials BMCCredentials `json:\"bmcCredentials\"`"},{"line_number":55,"context_line":"\t// CopyNodeLabelKeys vino controller will get these labels from k8s nodes"},{"line_number":56,"context_line":"\t// and place them on BMHs that correspond to this node"},{"line_number":57,"context_line":"\tCopyNodeLabelKeys []string `json:\"copyNodeLabelKeys,omitempty\"`"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"// BMCCredentials contain credentials that will be used to create BMH nodes"}],"source_content_type":"text/x-go","patch_set":2,"id":"5898ff6b_3c16cb55","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":18},"updated":"2021-03-25 14:57:11.000000000","message":"nit: would prefer noun phrase instead of verb e.g. NodeLabelKeysToCopy.","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"2d1f8955ff8de2189ec4bad7173b72c46170880b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\tBMCCredentials BMCCredentials `json:\"bmcCredentials\"`"},{"line_number":55,"context_line":"\t// CopyNodeLabelKeys vino controller will get these labels from k8s nodes"},{"line_number":56,"context_line":"\t// and place them on BMHs that correspond to this node"},{"line_number":57,"context_line":"\tCopyNodeLabelKeys []string `json:\"copyNodeLabelKeys,omitempty\"`"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"// BMCCredentials contain credentials that will be used to create BMH nodes"}],"source_content_type":"text/x-go","patch_set":2,"id":"1de9042b_6f12650d","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":18},"in_reply_to":"5898ff6b_3c16cb55","updated":"2021-03-25 15:28:37.000000000","message":"Done","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"27cbdb04dfd17fb31ec6aa8eca40ae1cd2be2579","unresolved":true,"context_lines":[{"line_number":100,"context_line":"\t//Parameter for Node master or worker-standard"},{"line_number":101,"context_line":"\tName  string `json:\"name,omitempty\"`"},{"line_number":102,"context_line":"\tCount int    `json:\"count,omitempty\"`"},{"line_number":103,"context_line":"\t// BMHLabels labels will be copied directly to BMHs that will be created"},{"line_number":104,"context_line":"\tBMHLabels                 map[string]string   `json:\"labels,omitempty\"`"},{"line_number":105,"context_line":"\tLibvirtTemplateDefinition NamespacedName      `json:\"libvirtTemplate,omitempty\"`"},{"line_number":106,"context_line":"\tNetworkInterfaces         []NetworkInterface  `json:\"networkInterfaces,omitempty\"`"}],"source_content_type":"text/x-go","patch_set":2,"id":"d56826a2_fb8f7cde","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":73},"updated":"2021-03-25 14:57:11.000000000","message":"nit: would be useful to state here that these will override the node labels to copy in case of conflict.","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"2d1f8955ff8de2189ec4bad7173b72c46170880b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"\t//Parameter for Node master or worker-standard"},{"line_number":101,"context_line":"\tName  string `json:\"name,omitempty\"`"},{"line_number":102,"context_line":"\tCount int    `json:\"count,omitempty\"`"},{"line_number":103,"context_line":"\t// BMHLabels labels will be copied directly to BMHs that will be created"},{"line_number":104,"context_line":"\tBMHLabels                 map[string]string   `json:\"labels,omitempty\"`"},{"line_number":105,"context_line":"\tLibvirtTemplateDefinition NamespacedName      `json:\"libvirtTemplate,omitempty\"`"},{"line_number":106,"context_line":"\tNetworkInterfaces         []NetworkInterface  `json:\"networkInterfaces,omitempty\"`"}],"source_content_type":"text/x-go","patch_set":2,"id":"2af162f0_cba56a9d","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":73},"in_reply_to":"d56826a2_fb8f7cde","updated":"2021-03-25 15:28:37.000000000","message":"Done","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"27cbdb04dfd17fb31ec6aa8eca40ae1cd2be2579","unresolved":true,"context_lines":[{"line_number":101,"context_line":"\tName  string `json:\"name,omitempty\"`"},{"line_number":102,"context_line":"\tCount int    `json:\"count,omitempty\"`"},{"line_number":103,"context_line":"\t// BMHLabels labels will be copied directly to BMHs that will be created"},{"line_number":104,"context_line":"\tBMHLabels                 map[string]string   `json:\"labels,omitempty\"`"},{"line_number":105,"context_line":"\tLibvirtTemplateDefinition NamespacedName      `json:\"libvirtTemplate,omitempty\"`"},{"line_number":106,"context_line":"\tNetworkInterfaces         []NetworkInterface  `json:\"networkInterfaces,omitempty\"`"},{"line_number":107,"context_line":"\tDiskDrives                *DiskDrivesTemplate `json:\"diskDrives,omitempty\"`"}],"source_content_type":"text/x-go","patch_set":2,"id":"a4364452_c36d3a49","line":104,"range":{"start_line":104,"start_character":54,"end_line":104,"end_character":60},"updated":"2021-03-25 14:57:11.000000000","message":"bmhLabels (to match the go field name, and provide more clarity)","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"2d1f8955ff8de2189ec4bad7173b72c46170880b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\tName  string `json:\"name,omitempty\"`"},{"line_number":102,"context_line":"\tCount int    `json:\"count,omitempty\"`"},{"line_number":103,"context_line":"\t// BMHLabels labels will be copied directly to BMHs that will be created"},{"line_number":104,"context_line":"\tBMHLabels                 map[string]string   `json:\"labels,omitempty\"`"},{"line_number":105,"context_line":"\tLibvirtTemplateDefinition NamespacedName      `json:\"libvirtTemplate,omitempty\"`"},{"line_number":106,"context_line":"\tNetworkInterfaces         []NetworkInterface  `json:\"networkInterfaces,omitempty\"`"},{"line_number":107,"context_line":"\tDiskDrives                *DiskDrivesTemplate `json:\"diskDrives,omitempty\"`"}],"source_content_type":"text/x-go","patch_set":2,"id":"2bfbf507_4b54db57","line":104,"range":{"start_line":104,"start_character":54,"end_line":104,"end_character":60},"in_reply_to":"a4364452_c36d3a49","updated":"2021-03-25 15:28:37.000000000","message":"Done","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"}],"pkg/controllers/bmh.go":[{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"27cbdb04dfd17fb31ec6aa8eca40ae1cd2be2579","unresolved":true,"context_lines":[{"line_number":185,"context_line":"\t\t\t\treturn err"},{"line_number":186,"context_line":"\t\t\t}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"\t\t\t// TODO extend this function to return server/rack labels as well"},{"line_number":189,"context_line":"\t\t\tbmcAddr, labels, err :\u003d r.getBMCAddressAndLabel(ctx, pod, vino.Spec.CopyNodeLabelKeys, roleSuffix)"},{"line_number":190,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":191,"context_line":"\t\t\t\treturn err"}],"source_content_type":"text/x-go","patch_set":2,"id":"af0d16e9_d544c879","line":188,"range":{"start_line":188,"start_character":3,"end_line":188,"end_character":68},"updated":"2021-03-25 14:57:11.000000000","message":"is this now addressed since these labels would be coming from the nodes?","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"2d1f8955ff8de2189ec4bad7173b72c46170880b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"\t\t\t\treturn err"},{"line_number":186,"context_line":"\t\t\t}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"\t\t\t// TODO extend this function to return server/rack labels as well"},{"line_number":189,"context_line":"\t\t\tbmcAddr, labels, err :\u003d r.getBMCAddressAndLabel(ctx, pod, vino.Spec.CopyNodeLabelKeys, roleSuffix)"},{"line_number":190,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":191,"context_line":"\t\t\t\treturn err"}],"source_content_type":"text/x-go","patch_set":2,"id":"e1419618_3ffddcd5","line":188,"range":{"start_line":188,"start_character":3,"end_line":188,"end_character":68},"in_reply_to":"af0d16e9_d544c879","updated":"2021-03-25 15:28:37.000000000","message":"hehe funny to see, that I knew this was coming. I\u0027ve spend 10 minutes thinking where to put this, while actually leaving a note to myself, and not seeing it :)","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"27cbdb04dfd17fb31ec6aa8eca40ae1cd2be2579","unresolved":true,"context_lines":[{"line_number":231,"context_line":"\treturn fmt.Sprintf(\"%s-%s-%s\", vino.Namespace, vino.Name, pod.Spec.NodeName)"},{"line_number":232,"context_line":"}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"func (r *VinoReconciler) getBMCAddressAndLabel("},{"line_number":235,"context_line":"\tctx context.Context,"},{"line_number":236,"context_line":"\tpod corev1.Pod,"},{"line_number":237,"context_line":"\tlabelKeys []string,"}],"source_content_type":"text/x-go","patch_set":2,"id":"6a1729fc_9e07ef34","line":234,"range":{"start_line":234,"start_character":41,"end_line":234,"end_character":46},"updated":"2021-03-25 14:57:11.000000000","message":"nit: Labels","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"2d1f8955ff8de2189ec4bad7173b72c46170880b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"\treturn fmt.Sprintf(\"%s-%s-%s\", vino.Namespace, vino.Name, pod.Spec.NodeName)"},{"line_number":232,"context_line":"}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"func (r *VinoReconciler) getBMCAddressAndLabel("},{"line_number":235,"context_line":"\tctx context.Context,"},{"line_number":236,"context_line":"\tpod corev1.Pod,"},{"line_number":237,"context_line":"\tlabelKeys []string,"}],"source_content_type":"text/x-go","patch_set":2,"id":"55f92f92_1895ea4b","line":234,"range":{"start_line":234,"start_character":41,"end_line":234,"end_character":46},"in_reply_to":"6a1729fc_9e07ef34","updated":"2021-03-25 15:28:37.000000000","message":"Done","commit_id":"3dde6efc12fa29c3610d3207548fc900eb2f2064"}]}