)]}'
{"libdrizzle-2.0/conn.cc":[{"author":{"_account_id":38903,"name":"Archon Spren","display_name":"Archon [review agent]","email":"archon@inaugust.com","username":"archonspren"},"change_message_id":"d55e57f49212e4457ac79a43ce268957316843a2","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"  while (1)"},{"line_number":1094,"context_line":"  {"},{"line_number":1095,"context_line":"    int ret\u003d connect(con-\u003efd, con-\u003eaddrinfo_next-\u003eai_addr, con-\u003eaddrinfo_next-\u003eai_addrlen);"},{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"    drizzle_log_crazy(con-\u003edrizzle, \"connect return\u003d%d errno\u003d%d\", ret, errno);"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    if (ret \u003d\u003d 0)"}],"source_content_type":"text/x-c","patch_set":1,"id":"ac0560d2_7906cc45","line":1096,"updated":"2026-06-03 01:53:43.000000000","message":"This breaks the `_WIN32` path: Winsock socket calls report failures via `WSAGetLastError()`, not POSIX `errno`. With the remapping removed, a nonblocking `connect()` that returns `WSAEWOULDBLOCK`/`WSAEINPROGRESS` will not be recognized as `EINPROGRESS`, so the connection state machine falls through to `DRIZZLE_RETURN_ERRNO` instead of waiting for `POLLOUT`. If the goal is to fix the old code setting errno after successful calls, please keep the Winsock translation but only apply it when `ret \u003d\u003d -1`/`SOCKET_ERROR` (ideally via a helper).","commit_id":"9d6604b7b553a3a549701b2e823fec7258a941d4"},{"author":{"_account_id":38903,"name":"Archon Spren","display_name":"Archon [review agent]","email":"archon@inaugust.com","username":"archonspren"},"change_message_id":"f61a0e427c037b42ef50fac456fa58b32cb6346a","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                      read_size, errno);"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"    if (read_size \u003d\u003d 0)"},{"line_number":1214,"context_line":"    {"},{"line_number":1215,"context_line":"      drizzle_set_error(con-\u003edrizzle, \"drizzle_state_read\","},{"line_number":1216,"context_line":"                        \"lost connection to server (EOF)\");"},{"line_number":1217,"context_line":"      return DRIZZLE_RETURN_LOST_CONNECTION;"}],"source_content_type":"text/x-c","patch_set":1,"id":"55c45311_d8490d25","line":1214,"updated":"2026-06-03 01:53:48.000000000","message":"Same issue for `recv()`: on Windows `WSAEWOULDBLOCK` is available from `WSAGetLastError()`, while `errno` is not the source of truth for Winsock failures. Without translating that to `EAGAIN`, nonblocking reads will be reported as generic errors instead of returning `DRIZZLE_RETURN_IO_WAIT`.","commit_id":"9d6604b7b553a3a549701b2e823fec7258a941d4"}]}