)]}'
{"jenkins/__init__.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f6bb0472cab6f66149ff2e05570a9d012042839c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            self.auth \u003d None"},{"line_number":161,"context_line":"        self.crumb \u003d None"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def __get_encoded_params__(self, params):"},{"line_number":164,"context_line":"        for k, v in params.items():"},{"line_number":165,"context_line":"            if k in [\"name\", \"to_name\", \"from_name\", \"msg\"]:"},{"line_number":166,"context_line":"                params[k] \u003d quote(v)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_115aa34f","line":163,"updated":"2014-12-04 16:37:35.000000000","message":"Is there a reason to use __ prefix and suffix on the method name?  I would have expected _get_encoded_params().  I try to avoid using the __ because of the convention that that indicates that magic—i.e., some special interaction with Python or with a framework—is happening here.","commit_id":"aa92c3ef8ff0b7a924c3e6ad24e79507be7b5684"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"f9181f4e024861fe000b66d87cff4c66b804099a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            self.auth \u003d None"},{"line_number":161,"context_line":"        self.crumb \u003d None"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def __get_encoded_params__(self, params):"},{"line_number":164,"context_line":"        for k, v in params.items():"},{"line_number":165,"context_line":"            if k in [\"name\", \"to_name\", \"from_name\", \"msg\"]:"},{"line_number":166,"context_line":"                params[k] \u003d quote(v)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_7a197078","line":163,"in_reply_to":"5a890539_115aa34f","updated":"2014-12-10 18:41:16.000000000","message":"good point. Done.","commit_id":"aa92c3ef8ff0b7a924c3e6ad24e79507be7b5684"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f6bb0472cab6f66149ff2e05570a9d012042839c","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        :param from_name: Name of Jenkins job to rename, ``str``"},{"line_number":471,"context_line":"        :param to_name: New Jenkins job name, ``str``"},{"line_number":472,"context_line":"        \u0027\u0027\u0027"},{"line_number":473,"context_line":"        self.assert_job_exists(from_name)"},{"line_number":474,"context_line":"        self.jenkins_open(Request("},{"line_number":475,"context_line":"            self.server + RENAME_JOB % self.__get_encoded_params__(locals()), \u0027\u0027))"},{"line_number":476,"context_line":"        self.assert_job_exists(to_name, \u0027rename[%s] failed\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_cc207e9c","line":473,"updated":"2014-12-04 16:37:35.000000000","message":"You know, this may begin to explain a problem I\u0027ve been noticing with jenkins-jobs taking forever to run: we\u0027re doing at least 2 round-trips (and sometimes 3) with the API whenever we run any of these methods.  I wonder if my 404 suggestion would help eliminate the need for the assert_job_exists() call?","commit_id":"aa92c3ef8ff0b7a924c3e6ad24e79507be7b5684"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"f9181f4e024861fe000b66d87cff4c66b804099a","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        :param from_name: Name of Jenkins job to rename, ``str``"},{"line_number":471,"context_line":"        :param to_name: New Jenkins job name, ``str``"},{"line_number":472,"context_line":"        \u0027\u0027\u0027"},{"line_number":473,"context_line":"        self.assert_job_exists(from_name)"},{"line_number":474,"context_line":"        self.jenkins_open(Request("},{"line_number":475,"context_line":"            self.server + RENAME_JOB % self.__get_encoded_params__(locals()), \u0027\u0027))"},{"line_number":476,"context_line":"        self.assert_job_exists(to_name, \u0027rename[%s] failed\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_9a4e1c6e","line":473,"in_reply_to":"5a890539_cc207e9c","updated":"2014-12-10 18:41:16.000000000","message":"I don\u0027t see how it would but if you think it will then please push a change for review.","commit_id":"aa92c3ef8ff0b7a924c3e6ad24e79507be7b5684"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c60a0f382c3e96ec5d912d6d5b5a801940f44603","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        :param from_name: Name of Jenkins job to rename, ``str``"},{"line_number":471,"context_line":"        :param to_name: New Jenkins job name, ``str``"},{"line_number":472,"context_line":"        \u0027\u0027\u0027"},{"line_number":473,"context_line":"        self.assert_job_exists(from_name)"},{"line_number":474,"context_line":"        self.jenkins_open(Request("},{"line_number":475,"context_line":"            self.server + RENAME_JOB % self._get_encoded_params(locals()), \u0027\u0027))"},{"line_number":476,"context_line":"        self.assert_job_exists(to_name, \u0027rename[%s] failed\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_10a4cba4","line":473,"updated":"2014-12-10 19:18:00.000000000","message":"Well, for this case, if we were to try to rename a job and get a 404, we\u0027d know that the job doesn\u0027t, in fact, exist, which is what assert_job_exists() is trying to check.  That makes assert_job_exists() redundant.  You might still want it after the actions, to ensure that they\u0027ve done what they\u0027re supposed to, but it would reduce the number of round-trips you have to make to the API, which should speed things up quite a bit.\n\nTo put this in perspective, when we run jenkins-jobs on our Jenkins configuration, it can take 30 minutes or more to update 96 jobs; any small reduction in time taken, such as could come from reducing the number of round trips, would be a huge win for us.","commit_id":"ebe1052b6067183837e05123cf0c96a08fe6a5c6"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"0b829fe67056cbe8e568c98fd9774d184e5cb2ef","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        :param from_name: Name of Jenkins job to rename, ``str``"},{"line_number":471,"context_line":"        :param to_name: New Jenkins job name, ``str``"},{"line_number":472,"context_line":"        \u0027\u0027\u0027"},{"line_number":473,"context_line":"        self.assert_job_exists(from_name)"},{"line_number":474,"context_line":"        self.jenkins_open(Request("},{"line_number":475,"context_line":"            self.server + RENAME_JOB % self._get_encoded_params(locals()), \u0027\u0027))"},{"line_number":476,"context_line":"        self.assert_job_exists(to_name, \u0027rename[%s] failed\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_426cc635","line":473,"in_reply_to":"3a961159_10a4cba4","updated":"2014-12-10 22:28:49.000000000","message":"Yep, you have a good point.  How about you propose a change for this?  It would be good to make it dependent on change I98320d174  because that change should verify 404 conditions on every method.","commit_id":"ebe1052b6067183837e05123cf0c96a08fe6a5c6"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"f6294dde3144ed58d608920df564e0d18a2cca2b","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        :param from_name: Name of Jenkins job to rename, ``str``"},{"line_number":471,"context_line":"        :param to_name: New Jenkins job name, ``str``"},{"line_number":472,"context_line":"        \u0027\u0027\u0027"},{"line_number":473,"context_line":"        self.assert_job_exists(from_name)"},{"line_number":474,"context_line":"        self.jenkins_open(Request("},{"line_number":475,"context_line":"            self.server + RENAME_JOB % self._get_encoded_params(locals()), \u0027\u0027))"},{"line_number":476,"context_line":"        self.assert_job_exists(to_name, \u0027rename[%s] failed\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_2a07c182","line":473,"in_reply_to":"3a961159_426cc635","updated":"2014-12-17 19:51:59.000000000","message":"Maybe it would be worth caching all the jobs from the jenkins server in the jenkins object with a single request. Then only updating that list as necessary.\n\nShould reduce the number of round trips needed.\n\n@Kevin if you\u0027re finding performance with JJB an issue, I would suggest testing out the following approaches to parallel upload in JJB:\n\nIee8426ff2dc4c5b4ebec4c15bdd21cae5b47eb83\n\nIe92be45d418b8076874b9eabca7e4ea8fb8fbad1","commit_id":"ebe1052b6067183837e05123cf0c96a08fe6a5c6"}]}
