)]}'
{"jenkins/__init__.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cec855174944d4f64e88a398666fa07b4b5fd202","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from six.moves.urllib.error import URLError"},{"line_number":55,"context_line":"from six.moves.urllib.parse import quote, urlencode"},{"line_number":56,"context_line":"from six.moves.urllib.request import Request, urlopen"},{"line_number":57,"context_line":"import socket"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LAUNCHER_SSH \u003d \u0027hudson.plugins.sshslaves.SSHLauncher\u0027"},{"line_number":60,"context_line":"LAUNCHER_COMMAND \u003d \u0027hudson.slaves.CommandLauncher\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_9d521367","line":57,"updated":"2015-02-06 18:55:10.000000000","message":"If python-jenkins maintains the style guide for the rest of openstack, this import should probably be moved to line 50.  (femtonit)","commit_id":"fa2cf7f99c0e9d68b1528ce49b67e7bc54ce0bea"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"9f26c2a6737fa3390a8519f0171d724d55f50fef","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from six.moves.urllib.error import URLError"},{"line_number":55,"context_line":"from six.moves.urllib.parse import quote, urlencode"},{"line_number":56,"context_line":"from six.moves.urllib.request import Request, urlopen"},{"line_number":57,"context_line":"import socket"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LAUNCHER_SSH \u003d \u0027hudson.plugins.sshslaves.SSHLauncher\u0027"},{"line_number":60,"context_line":"LAUNCHER_COMMAND \u003d \u0027hudson.slaves.CommandLauncher\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_7ee1d5fd","line":57,"in_reply_to":"da86d52c_03a9627b","updated":"2015-02-06 20:23:59.000000000","message":"Does it?  If it\u0027s calling hacking, then each blank-line-separated group of imports is treated separately.  Ordering is why I proposed line 50 specifically.","commit_id":"fa2cf7f99c0e9d68b1528ce49b67e7bc54ce0bea"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"c80112e7ce7dd24f5b1e68fb01a69c8b852416d3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from six.moves.urllib.error import URLError"},{"line_number":55,"context_line":"from six.moves.urllib.parse import quote, urlencode"},{"line_number":56,"context_line":"from six.moves.urllib.request import Request, urlopen"},{"line_number":57,"context_line":"import socket"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LAUNCHER_SSH \u003d \u0027hudson.plugins.sshslaves.SSHLauncher\u0027"},{"line_number":60,"context_line":"LAUNCHER_COMMAND \u003d \u0027hudson.slaves.CommandLauncher\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_756c9309","line":57,"in_reply_to":"da86d52c_7ee1d5fd","updated":"2015-02-06 21:43:37.000000000","message":"Pardon, my mistake.  Done","commit_id":"fa2cf7f99c0e9d68b1528ce49b67e7bc54ce0bea"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"df10b3d40d8752bd2aacc1abbfb4d17b3a97f07d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from six.moves.urllib.error import URLError"},{"line_number":55,"context_line":"from six.moves.urllib.parse import quote, urlencode"},{"line_number":56,"context_line":"from six.moves.urllib.request import Request, urlopen"},{"line_number":57,"context_line":"import socket"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LAUNCHER_SSH \u003d \u0027hudson.plugins.sshslaves.SSHLauncher\u0027"},{"line_number":60,"context_line":"LAUNCHER_COMMAND \u003d \u0027hudson.slaves.CommandLauncher\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_03a9627b","line":57,"in_reply_to":"da86d52c_9d521367","updated":"2015-02-06 19:49:30.000000000","message":"The \u0027tox -e pep8\u0027 test checks for alphabetical import declarations so that won\u0027t work.","commit_id":"fa2cf7f99c0e9d68b1528ce49b67e7bc54ce0bea"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"f2c01e1af11bd78829b83024959ad66012dd350b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"LAUNCHER_JNLP \u003d \u0027hudson.slaves.JNLPLauncher\u0027"},{"line_number":62,"context_line":"LAUNCHER_WINDOWS_SERVICE \u003d \u0027hudson.os.windows.ManagedWindowsServiceLauncher\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"DEFAULT_CONN_TIMEOUT \u003d socket._GLOBAL_DEFAULT_TIMEOUT"},{"line_number":65,"context_line":"INFO \u003d \u0027api/json\u0027"},{"line_number":66,"context_line":"PLUGIN_INFO \u003d \u0027pluginManager/api/json?depth\u003d%(depth)s\u0027"},{"line_number":67,"context_line":"CRUMB_URL \u003d \u0027crumbIssuer/api/json\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_766d1d99","line":64,"updated":"2015-02-10 11:27:34.000000000","message":"Looking at python2.7 socket.py , socket._GLOBAL_DEFAULT_TIMEOUT is an empty object meant to detect whether a timeout is requested to be set:\n\n if timeout is not _GLOBAL_DEFAULT_TIMEOUT:\n     sock.settimeout(timeout)\n\n\nSo we end up with no timeout at all imho, not necessarily a problem since that is what is used in other python core code.","commit_id":"214c00e6198ee651da8df9a2731cd6760c8dd060"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"f2c01e1af11bd78829b83024959ad66012dd350b","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class Jenkins(object):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def __init__(self, url, username\u003dNone, password\u003dNone, timeout\u003dDEFAULT_CONN_TIMEOUT):"},{"line_number":153,"context_line":"        \u0027\u0027\u0027Create handle to Jenkins instance."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_f6bd8dd8","line":151,"updated":"2015-02-10 11:27:34.000000000","message":"I would remove our DEFAULT_CONN_TIMEOUT and rely directly on socket. _GLOBAL_DEFAULT_TIMEOUT  i.e.:\n\n timeout\u003dsocket._GLOBAL_DEFAULT_TIMEOUT","commit_id":"214c00e6198ee651da8df9a2731cd6760c8dd060"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"d3f80fc8e40c981251575cdc65427ab323a05c55","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class Jenkins(object):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def __init__(self, url, username\u003dNone, password\u003dNone, timeout\u003dDEFAULT_CONN_TIMEOUT):"},{"line_number":153,"context_line":"        \u0027\u0027\u0027Create handle to Jenkins instance."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_08c2b652","line":151,"in_reply_to":"da86d52c_f6bd8dd8","updated":"2015-02-11 17:56:27.000000000","message":"Done","commit_id":"214c00e6198ee651da8df9a2731cd6760c8dd060"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"f2c01e1af11bd78829b83024959ad66012dd350b","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        :param username: Server username, ``str``"},{"line_number":158,"context_line":"        :param password: Server password, ``str``"},{"line_number":159,"context_line":"        :param url: URL of Jenkins server, ``str``"},{"line_number":160,"context_line":"        :param timeout: Server connection timeout (in seconds), ``int``"},{"line_number":161,"context_line":"        \u0027\u0027\u0027"},{"line_number":162,"context_line":"        if url[-1] \u003d\u003d \u0027/\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_76c99d78","line":159,"updated":"2015-02-10 11:27:34.000000000","message":"Adjust the timeout parameter documentation to mention there is no timeout by default.","commit_id":"214c00e6198ee651da8df9a2731cd6760c8dd060"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"d3f80fc8e40c981251575cdc65427ab323a05c55","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        :param username: Server username, ``str``"},{"line_number":158,"context_line":"        :param password: Server password, ``str``"},{"line_number":159,"context_line":"        :param url: URL of Jenkins server, ``str``"},{"line_number":160,"context_line":"        :param timeout: Server connection timeout (in seconds), ``int``"},{"line_number":161,"context_line":"        \u0027\u0027\u0027"},{"line_number":162,"context_line":"        if url[-1] \u003d\u003d \u0027/\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_48a74ebd","line":159,"in_reply_to":"da86d52c_76c99d78","updated":"2015-02-11 17:56:27.000000000","message":"Done","commit_id":"214c00e6198ee651da8df9a2731cd6760c8dd060"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"3c5f04df9ea0c434bf7290d05c8da847438b5ad9","unresolved":false,"context_lines":[{"line_number":154,"context_line":"class Jenkins(object):"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, url, username\u003dNone, password\u003dNone,"},{"line_number":157,"context_line":"                 timeout\u003dsocket._GLOBAL_DEFAULT_TIMEOUT):"},{"line_number":158,"context_line":"        \u0027\u0027\u0027Create handle to Jenkins instance."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        All methods will raise :class:`JenkinsException` on failure."}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_b824a9c6","line":157,"updated":"2015-02-18 12:59:45.000000000","message":"While I dislike the idea of needing to access a modules private globals, it seems that we\u0027d have to do a bit of a dance otherwise.\n\nAlso since in socket timeouts \u0027None\u0027 has a special behaviour of triggering a blocking mode, it makes using it not possible.","commit_id":"503610b4e565943a48dbdc49e8d9da4693e49ee9"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"3c5f04df9ea0c434bf7290d05c8da847438b5ad9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        :param username: Server username, ``str``"},{"line_number":163,"context_line":"        :param password: Server password, ``str``"},{"line_number":164,"context_line":"        :param url: URL of Jenkins server, ``str``"},{"line_number":165,"context_line":"        :param timeout: Server connection timeout in secs (default: None), ``int``"},{"line_number":166,"context_line":"        \u0027\u0027\u0027"},{"line_number":167,"context_line":"        if url[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":168,"context_line":"            self.server \u003d url"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_b80bc929","line":165,"updated":"2015-02-18 12:59:45.000000000","message":"\u0027None\u0027 has a special meaning for socket timeouts, do you want to use \u0027not set\u0027 or something else instead?\n\nPossibly worth adding a comment in the code about the special behaviour on \u0027None\u0027 as well.","commit_id":"503610b4e565943a48dbdc49e8d9da4693e49ee9"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"accb1ef7c47287a96fb9cf6d5a9a47104e4df06d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        :param username: Server username, ``str``"},{"line_number":163,"context_line":"        :param password: Server password, ``str``"},{"line_number":164,"context_line":"        :param url: URL of Jenkins server, ``str``"},{"line_number":165,"context_line":"        :param timeout: Server connection timeout in secs (default: None), ``int``"},{"line_number":166,"context_line":"        \u0027\u0027\u0027"},{"line_number":167,"context_line":"        if url[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":168,"context_line":"            self.server \u003d url"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_57a36a42","line":165,"in_reply_to":"da86d52c_b80bc929","updated":"2015-02-18 19:14:46.000000000","message":"Done","commit_id":"503610b4e565943a48dbdc49e8d9da4693e49ee9"}],"tests/test_jenkins.py":[{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"f2c01e1af11bd78829b83024959ad66012dd350b","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_constructor_default_timeout(self):"},{"line_number":82,"context_line":"        j \u003d jenkins.Jenkins(\u0027http://example.com\u0027)"},{"line_number":83,"context_line":"        self.assertEqual(j.timeout, socket._GLOBAL_DEFAULT_TIMEOUT)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_constructor_custom_timeout(self):"},{"line_number":86,"context_line":"        j \u003d jenkins.Jenkins(\u0027http://example.com\u0027, timeout\u003d300)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_f67caded","line":83,"updated":"2015-02-10 11:27:34.000000000","message":"Sure :-).  I am also wondering whether we should exercise six urlopen() to connect to a listening socket and ensure the actual timeout value is properly set (i.e. no timeout).  Not sure it is worth it.","commit_id":"214c00e6198ee651da8df9a2731cd6760c8dd060"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"938e339a7ca024940fae9322c50bcd5939a08aed","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_constructor_default_timeout(self):"},{"line_number":82,"context_line":"        j \u003d jenkins.Jenkins(\u0027http://example.com\u0027)"},{"line_number":83,"context_line":"        self.assertEqual(j.timeout, socket._GLOBAL_DEFAULT_TIMEOUT)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_constructor_custom_timeout(self):"},{"line_number":86,"context_line":"        j \u003d jenkins.Jenkins(\u0027http://example.com\u0027, timeout\u003d300)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_754986cf","line":83,"in_reply_to":"da86d52c_f67caded","updated":"2015-02-10 16:45:51.000000000","message":"Honestly, I\u0027d like to see python-jenkins moved over to using requests…but I\u0027m *not* volunteering to do *that* work!  :)","commit_id":"214c00e6198ee651da8df9a2731cd6760c8dd060"}]}
