)]}'
{"jenkins/__init__.py":[{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"dee12f08d66389170def12759e7ad4aa430684bf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"import json"},{"line_number":50,"context_line":"import socket"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"import multi_key_dict"},{"line_number":53,"context_line":"import six"},{"line_number":54,"context_line":"from six.moves.http_client import BadStatusLine"},{"line_number":55,"context_line":"from six.moves.urllib.error import HTTPError"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_2ea0ec8f","line":52,"updated":"2015-02-20 20:20:07.000000000","message":"nit: maybe group this with the imports above?","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"4f0fe46b7beb6fef8e70fef92bd22d1fb246821b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"import json"},{"line_number":50,"context_line":"import socket"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"import multi_key_dict"},{"line_number":53,"context_line":"import six"},{"line_number":54,"context_line":"from six.moves.http_client import BadStatusLine"},{"line_number":55,"context_line":"from six.moves.urllib.error import HTTPError"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_96211f50","line":52,"in_reply_to":"1a6ced46_5a4eb8c2","updated":"2015-04-03 17:27:42.000000000","message":"actually i didn\u0027t know that was standard.  thanks for pointing it out to me.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"eb31a458a387124702bd7fd6ca291fab9a1ebbdd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"import json"},{"line_number":50,"context_line":"import socket"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"import multi_key_dict"},{"line_number":53,"context_line":"import six"},{"line_number":54,"context_line":"from six.moves.http_client import BadStatusLine"},{"line_number":55,"context_line":"from six.moves.urllib.error import HTTPError"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_5a4eb8c2","line":52,"in_reply_to":"ba7be1f8_2ea0ec8f","updated":"2015-03-23 19:06:20.000000000","message":"since it\u0027s a third party import I assumed we were still following the following groupings?:\n\n \u003csystem\u003e\n\n \u003c3rd party\u003e\n\n \u003cproject\u003e","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"281ba81b5cca3c9ae4e72247c6795d69fb69ec5f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False}, ..]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        try:"},{"line_number":432,"context_line":"            plugins_info \u003d json.loads(self.jenkins_open("},{"line_number":433,"context_line":"                Request(self.server + PLUGIN_INFO % locals())))"},{"line_number":434,"context_line":"            return plugins_info[\u0027plugins\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_19919799","line":431,"updated":"2015-02-22 21:04:38.000000000","message":"Possibly, and move the code to populate the plugins attribute into a separate function? The depth arg is putting me off a little since I\u0027m not sure of the best way to ensure that we\u0027re returning the correct depth of info, since this seems more of an API call to be used calling applications to get more detailed information.\n\nShould we leave this as a way to get direct access to the needed info?\nOr move it to a private method and only provide access through the plugins attribute?","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"dee12f08d66389170def12759e7ad4aa430684bf","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False}, ..]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        try:"},{"line_number":432,"context_line":"            plugins_info \u003d json.loads(self.jenkins_open("},{"line_number":433,"context_line":"                Request(self.server + PLUGIN_INFO % locals())))"},{"line_number":434,"context_line":"            return plugins_info[\u0027plugins\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_611af56f","line":431,"updated":"2015-02-20 20:20:07.000000000","message":"should this just return self.plugins?","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"4f0fe46b7beb6fef8e70fef92bd22d1fb246821b","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False}, ..]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        try:"},{"line_number":432,"context_line":"            plugins_info \u003d json.loads(self.jenkins_open("},{"line_number":433,"context_line":"                Request(self.server + PLUGIN_INFO % locals())))"},{"line_number":434,"context_line":"            return plugins_info[\u0027plugins\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_f6d62b26","line":431,"in_reply_to":"1a6ced46_7cd1affa","updated":"2015-04-03 17:27:42.000000000","message":"++","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":13487,"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"change_message_id":"ce1d94108b2a3d8c93c5a8661f3b1ae5ec8f3d48","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False}, ..]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        try:"},{"line_number":432,"context_line":"            plugins_info \u003d json.loads(self.jenkins_open("},{"line_number":433,"context_line":"                Request(self.server + PLUGIN_INFO % locals())))"},{"line_number":434,"context_line":"            return plugins_info[\u0027plugins\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_a442220e","line":431,"in_reply_to":"ba7be1f8_19919799","updated":"2015-02-23 00:24:46.000000000","message":"I think this would be useful for allowing consuming applications a way to directly access the info. For example, a long-running process that wants to periodically compare plugin version info from the same Jenkins master obtained at different times. Although I guess judicious use of deep copy should allow that to be done anyway.\n\nIf we do hide this method, there would have to be some method, \"refresh_plugins_info\" that would either set self._plugins to None or call the hidden _get_plugins_info method to pass its return value to the self.plugins setter (see my comment below on the \"plugins\" method).","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"eb31a458a387124702bd7fd6ca291fab9a1ebbdd","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False}, ..]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        try:"},{"line_number":432,"context_line":"            plugins_info \u003d json.loads(self.jenkins_open("},{"line_number":433,"context_line":"                Request(self.server + PLUGIN_INFO % locals())))"},{"line_number":434,"context_line":"            return plugins_info[\u0027plugins\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_7cd1affa","line":431,"in_reply_to":"ba7be1f8_a442220e","updated":"2015-03-23 19:06:20.000000000","message":"I guess the real question comes down to whether there should be methods to get the raw data as opposed to the parsed cached data that will be in the \u0027plugins\u0027 attribute.\n\nSince these methods also allow for control of the depth of info returned I\u0027m thinking of leaving them as is and have self.plugins populated by calling them rather than trying to make them get the info from the attribute.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":13487,"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"change_message_id":"ce1d94108b2a3d8c93c5a8661f3b1ae5ec8f3d48","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        self.plugins \u003d self.get_plugins_info(depth)"},{"line_number":467,"context_line":"        return self.plugins.get(name, None)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    @property"},{"line_number":470,"context_line":"    def plugins(self):"},{"line_number":471,"context_line":"        \u0027\u0027\u0027Lazy load property for interfacing with plugins.\u0027\u0027\u0027"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_843b5e9b","line":469,"updated":"2015-02-23 00:24:46.000000000","message":"Definitely not familiar with this pattern, but it looks interesting if a little non-obvious for newbies like myself.\n\nIt looks like the only way a consumer of this class could currently obtain updated plugins_info from the jenkins master is to either:\n\njenkins._plugins \u003d None\npinfo \u003d jenkins.plugins\n\nor:\n\njenksin.plugins \u003d jenkins.get_plugins_info()\n\nWhat do you think about a \"refresh_plugins_info\" method to handle a case like this? This would be useful for long-running processes that want to use this library but need to periodically validate that no plugin verions have changed. (For example, if someone wanted to tightly integrate Zuul and JJB...or maybe that\u0027s already a thing?)","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"eb31a458a387124702bd7fd6ca291fab9a1ebbdd","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        self.plugins \u003d self.get_plugins_info(depth)"},{"line_number":467,"context_line":"        return self.plugins.get(name, None)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    @property"},{"line_number":470,"context_line":"    def plugins(self):"},{"line_number":471,"context_line":"        \u0027\u0027\u0027Lazy load property for interfacing with plugins.\u0027\u0027\u0027"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_7cca8f50","line":469,"in_reply_to":"ba7be1f8_843b5e9b","updated":"2015-03-23 19:06:20.000000000","message":"Decided to restore the get_plugin_info and leave both it and get_plugins_info as methods to retrieve raw plugin data from the jenkins server.\n\nAdding a refresh_plugins_info to allow the plugins property to be refreshed.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":13487,"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"change_message_id":"ce1d94108b2a3d8c93c5a8661f3b1ae5ec8f3d48","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        return self._plugins"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @plugins.setter"},{"line_number":479,"context_line":"    def plugins(self, plugin_info):"},{"line_number":480,"context_line":"        self._plugins \u003d multi_key_dict.multi_key_dict()"},{"line_number":481,"context_line":"        for plugin_data in plugin_info:"},{"line_number":482,"context_line":"            self._plugins["}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_44e32633","line":479,"updated":"2015-02-23 00:24:46.000000000","message":"nit: pluralizing \"plugin_info\" seems like it would be a good idea, to stick with the established convention of using \"plugins_info\" to indicate an iterable of plugin info dicts.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3649524002b8925ba3b37174f74253a100a6573","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        return self._plugins"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    @plugins.setter"},{"line_number":503,"context_line":"    def plugins(self, plugins_info):"},{"line_number":504,"context_line":"        self._plugins \u003d multi_key_dict.multi_key_dict()"},{"line_number":505,"context_line":"        for plugin_data in plugins_info:"},{"line_number":506,"context_line":"            self._plugins["}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_893c46e4","line":503,"updated":"2015-03-24 15:40:05.000000000","message":"Is it expected for the user to be able to set the plugins attribute?  If not, I\u0027d suggest changing refresh_plugins_info() to store data directly in the underlying self._plugins attribute, rather than having a setter like this.  That would essentially entail merging refresh_plugins_info() and this setter, but would eliminate the possibility of the user accidentally overwriting plugins.","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"28aaac9e86bdb6b5920ed4e58f207b18f1f1bea8","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        return self._plugins"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    @plugins.setter"},{"line_number":503,"context_line":"    def plugins(self, plugins_info):"},{"line_number":504,"context_line":"        self._plugins \u003d multi_key_dict.multi_key_dict()"},{"line_number":505,"context_line":"        for plugin_data in plugins_info:"},{"line_number":506,"context_line":"            self._plugins["}],"source_content_type":"text/x-python","patch_set":5,"id":"da9b358b_7b89c825","line":503,"in_reply_to":"1a6ced46_893c46e4","updated":"2015-04-01 09:28:47.000000000","message":"Good point, I didn\u0027t think to rewrite this after abandoning having it be updated by get_plugins_info() to leave them as immediate raw retrieval methods.","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3649524002b8925ba3b37174f74253a100a6573","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                str(plugin_data[\u0027longName\u0027])] \u003d plugins.Plugin(**plugin_data)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def plugin(self, name):"},{"line_number":511,"context_line":"        return self.plugins[name]"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def get_jobs(self):"},{"line_number":514,"context_line":"        \"\"\"Get list of jobs running."}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_bc13fe5a","line":511,"updated":"2015-03-24 15:40:05.000000000","message":"I\u0027m thinking that this helper might be just a little too obvious; it might be better to drop it altogether.  After all, \"There should be one-- and preferably only one --obvious way to do it.\"","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"28aaac9e86bdb6b5920ed4e58f207b18f1f1bea8","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                str(plugin_data[\u0027longName\u0027])] \u003d plugins.Plugin(**plugin_data)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def plugin(self, name):"},{"line_number":511,"context_line":"        return self.plugins[name]"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def get_jobs(self):"},{"line_number":514,"context_line":"        \"\"\"Get list of jobs running."}],"source_content_type":"text/x-python","patch_set":5,"id":"da9b358b_9bc48c5f","line":511,"in_reply_to":"1a6ced46_bc13fe5a","updated":"2015-04-01 09:28:47.000000000","message":"Done","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"2b8d9a69fc211d7af2e9951e8f35a13464f4fdb8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            self.auth \u003d None"},{"line_number":183,"context_line":"        self.crumb \u003d None"},{"line_number":184,"context_line":"        self.timeout \u003d timeout"},{"line_number":185,"context_line":"        self._plugins \u003d None"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def _get_encoded_params(self, params):"},{"line_number":188,"context_line":"        for k, v in params.items():"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_b6f663f7","line":185,"updated":"2015-04-03 17:35:06.000000000","message":"Maybe it\u0027s just me but I think this variable is misleading.  It\u0027s a cache for the list of plugins with only name and version info.  I thought it might be a list containing all of the plugin info.  I\u0027m not sure how to make it more clear, maybe just some comments or maybe a variable name change?  Or maybe it\u0027s just me and leave it as-is?","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"f3df3da73118e6be4f07c016efc29e7908694fb2","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            self.auth \u003d None"},{"line_number":183,"context_line":"        self.crumb \u003d None"},{"line_number":184,"context_line":"        self.timeout \u003d timeout"},{"line_number":185,"context_line":"        self._plugins \u003d None"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def _get_encoded_params(self, params):"},{"line_number":188,"context_line":"        for k, v in params.items():"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aa745d1_69adf087","line":185,"in_reply_to":"9aa53dc9_f0b660db","updated":"2015-04-16 00:16:58.000000000","message":"Sorry about that.  The use of multi_key_dict tripped me up.","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"fede74f065c54636bb17cd00a3addf01b81f88be","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            self.auth \u003d None"},{"line_number":183,"context_line":"        self.crumb \u003d None"},{"line_number":184,"context_line":"        self.timeout \u003d timeout"},{"line_number":185,"context_line":"        self._plugins \u003d None"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def _get_encoded_params(self, params):"},{"line_number":188,"context_line":"        for k, v in params.items():"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_f0b660db","line":185,"in_reply_to":"baa041b7_b6f663f7","updated":"2015-04-07 14:05:58.000000000","message":"It should contain everything returned by get_plugins_info, with the minor modification of changing the version to using the helper class instead.\n\nDid you experience something different?","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"c8f71d4afdd1c963400e21086d5faa6706bd0ea5","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        for plugin_data in self.get_plugins_info():"},{"line_number":488,"context_line":"            self._plugins["},{"line_number":489,"context_line":"                str(plugin_data[\u0027shortName\u0027]),"},{"line_number":490,"context_line":"                str(plugin_data[\u0027longName\u0027])] \u003d plugins.Plugin(**plugin_data)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    @property"},{"line_number":493,"context_line":"    def plugins(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_76e70d41","line":490,"updated":"2015-04-01 18:30:18.000000000","message":"Suggestion to make this a hair more readable:\n\n    key \u003d (str(plugin_data[\u0027shortName\u0027]), str(plugin_data[\u0027longName\u0027]))\n    self._plugins[key] \u003d plugins.Plugin(**plugin_data)","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"2b8d9a69fc211d7af2e9951e8f35a13464f4fdb8","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        for plugin_data in self.get_plugins_info():"},{"line_number":488,"context_line":"            self._plugins["},{"line_number":489,"context_line":"                str(plugin_data[\u0027shortName\u0027]),"},{"line_number":490,"context_line":"                str(plugin_data[\u0027longName\u0027])] \u003d plugins.Plugin(**plugin_data)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    @property"},{"line_number":493,"context_line":"    def plugins(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_bb3e4ed8","line":490,"in_reply_to":"baa041b7_76e70d41","updated":"2015-04-03 17:35:06.000000000","message":"+1","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"fede74f065c54636bb17cd00a3addf01b81f88be","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        for plugin_data in self.get_plugins_info():"},{"line_number":488,"context_line":"            self._plugins["},{"line_number":489,"context_line":"                str(plugin_data[\u0027shortName\u0027]),"},{"line_number":490,"context_line":"                str(plugin_data[\u0027longName\u0027])] \u003d plugins.Plugin(**plugin_data)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    @property"},{"line_number":493,"context_line":"    def plugins(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_30c5e83b","line":490,"in_reply_to":"baa041b7_76e70d41","updated":"2015-04-07 14:05:58.000000000","message":"Done","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"47bc5580a7bab4fcc4327d6d9feb3a214a679ebd","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        self._plugins \u003d multi_key_dict.multi_key_dict()"},{"line_number":487,"context_line":"        for plugin_data in self.get_plugins_info():"},{"line_number":488,"context_line":"            keys \u003d (str(plugin_data[\u0027shortName\u0027]), str(plugin_data[\u0027longName\u0027]))"},{"line_number":489,"context_line":"            self._plugins[keys] \u003d plugins.Plugin(**plugin_data)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @property"},{"line_number":492,"context_line":"    def plugins(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_b9e2fcd3","line":489,"updated":"2015-04-07 15:36:02.000000000","message":"Why did you name the variable \"keys\"?  You\u0027re associating the plugins.Plugin instance with the (single) key composed of a tuple of the short name and the long name of the plugin; that\u0027s only a single key, right?\n\nOh, I just looked up the documentation for the multi_key_dict class, and now I understand.  I\u0027m not sure I understand why this needs to use that class, though; couldn\u0027t you achieve the same effect with this construction:\n\n    self._plugins \u003d {}\n    for plugin_data in self.get_plugins_info():\n        plugin \u003d plugins.Plugin(**plugin_data)\n        self._plugins[plugin_data[\u0027shortName\u0027]] \u003d plugin\n        self._plugins[plugin_data[\u0027longName\u0027]] \u003d plugin","commit_id":"e6d73265f65f84bf48de8c8ff552f724669d6d86"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"cf1c51d91d4e914352e8b6332abf61401dd3cdd6","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        self._plugins \u003d multi_key_dict.multi_key_dict()"},{"line_number":487,"context_line":"        for plugin_data in self.get_plugins_info():"},{"line_number":488,"context_line":"            keys \u003d (str(plugin_data[\u0027shortName\u0027]), str(plugin_data[\u0027longName\u0027]))"},{"line_number":489,"context_line":"            self._plugins[keys] \u003d plugins.Plugin(**plugin_data)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @property"},{"line_number":492,"context_line":"    def plugins(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_91c33bed","line":489,"in_reply_to":"5aa745d1_c902c46f","updated":"2015-05-19 15:06:08.000000000","message":"Also multi_key_dict is doing more than just having two keys point to the same data, it also ensures that if you update the data under one of the keys, all the other keys now also reference the new data.\n\nSo:\n\n keys \u003d (str(plugin_data[\u0027shortName\u0027]), str(plugin_data[\u0027longName\u0027])\n self._plugins[keys] \u003d plugins.Plugin(**plugin_data)\n\n new_plugin_data \u003d dict(plugin_data)\n new_plugin_data[\u0027version\u0027] \u003d \"UNKNOWN\"\n self._plugins[plugin_data[\u0027shortName\u0027]] \u003d new_plugin_data\n\n assert self._plugins[plugin_data[\u0027shortName\u0027]] \u003d\u003d self._plugins[plugin_data[\u0027longName\u0027]]\n\nwould pass with multi_key_dict, but not with the suggested alternative.","commit_id":"e6d73265f65f84bf48de8c8ff552f724669d6d86"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"852cce14f4506a23541b7fd895410bb84bf849fa","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        self._plugins \u003d multi_key_dict.multi_key_dict()"},{"line_number":487,"context_line":"        for plugin_data in self.get_plugins_info():"},{"line_number":488,"context_line":"            keys \u003d (str(plugin_data[\u0027shortName\u0027]), str(plugin_data[\u0027longName\u0027]))"},{"line_number":489,"context_line":"            self._plugins[keys] \u003d plugins.Plugin(**plugin_data)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @property"},{"line_number":492,"context_line":"    def plugins(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aa745d1_c902c46f","line":489,"in_reply_to":"9aa53dc9_b9e2fcd3","updated":"2015-04-16 00:20:14.000000000","message":"Use of a reliable package seems like a smart choice to me.","commit_id":"e6d73265f65f84bf48de8c8ff552f724669d6d86"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"32fd7e3e59b6216e76450e2eae95930c8c1e46cb","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise JenkinsException(\"Could not parse JSON info for server[%s]\""},{"line_number":502,"context_line":"                                   % self.server)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def get_plugins(self):"},{"line_number":505,"context_line":"        \"\"\"Return plugins info using helper class for version comparison"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        This method retrieves information about all the installed plugins and"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_4681bf49","line":504,"updated":"2015-06-29 19:58:16.000000000","message":"if we already have a get_plugins_info and get_plugin_info methods then I assume users would only ever use this as a helper for comparing plugin versions?  would it make sense to change this method name to _get_plugins?","commit_id":"4e269bafb35ac5dde1d4ab51a531d7144dd2e625"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"f7304aeb6c19e88e43944015183800b8843c3206","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise JenkinsException(\"Could not parse JSON info for server[%s]\""},{"line_number":502,"context_line":"                                   % self.server)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def get_plugins(self):"},{"line_number":505,"context_line":"        \"\"\"Return plugins info using helper class for version comparison"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        This method retrieves information about all the installed plugins and"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_ea7a1425","line":504,"in_reply_to":"3a50d1a3_9575c1fb","updated":"2015-07-30 16:44:06.000000000","message":"Here\u0027s an alternative.  How about we make get_plugins() the best of all three and just call it in get_plugins_info() and get_plugin_info()?  When it\u0027s called in get_plugins_info() just convert the dict to raw json?\n\nMy rational: \n\n  1. safe for backwards compatibility\n  2. get_plugins_info() and get_plugin_info() can just reuse get_plugins() which matches your thinking to allow the user to decide what to do with the data.\n  3. lets us decide whether we want to deprecate get_plugins_info() and get_plugin_info() at a later time?","commit_id":"4e269bafb35ac5dde1d4ab51a531d7144dd2e625"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"2ea77b0a93dce5d20d3ca74c99e2738f9e66274d","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise JenkinsException(\"Could not parse JSON info for server[%s]\""},{"line_number":502,"context_line":"                                   % self.server)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def get_plugins(self):"},{"line_number":505,"context_line":"        \"\"\"Return plugins info using helper class for version comparison"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        This method retrieves information about all the installed plugins and"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_ddae002f","line":504,"in_reply_to":"3a50d1a3_ea7a1425","updated":"2015-07-30 18:02:22.000000000","message":"I just realised, we don\u0027t pass back raw json, we pass back the dict taken from json.loads(response).\n\nGuess that means we should use an argument to get_plugins for to get the raw unprocessed dict back.","commit_id":"4e269bafb35ac5dde1d4ab51a531d7144dd2e625"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"7305a9e05865defabc6eb6cd31eb9ada87385de9","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise JenkinsException(\"Could not parse JSON info for server[%s]\""},{"line_number":502,"context_line":"                                   % self.server)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def get_plugins(self):"},{"line_number":505,"context_line":"        \"\"\"Return plugins info using helper class for version comparison"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        This method retrieves information about all the installed plugins and"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_9575c1fb","line":504,"in_reply_to":"9a41bdd9_58a40fa5","updated":"2015-07-30 11:16:43.000000000","message":"So before I rebase this to fix the merge comflict, would be good to have a clear idea of what direction we want to go.\n\n* Merge this with the get_plugins_info() method and simply always alter what is returned to use the Plugin class\n* Merge this with get_plugins_info() and add a raw option to the method for those that want to get the pure json response to both get_plugin_info() and get_plugins_info() methods\n* Keep both sets of methods separate as currently in place.\n\nI\u0027m actually tempted to go with option 1? But I have some concerns about altering the response given from the API, even if in 99.99% of cases the receiving application won\u0027t notice. Is this sufficiently transparent that we can slip it in? or is it still breaking the API?","commit_id":"4e269bafb35ac5dde1d4ab51a531d7144dd2e625"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"092be2484de8d330a2910582013fad8bfa7c24a8","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise JenkinsException(\"Could not parse JSON info for server[%s]\""},{"line_number":502,"context_line":"                                   % self.server)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def get_plugins(self):"},{"line_number":505,"context_line":"        \"\"\"Return plugins info using helper class for version comparison"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        This method retrieves information about all the installed plugins and"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a41bdd9_58a40fa5","line":504,"in_reply_to":"ba3cc151_46145ff4","updated":"2015-07-13 18:25:41.000000000","message":"That was my thinking as well, leave get_plugins_info() as the raw access to plugin json. This method would always be processed information.\n\nSince this restricts the depth of information query for plugins, it seems sensible to at least retain one method that can be alter to query for more/less info.\n\nOr should this method get a depth arg as well?","commit_id":"4e269bafb35ac5dde1d4ab51a531d7144dd2e625"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"77a27d532aa3c519e042f575ca4702599f7d4faf","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise JenkinsException(\"Could not parse JSON info for server[%s]\""},{"line_number":502,"context_line":"                                   % self.server)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    def get_plugins(self):"},{"line_number":505,"context_line":"        \"\"\"Return plugins info using helper class for version comparison"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        This method retrieves information about all the installed plugins and"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_46145ff4","line":504,"in_reply_to":"ba3cc151_4681bf49","updated":"2015-06-29 20:03:05.000000000","message":"I\u0027d actually think maybe we want to go the other way: mark the get_plugins_info() and get_plugin_info() methods as deprecated, with this method being the replacement.  After all, this change no longer calls get_plugins() anywhere, so marking it internal with a leading \u0027_\u0027 doesn\u0027t really make sense…","commit_id":"4e269bafb35ac5dde1d4ab51a531d7144dd2e625"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"f7304aeb6c19e88e43944015183800b8843c3206","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        This method retrieves information about all the installed plugins and"},{"line_number":508,"context_line":"        uses a Plugin helper class to simplify version comparison. Also uses"},{"line_number":509,"context_line":"        a multi key dict to allow retrieval via either short or long names."},{"line_number":510,"context_line":"        \"\"\""},{"line_number":511,"context_line":"        plugins_info \u003d multi_key_dict.multi_key_dict()"},{"line_number":512,"context_line":"        for plugin_data in self.get_plugins_info():"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_4aea28ae","line":509,"updated":"2015-07-30 16:44:06.000000000","message":"add the input and return params? and would be good to add an example.","commit_id":"4e269bafb35ac5dde1d4ab51a531d7144dd2e625"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"6144106d0df4dcac6a96dd12249fc373517265cf","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        on master returning the raw plugin data in a JSON format."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        .. deprecated:: 0.4.9"},{"line_number":491,"context_line":"           Use :func:`get_plugins` instead."},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        :param depth: JSON depth, ``int``"},{"line_number":494,"context_line":"        :returns: info on all plugins ``[dict]``"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_27899d6f","line":491,"updated":"2015-09-11 20:35:48.000000000","message":"Do you think there should there be a warning log for this?  \n\nAlso i\u0027m a little concerned about this since get_plugins_info returns a list while get_plugins returns a dict.  Users would need to know that so they can get the same result to be compatible with their existing scripts. Maybe just a little more documentation and update to the example in examples.rst might do it?","commit_id":"3647ce668d21cd1cdb9f36401ce54ea6b2d17c18"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"6144106d0df4dcac6a96dd12249fc373517265cf","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            \u003e\u003e\u003e j \u003d Jenkins()"},{"line_number":560,"context_line":"            \u003e\u003e\u003e info \u003d j.get_plugins()"},{"line_number":561,"context_line":"            \u003e\u003e\u003e print(info)"},{"line_number":562,"context_line":"            [{u\u0027backupVersion\u0027: None, u\u0027version\u0027: u\u00270.0.4\u0027, u\u0027deleted\u0027: False,"},{"line_number":563,"context_line":"            u\u0027supportsDynamicLoad\u0027: u\u0027MAYBE\u0027, u\u0027hasUpdate\u0027: True,"},{"line_number":564,"context_line":"            u\u0027enabled\u0027: True, u\u0027pinned\u0027: False, u\u0027downgradable\u0027: False,"},{"line_number":565,"context_line":"            u\u0027dependencies\u0027: [], u\u0027url\u0027:"}],"source_content_type":"text/x-python","patch_set":11,"id":"da20952f_07733917","line":562,"updated":"2015-09-11 20:35:48.000000000","message":"maybe a more representative example showing the multi key dict return value?\n\nsomething like ..\n\n\n{(\u0027gearman-plugin\u0027, \u0027Gearman Plugin\u0027): {u\u0027backupVersion\u0027: u\u0027${project-version}\u0027, \u0027version\u0027: ${project-version}, u\u0027deleted\u0027: False, u\u0027supportsDynamicLoad\u0027: u\u0027MAYBE\u0027, u\u0027hasUpdate\u0027: True, u\u0027enabled\u0027: True, u\u0027pinned\u0027: False, u\u0027url\u0027: u\u0027http://wiki.jenkins-ci.org/display/JENKINS/Gearman+Plugin\u0027, u\u0027dependencies\u0027: [], u\u0027longName\u0027: u\u0027Gearman Plugin\u0027, u\u0027downgradable\u0027: True, u\u0027shortName\u0027: u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False, u\u0027active\u0027: True}, (\u0027matrix-project\u0027, \u0027Matrix Project Plugin\u0027): {u\u0027backupVersion\u0027: u\u00271.2\u0027, \u0027version\u0027: 1.4, u\u0027deleted\u0027: False, u\u0027supportsDynamicLoad\u0027: u\u0027MAYBE\u0027, u\u0027hasUpdate\u0027: False, u\u0027enabled\u0027: True, u\u0027pinned\u0027: True, u\u0027url\u0027: u\u0027https://wiki.jenkins-ci.org/display/JENKINS/Matrix+Project+Plugin\u0027, u\u0027dependencies\u0027: [], u\u0027longName\u0027: u\u0027Matrix Project Plugin\u0027, u\u0027downgradable\u0027: True, u\u0027shortName\u0027: u\u0027matrix-project\u0027, u\u0027bundled\u0027: True, u\u0027active\u0027: True}, ..}","commit_id":"3647ce668d21cd1cdb9f36401ce54ea6b2d17c18"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"8bae1d3a6a9954937ae2012c12a3ad002129e55b","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        The passed in plugin name (short or long) must be an exact match."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        .. deprecated:: 0.4.9"},{"line_number":523,"context_line":"           Use :func:`get_plugins` instead."},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        :param name: Name (short or long) of plugin, ``str``"},{"line_number":526,"context_line":"        :param depth: JSON depth, ``int``"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_48a49649","line":523,"updated":"2015-09-18 17:00:52.000000000","message":"hmm.  get_plugins method does not take a name so should this be deprecated yet?","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"5def7710a950d443af0be577abaab9d50aee59d9","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        The passed in plugin name (short or long) must be an exact match."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        .. deprecated:: 0.4.9"},{"line_number":523,"context_line":"           Use :func:`get_plugins` instead."},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        :param name: Name (short or long) of plugin, ``str``"},{"line_number":526,"context_line":"        :param depth: JSON depth, ``int``"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_6787ccd7","line":523,"in_reply_to":"9a1a9d01_079850bf","updated":"2015-09-28 17:03:52.000000000","message":"on second thought, i think deprecating this method would be more beneficial than keeping it around.","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"87862d2dc99ee82cee2708ac6aa559b264b4fe58","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        The passed in plugin name (short or long) must be an exact match."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        .. deprecated:: 0.4.9"},{"line_number":523,"context_line":"           Use :func:`get_plugins` instead."},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        :param name: Name (short or long) of plugin, ``str``"},{"line_number":526,"context_line":"        :param depth: JSON depth, ``int``"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_b6baf321","line":523,"in_reply_to":"9a1a9d01_6787ccd7","updated":"2015-09-28 17:32:20.000000000","message":"I\u0027ll add a subsequent change to provide a \u0027get_plugin(self, name, depth\u003d2)\u0027 method to allow deprecation of this one and also add the info there.","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"997139f6666829169d8424330dca8c8af0cab356","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        The passed in plugin name (short or long) must be an exact match."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        .. deprecated:: 0.4.9"},{"line_number":523,"context_line":"           Use :func:`get_plugins` instead."},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        :param name: Name (short or long) of plugin, ``str``"},{"line_number":526,"context_line":"        :param depth: JSON depth, ``int``"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_079850bf","line":523,"in_reply_to":"ba15a1d1_48a49649","updated":"2015-09-28 16:50:43.000000000","message":"Depends on whether we think users should call get_plugins and decide themselves on whether to cache the information or not?\n\nThis call is inherently expensive since it retrieves all information for all plugins and only returns the one needed, but will re-request the next time.\n\nAt the very least I might warn that this is expensive to call repeatedly.","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"8bae1d3a6a9954937ae2012c12a3ad002129e55b","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            \u003e\u003e\u003e j \u003d Jenkins()"},{"line_number":566,"context_line":"            \u003e\u003e\u003e info \u003d j.get_plugins()"},{"line_number":567,"context_line":"            \u003e\u003e\u003e print(info)"},{"line_number":568,"context_line":"            [((\u0027gearman-plugin\u0027, \u0027Gearman Plugin\u0027),"},{"line_number":569,"context_line":"              {u\u0027backupVersion\u0027: None, u\u0027version\u0027: u\u00270.0.4\u0027,"},{"line_number":570,"context_line":"               u\u0027deleted\u0027: False, u\u0027supportsDynamicLoad\u0027: u\u0027MAYBE\u0027,"},{"line_number":571,"context_line":"               u\u0027hasUpdate\u0027: True, u\u0027enabled\u0027: True, u\u0027pinned\u0027: False,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_0818ded1","line":568,"updated":"2015-09-18 17:00:52.000000000","message":"dict not an array correct?  so it should be  {(\u0027gearman-plugin\u0027, \u0027Gearman Plugin\u0027) ...","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"a981cc2efe33913c73538c9b6c409855a2b0c0d4","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            \u003e\u003e\u003e j \u003d Jenkins()"},{"line_number":566,"context_line":"            \u003e\u003e\u003e info \u003d j.get_plugins()"},{"line_number":567,"context_line":"            \u003e\u003e\u003e print(info)"},{"line_number":568,"context_line":"            [((\u0027gearman-plugin\u0027, \u0027Gearman Plugin\u0027),"},{"line_number":569,"context_line":"              {u\u0027backupVersion\u0027: None, u\u0027version\u0027: u\u00270.0.4\u0027,"},{"line_number":570,"context_line":"               u\u0027deleted\u0027: False, u\u0027supportsDynamicLoad\u0027: u\u0027MAYBE\u0027,"},{"line_number":571,"context_line":"               u\u0027hasUpdate\u0027: True, u\u0027enabled\u0027: True, u\u0027pinned\u0027: False,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_02d03e1e","line":568,"in_reply_to":"9a1a9d01_27c1d480","updated":"2015-09-28 17:17:26.000000000","message":"And I checked again and it turns out it wasn\u0027t. Not sure how I ended up with this format. Was sure I\u0027d just copied it...\n\nFixed up with the latest patch.","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"5def7710a950d443af0be577abaab9d50aee59d9","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            \u003e\u003e\u003e j \u003d Jenkins()"},{"line_number":566,"context_line":"            \u003e\u003e\u003e info \u003d j.get_plugins()"},{"line_number":567,"context_line":"            \u003e\u003e\u003e print(info)"},{"line_number":568,"context_line":"            [((\u0027gearman-plugin\u0027, \u0027Gearman Plugin\u0027),"},{"line_number":569,"context_line":"              {u\u0027backupVersion\u0027: None, u\u0027version\u0027: u\u00270.0.4\u0027,"},{"line_number":570,"context_line":"               u\u0027deleted\u0027: False, u\u0027supportsDynamicLoad\u0027: u\u0027MAYBE\u0027,"},{"line_number":571,"context_line":"               u\u0027hasUpdate\u0027: True, u\u0027enabled\u0027: True, u\u0027pinned\u0027: False,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_67d58cb7","line":568,"in_reply_to":"9a1a9d01_27c1d480","updated":"2015-09-28 17:03:52.000000000","message":"ohh thats weird, it not a list for me.","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"997139f6666829169d8424330dca8c8af0cab356","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            \u003e\u003e\u003e j \u003d Jenkins()"},{"line_number":566,"context_line":"            \u003e\u003e\u003e info \u003d j.get_plugins()"},{"line_number":567,"context_line":"            \u003e\u003e\u003e print(info)"},{"line_number":568,"context_line":"            [((\u0027gearman-plugin\u0027, \u0027Gearman Plugin\u0027),"},{"line_number":569,"context_line":"              {u\u0027backupVersion\u0027: None, u\u0027version\u0027: u\u00270.0.4\u0027,"},{"line_number":570,"context_line":"               u\u0027deleted\u0027: False, u\u0027supportsDynamicLoad\u0027: u\u0027MAYBE\u0027,"},{"line_number":571,"context_line":"               u\u0027hasUpdate\u0027: True, u\u0027enabled\u0027: True, u\u0027pinned\u0027: False,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_27c1d480","line":568,"in_reply_to":"ba15a1d1_0818ded1","updated":"2015-09-28 16:50:43.000000000","message":"This is a copy n paste from the actual output, so it\u0027s due to how multi_key_dict represents it\u0027s output.","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"8bae1d3a6a9954937ae2012c12a3ad002129e55b","unresolved":false,"context_lines":[{"line_number":572,"context_line":"               u\u0027downgradable\u0027: False, u\u0027dependencies\u0027: [], u\u0027url\u0027:"},{"line_number":573,"context_line":"               u\u0027http://wiki.jenkins-ci.org/display/JENKINS/Gearman+Plugin\u0027,"},{"line_number":574,"context_line":"               u\u0027longName\u0027: u\u0027Gearman Plugin\u0027, u\u0027active\u0027: True, u\u0027shortName\u0027:"},{"line_number":575,"context_line":"               u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False})"},{"line_number":576,"context_line":"             ..]"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_c85bc684","line":575,"updated":"2015-09-18 17:00:52.000000000","message":"Should probably end like this:\n\n...  u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False} ..}","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"997139f6666829169d8424330dca8c8af0cab356","unresolved":false,"context_lines":[{"line_number":572,"context_line":"               u\u0027downgradable\u0027: False, u\u0027dependencies\u0027: [], u\u0027url\u0027:"},{"line_number":573,"context_line":"               u\u0027http://wiki.jenkins-ci.org/display/JENKINS/Gearman+Plugin\u0027,"},{"line_number":574,"context_line":"               u\u0027longName\u0027: u\u0027Gearman Plugin\u0027, u\u0027active\u0027: True, u\u0027shortName\u0027:"},{"line_number":575,"context_line":"               u\u0027gearman-plugin\u0027, u\u0027bundled\u0027: False})"},{"line_number":576,"context_line":"             ..]"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a1a9d01_8738e0a1","line":575,"in_reply_to":"ba15a1d1_c85bc684","updated":"2015-09-28 16:50:43.000000000","message":"will do.","commit_id":"be600fcb2e446c8d4b8829a13da63c4cb07a61bd"}],"jenkins/plugins.py":[{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"281ba81b5cca3c9ae4e72247c6795d69fb69ec5f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return self._VERSION_RE.sub(r\u0027\\g\u003c1\u003e.preview\u0027, version)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __compare(self, operator, version):"},{"line_number":78,"context_line":"        return operator(self.parsed_version, pkg_resources.parse_version("},{"line_number":79,"context_line":"            self.__convert_version(version)))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def __le__(self, version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_f991239b","line":78,"updated":"2015-02-22 21:04:38.000000000","message":"Be unusual, but shouldn\u0027t be too difficult to support.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":13487,"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"change_message_id":"fde253c8521164b560b38c8ccefb76d218ab3b82","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return self._VERSION_RE.sub(r\u0027\\g\u003c1\u003e.preview\u0027, version)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __compare(self, operator, version):"},{"line_number":78,"context_line":"        return operator(self.parsed_version, pkg_resources.parse_version("},{"line_number":79,"context_line":"            self.__convert_version(version)))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def __le__(self, version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_821a7515","line":78,"updated":"2015-02-22 08:50:12.000000000","message":"Do you think it would ever be possible that someone might try\n\na \u003d PluginVersion(\"0.1.2\")\n...\nb \u003d PluginVersion(\"0.1.2\")\n\nif a \u003e b:\n  do_something_clever()\nelse:\n  do_something_boring()\n\nAnd does this class support that possibility? I think this call to resources.parse_version() may fail since pkg_resouces.parse_version seems to expect a string value (or at least something string-like)","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":13487,"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"change_message_id":"ce1d94108b2a3d8c93c5a8661f3b1ae5ec8f3d48","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return self._VERSION_RE.sub(r\u0027\\g\u003c1\u003e.preview\u0027, version)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __compare(self, operator, version):"},{"line_number":78,"context_line":"        return operator(self.parsed_version, pkg_resources.parse_version("},{"line_number":79,"context_line":"            self.__convert_version(version)))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def __le__(self, version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_f92123fd","line":78,"in_reply_to":"ba7be1f8_f991239b","updated":"2015-02-23 00:24:46.000000000","message":"I just thought of a use case...someone might try to automatically compare plugin versions between two different Jenki. If there\u0027s not already a way to do that. \n\nIn fact, I might use it for this in the near future.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3649524002b8925ba3b37174f74253a100a6573","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027\u0027\u0027"},{"line_number":65,"context_line":"        if key \u003d\u003d \u0027version\u0027:"},{"line_number":66,"context_line":"            value \u003d PluginVersion(value)"},{"line_number":67,"context_line":"        dict.__setitem__(self, key, value)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class PluginVersion(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_e63a4933","line":67,"updated":"2015-03-24 15:40:05.000000000","message":"I\u0027d suggest \"super(self, Plugin).__setitem__(self, key, value)\"","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"28aaac9e86bdb6b5920ed4e58f207b18f1f1bea8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027\u0027\u0027"},{"line_number":65,"context_line":"        if key \u003d\u003d \u0027version\u0027:"},{"line_number":66,"context_line":"            value \u003d PluginVersion(value)"},{"line_number":67,"context_line":"        dict.__setitem__(self, key, value)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class PluginVersion(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9b358b_bbc9907a","line":67,"in_reply_to":"1a6ced46_e63a4933","updated":"2015-04-01 09:28:47.000000000","message":"Done","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3649524002b8925ba3b37174f74253a100a6573","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return self._VERSION_RE.sub(r\u0027\\g\u003c1\u003e.preview\u0027, str(version))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def __compare(self, operator, version):"},{"line_number":86,"context_line":"        return operator(self.parsed_version, pkg_resources.parse_version("},{"line_number":87,"context_line":"            self.__convert_version(version)))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __le__(self, version):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_dc3c3ac2","line":86,"updated":"2015-03-24 15:40:05.000000000","message":"I\u0027d change the parameter names here to avoid symbol collision, i.e., s/operator/op/.  I thought at first you were calling the module :)","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"28aaac9e86bdb6b5920ed4e58f207b18f1f1bea8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return self._VERSION_RE.sub(r\u0027\\g\u003c1\u003e.preview\u0027, str(version))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def __compare(self, operator, version):"},{"line_number":86,"context_line":"        return operator(self.parsed_version, pkg_resources.parse_version("},{"line_number":87,"context_line":"            self.__convert_version(version)))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __le__(self, version):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9b358b_3bb580ed","line":86,"in_reply_to":"1a6ced46_dc3c3ac2","updated":"2015-04-01 09:28:47.000000000","message":"Oops! yes, that is bad!","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3649524002b8925ba3b37174f74253a100a6573","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            self.__convert_version(version)))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __le__(self, version):"},{"line_number":90,"context_line":"        return self.__compare(operator.__le__, version)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def __lt__(self, version):"},{"line_number":93,"context_line":"        return self.__compare(operator.__lt__, version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_1cb5f230","line":90,"updated":"2015-03-24 15:40:05.000000000","message":"Any particular reason you\u0027re using the __xx__ versions of these functions?  You could just use \"operator.le\"…","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"28aaac9e86bdb6b5920ed4e58f207b18f1f1bea8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            self.__convert_version(version)))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __le__(self, version):"},{"line_number":90,"context_line":"        return self.__compare(operator.__le__, version)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def __lt__(self, version):"},{"line_number":93,"context_line":"        return self.__compare(operator.__lt__, version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9b358b_dbca146e","line":90,"in_reply_to":"1a6ced46_1cb5f230","updated":"2015-04-01 09:28:47.000000000","message":"None what so ever, probably just copying the name of the calling method.","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"}],"tests/test_jenkins.py":[{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"281ba81b5cca3c9ae4e72247c6795d69fb69ec5f","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        self.assertEqual(plugin_info, self.plugin_info_json[\u0027plugins\u0027][0])"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    @patch.object(jenkins.Jenkins, \u0027jenkins_open\u0027)"},{"line_number":803,"context_line":"    def test_plugin_version_comparison(self, jenkins_mock):"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        jenkins_mock.return_value \u003d json.dumps(self.plugin_info_json)"},{"line_number":806,"context_line":"        j \u003d jenkins.Jenkins(\u0027http://example.com/\u0027, \u0027test\u0027, \u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_398c9b7f","line":803,"updated":"2015-02-22 21:04:38.000000000","message":"Agreed, this should test the full spectrum I\u0027ll migrate the full range of tests, and probably move these to a separate file to allow for senarios similar to how it\u0027s done in JJB.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"dee12f08d66389170def12759e7ad4aa430684bf","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        self.assertEqual(plugin_info, self.plugin_info_json[\u0027plugins\u0027][0])"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    @patch.object(jenkins.Jenkins, \u0027jenkins_open\u0027)"},{"line_number":803,"context_line":"    def test_plugin_version_comparison(self, jenkins_mock):"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        jenkins_mock.return_value \u003d json.dumps(self.plugin_info_json)"},{"line_number":806,"context_line":"        j \u003d jenkins.Jenkins(\u0027http://example.com/\u0027, \u0027test\u0027, \u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e181854b","line":803,"updated":"2015-02-20 20:20:07.000000000","message":"This seems like its missing some tests from the JJB implementation.  Do  you intend to just have just a few tests here and cover the rest in JJB?  At minimum maybe test an \u0027less than or equal\u0027 and \u0027greater than or equal\u0027 as well?","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":13487,"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"change_message_id":"fde253c8521164b560b38c8ccefb76d218ab3b82","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        self.assertEqual(plugin_info, self.plugin_info_json[\u0027plugins\u0027][0])"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    @patch.object(jenkins.Jenkins, \u0027jenkins_open\u0027)"},{"line_number":803,"context_line":"    def test_plugin_version_comparison(self, jenkins_mock):"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        jenkins_mock.return_value \u003d json.dumps(self.plugin_info_json)"},{"line_number":806,"context_line":"        j \u003d jenkins.Jenkins(\u0027http://example.com/\u0027, \u0027test\u0027, \u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_22baa9de","line":803,"in_reply_to":"ba7be1f8_e181854b","updated":"2015-02-22 08:50:12.000000000","message":"Ah this hadn\u0027t occurred to me, but it does make sense that all the existing version string comparisons be moved into this library.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"281ba81b5cca3c9ae4e72247c6795d69fb69ec5f","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        # expected to return info on a single plugin"},{"line_number":809,"context_line":"        plugin_info \u003d j.get_plugin_info(\"Jenkins Mailer Plugin\")"},{"line_number":810,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003c \"1.6\")"},{"line_number":811,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003d\u003d \"1.5.0\")"},{"line_number":812,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003e \"1.5-SNAPSHOT\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    @patch.object(jenkins.Jenkins, \u0027jenkins_open\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_59ea2f10","line":811,"updated":"2015-02-22 21:04:38.000000000","message":"Seems to be in keeping with both how maven and pkg_resources compare versions. Additional \u0027.0\u0027 are treated as being optional and insignificant unless followed by another significant number.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"dee12f08d66389170def12759e7ad4aa430684bf","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        # expected to return info on a single plugin"},{"line_number":809,"context_line":"        plugin_info \u003d j.get_plugin_info(\"Jenkins Mailer Plugin\")"},{"line_number":810,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003c \"1.6\")"},{"line_number":811,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003d\u003d \"1.5.0\")"},{"line_number":812,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003e \"1.5-SNAPSHOT\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    @patch.object(jenkins.Jenkins, \u0027jenkins_open\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_6ec5845a","line":811,"updated":"2015-02-20 20:20:07.000000000","message":"this should fail?  the plugin_info_json is defined with version of \u00271.5\u0027","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"4f0fe46b7beb6fef8e70fef92bd22d1fb246821b","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        # expected to return info on a single plugin"},{"line_number":809,"context_line":"        plugin_info \u003d j.get_plugin_info(\"Jenkins Mailer Plugin\")"},{"line_number":810,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003c \"1.6\")"},{"line_number":811,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003d\u003d \"1.5.0\")"},{"line_number":812,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003e \"1.5-SNAPSHOT\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    @patch.object(jenkins.Jenkins, \u0027jenkins_open\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_7678db2b","line":811,"in_reply_to":"ba7be1f8_59ea2f10","updated":"2015-04-03 17:27:42.000000000","message":"i didn\u0027t realize that but cool!","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"},{"author":{"_account_id":13487,"name":"Wayne Warren","email":"wayne.warren.s@gmail.com","username":"waynr"},"change_message_id":"fde253c8521164b560b38c8ccefb76d218ab3b82","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        # expected to return info on a single plugin"},{"line_number":809,"context_line":"        plugin_info \u003d j.get_plugin_info(\"Jenkins Mailer Plugin\")"},{"line_number":810,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003c \"1.6\")"},{"line_number":811,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003d\u003d \"1.5.0\")"},{"line_number":812,"context_line":"        self.assertTrue(plugin_info[\u0027version\u0027] \u003e \"1.5-SNAPSHOT\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    @patch.object(jenkins.Jenkins, \u0027jenkins_open\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_82f195cf","line":811,"in_reply_to":"ba7be1f8_6ec5845a","updated":"2015-02-22 08:50:12.000000000","message":"I think this should pass, going by the behavior of Maven 2.2.0:\n\nhttps://svn.apache.org/viewvc/maven/maven-2/tags/maven-2.2.0/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java?view\u003dmarkup\n\nLook for a function called \"testVersionComparing\"\n\nNot sure exactly which maven versioning scheme we should be attempting to emulate.","commit_id":"eca2bd6d0a2a5e81893e009e35b1262b089070f1"}],"tests/test_plugins.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e3649524002b8925ba3b37174f74253a100a6573","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class PluginsTestScenarios(TestWithScenarios, testtools.TestCase):"},{"line_number":47,"context_line":"    scenarios \u003d ["},{"line_number":48,"context_line":"        (\u0027s1\u0027, dict(v1\u003d\u00271.0.0\u0027, op\u003d\u0027__gt__\u0027, v2\u003d\u00270.8.0\u0027)),"},{"line_number":49,"context_line":"        (\u0027s2\u0027, dict(v1\u003d\u00271.0.1alpha\u0027, op\u003d\u0027__gt__\u0027, v2\u003d\u00271.0.0\u0027)),"},{"line_number":50,"context_line":"        (\u0027s3\u0027, dict(v1\u003d\u00271.0\u0027, op\u003d\u0027__eq__\u0027, v2\u003d\u00271.0.0\u0027)),"},{"line_number":51,"context_line":"        (\u0027s4\u0027, dict(v1\u003d\u00271.0\u0027, op\u003d\u0027__eq__\u0027, v2\u003d\u00271.0\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_664e5998","line":48,"updated":"2015-03-24 15:40:05.000000000","message":"Have you considered using, e.g., operator.gt for the value of \u0027op\u0027?  It would save you the getattr() calls, and you can use the function\u0027s __name__ attribute to format the error message.\n\nAnother point: it is mildly more efficient in Python to use dictionary literals (e.g., {\u0027v1\u0027: \u00271.0.0\u0027, \u0027op\u0027: operator.gt, \u0027v2\u0027: \u00270.8.0\u0027}) than to use the dict() constructor like this.  In essence, using dict() means Python has to build the dictionary twice: once to pass to the dict() function, then again by the operation of dict() itself.\n\nFinally, this class only has tests for the methods returning True, but nothing for returning False; you could incorporate a truth table into your dictionary to allow testing that, e.g. \"{…, \u0027ex\u0027: True}\" (\u0027ex\u0027 for \u0027expected\u0027).","commit_id":"558273cfc0f1b8685af6d10b09b24eac6ec70664"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"2b8d9a69fc211d7af2e9951e8f35a13464f4fdb8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        (\u0027s13\u0027, dict(v1\u003d\u00271.0a-SNAPSHOT\u0027, op\u003d\u0027__lt__\u0027, v2\u003d\u00271.0a\u0027)),"},{"line_number":61,"context_line":"    ]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    plugin_info \u003d {"},{"line_number":64,"context_line":"        u\"plugins\":"},{"line_number":65,"context_line":"        ["},{"line_number":66,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_3b7d9eb1","line":63,"updated":"2015-04-03 17:35:06.000000000","message":"nit: This can probably be made as a global and shared in these two tests classes.","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"},{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"fede74f065c54636bb17cd00a3addf01b81f88be","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        (\u0027s13\u0027, dict(v1\u003d\u00271.0a-SNAPSHOT\u0027, op\u003d\u0027__lt__\u0027, v2\u003d\u00271.0a\u0027)),"},{"line_number":61,"context_line":"    ]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    plugin_info \u003d {"},{"line_number":64,"context_line":"        u\"plugins\":"},{"line_number":65,"context_line":"        ["},{"line_number":66,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_f68f7821","line":63,"in_reply_to":"baa041b7_3b7d9eb1","updated":"2015-04-07 14:05:58.000000000","message":"Done","commit_id":"88c5e47c1d9303642811c3ff556795421f2cf88c"}]}
