)]}'
{"jenkins/__init__.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"58a45ef4b7de07648bae30d16891aa2e3219cb72","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        script \u003d (\u0027Jenkins.instance.updateCenter.getPlugin(\\\"\u0027 + name + \u0027\\\").deploy();\u0027"},{"line_number":736,"context_line":"                  \u0027Jenkins.instance.updateCenter.isRestartRequiredForCompletion()\u0027)"},{"line_number":737,"context_line":"        if include_dependencies:"},{"line_number":738,"context_line":"            script \u003d (\u0027Jenkins.instance.updateCenter.getPlugin(\\\"\u0027 + name + \u0027\\\").getNeededDependencies().each\u0027"},{"line_number":739,"context_line":"                      \u0027{it.deploy()}\u0027 + \u0027;\u0027 + script)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        response \u003d self.run_script(script)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_0daaba70","line":738,"updated":"2015-09-15 22:28:59.000000000","message":"It\u0027d be nice to wrap this at 79 columns…","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"352a366dc45f1390f3821685be8a0658e3e6e23e","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        script \u003d (\u0027Jenkins.instance.updateCenter.getPlugin(\\\"\u0027 + name + \u0027\\\").deploy();\u0027"},{"line_number":736,"context_line":"                  \u0027Jenkins.instance.updateCenter.isRestartRequiredForCompletion()\u0027)"},{"line_number":737,"context_line":"        if include_dependencies:"},{"line_number":738,"context_line":"            script \u003d (\u0027Jenkins.instance.updateCenter.getPlugin(\\\"\u0027 + name + \u0027\\\").getNeededDependencies().each\u0027"},{"line_number":739,"context_line":"                      \u0027{it.deploy()}\u0027 + \u0027;\u0027 + script)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        response \u003d self.run_script(script)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_06c02929","line":738,"in_reply_to":"ba15a1d1_0daaba70","updated":"2015-09-16 22:15:02.000000000","message":"Done","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"58a45ef4b7de07648bae30d16891aa2e3219cb72","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                  \u0027Jenkins.instance.updateCenter.isRestartRequiredForCompletion()\u0027)"},{"line_number":737,"context_line":"        if include_dependencies:"},{"line_number":738,"context_line":"            script \u003d (\u0027Jenkins.instance.updateCenter.getPlugin(\\\"\u0027 + name + \u0027\\\").getNeededDependencies().each\u0027"},{"line_number":739,"context_line":"                      \u0027{it.deploy()}\u0027 + \u0027;\u0027 + script)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        response \u003d self.run_script(script)"},{"line_number":742,"context_line":"        # response is a string, u\u0027Result: true\\n\u0027, return a bool instead"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_adb70ed7","line":739,"updated":"2015-09-15 22:28:59.000000000","message":"Why have the \u0027;\u0027 set off from the rest of the string like this?","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"352a366dc45f1390f3821685be8a0658e3e6e23e","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                  \u0027Jenkins.instance.updateCenter.isRestartRequiredForCompletion()\u0027)"},{"line_number":737,"context_line":"        if include_dependencies:"},{"line_number":738,"context_line":"            script \u003d (\u0027Jenkins.instance.updateCenter.getPlugin(\\\"\u0027 + name + \u0027\\\").getNeededDependencies().each\u0027"},{"line_number":739,"context_line":"                      \u0027{it.deploy()}\u0027 + \u0027;\u0027 + script)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        response \u003d self.run_script(script)"},{"line_number":742,"context_line":"        # response is a string, u\u0027Result: true\\n\u0027, return a bool instead"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_c6e471e2","line":739,"in_reply_to":"ba15a1d1_adb70ed7","updated":"2015-09-16 22:15:02.000000000","message":"Done","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"58a45ef4b7de07648bae30d16891aa2e3219cb72","unresolved":false,"context_lines":[{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        response \u003d self.run_script(script)"},{"line_number":742,"context_line":"        # response is a string, u\u0027Result: true\\n\u0027, return a bool instead"},{"line_number":743,"context_line":"        return bool(response.replace(\u0027 \u0027, \u0027\u0027).split(\u0027:\u0027)[1])"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    def stop_build(self, name, number):"},{"line_number":746,"context_line":"        \u0027\u0027\u0027Stop a running Jenkins build."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_0d463abf","line":743,"updated":"2015-09-15 22:28:59.000000000","message":"This will always return True:\n\n    \u003e\u003e\u003e bool(u\u0027Result: false\\n\u0027.replace(\u0027 \u0027, \u0027\u0027).split(\u0027:\u0027)[1])\n    True\n\nPart of that is the newline at the end, and part of it is the fact that any non-empty string always coerces to boolean True.  Try this instead:\n\n    return response.split(\u0027:\u0027)[1].strip().lower() \u003d\u003d \u0027true\u0027\n\nProof that this works:\n\n    \u003e\u003e\u003e u\u0027Result: true\\n\u0027.split(\u0027:\u0027)[1].strip().lower() \u003d\u003d \u0027true\u0027\n    True\n    \u003e\u003e\u003e u\u0027Result: false\\n\u0027.split(\u0027:\u0027)[1].strip().lower() \u003d\u003d \u0027true\u0027\n    False","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"352a366dc45f1390f3821685be8a0658e3e6e23e","unresolved":false,"context_lines":[{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        response \u003d self.run_script(script)"},{"line_number":742,"context_line":"        # response is a string, u\u0027Result: true\\n\u0027, return a bool instead"},{"line_number":743,"context_line":"        return bool(response.replace(\u0027 \u0027, \u0027\u0027).split(\u0027:\u0027)[1])"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    def stop_build(self, name, number):"},{"line_number":746,"context_line":"        \u0027\u0027\u0027Stop a running Jenkins build."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_46d141f9","line":743,"in_reply_to":"ba15a1d1_0d463abf","updated":"2015-09-16 22:15:02.000000000","message":"Done. Nice catch!","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"}],"tests/test_script.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"58a45ef4b7de07648bae30d16891aa2e3219cb72","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.assertEqual("},{"line_number":26,"context_line":"            jenkins_mock.call_args[0][0].get_full_url(),"},{"line_number":27,"context_line":"            u\u0027http://example.com/scriptText\u0027)"},{"line_number":28,"context_line":"        self._check_requests(jenkins_mock.call_args_list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_4d519261","line":28,"updated":"2015-09-15 22:28:59.000000000","message":"It would probably be a nice idea to add tests on the return value of the method…","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"352a366dc45f1390f3821685be8a0658e3e6e23e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.assertEqual("},{"line_number":26,"context_line":"            jenkins_mock.call_args[0][0].get_full_url(),"},{"line_number":27,"context_line":"            u\u0027http://example.com/scriptText\u0027)"},{"line_number":28,"context_line":"        self._check_requests(jenkins_mock.call_args_list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_c60b118d","line":28,"in_reply_to":"ba15a1d1_4d519261","updated":"2015-09-16 22:15:02.000000000","message":"Done","commit_id":"03ec1a0fde4c3c3224237df659803fb7e8c2b819"}]}
