)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"a046bcfb45fd9fc0bd335fe5aec6c704ddab83c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed create_node() Error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed create_node() raises HTTP Error 400 Bad Request"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I85fa43bc0b4ff1530133b862734e94aede9b44a5"},{"line_number":12,"context_line":"Closes-Bug: #1500898"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_0e457244","line":9,"updated":"2015-12-08 18:37:53.000000000","message":"Could you please provide more info on what was broken and what the fix was?","commit_id":"9801ef1752c66ffd70664783c72c1b16062cb9fd"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"157d8328947fb9fc88ebbb6fd730059d92372fcd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed create_node() Error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed create_node() raises HTTP Error 400 Bad Request"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I85fa43bc0b4ff1530133b862734e94aede9b44a5"},{"line_number":12,"context_line":"Closes-Bug: #1500898"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_76e1329a","line":9,"in_reply_to":"7a740942_0e457244","updated":"2015-12-09 17:48:34.000000000","message":"Added more info on commit message, please help review","commit_id":"9801ef1752c66ffd70664783c72c1b16062cb9fd"}],"tests/test_node.py":[{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"2c689da5959a06939c34576248df4bc42251bfde","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            launcher\u003djenkins.LAUNCHER_SSH,"},{"line_number":248,"context_line":"            launcher_params\u003dparams)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        self.assertEqual("},{"line_number":251,"context_line":"            jenkins_mock.call_args_list[1][0][0].get_full_url(),"},{"line_number":252,"context_line":"            self.make_url(expect_url))"},{"line_number":253,"context_line":"        self._check_requests(jenkins_mock.call_args_list)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_80d43bbd","line":250,"updated":"2015-12-11 00:56:58.000000000","message":"The reason why the URL seems random is that the parameters are passed in as a dict.  In python a dict does not guarantee ordering so when it gets processed by _get_encoded_params() the parameters might get re-ordered.\n\n\nI think there are 2 options to make the test work:\n1. Verify sections of the URL with self.assertIn() instead of the entire URL, so something like this:\n\n actual \u003d jenkins_mock.call_args_list[1][0][0].get_full_url()\n self.assertIn(u\u0027remoteFS%22%3A+%22%2Fhome%2Fjuser\u0027, actual)\n self.assertIn(u\u0027labelString%22%3A+%22precise\u0027, actual)\n etc..\n\n\n2. Use an ordered for inner_params and params in create_node() method.  This might be slightly tricky though because ordered dict is different for py27 vs py34.  take a look here https://stackoverflow.com/questions/1617078/ordereddict-for-older-versions-of-python","commit_id":"eb0ba00fcb958a91a3bd8ab5bac76bea1f929165"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4d2605dda202ebbd6cb9c9044067ad09fd4047aa","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            launcher\u003djenkins.LAUNCHER_SSH,"},{"line_number":248,"context_line":"            launcher_params\u003dparams)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        self.assertEqual("},{"line_number":251,"context_line":"            jenkins_mock.call_args_list[1][0][0].get_full_url(),"},{"line_number":252,"context_line":"            self.make_url(expect_url))"},{"line_number":253,"context_line":"        self._check_requests(jenkins_mock.call_args_list)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_af2d8347","line":250,"in_reply_to":"7a740942_80d43bbd","updated":"2015-12-11 15:35:06.000000000","message":"Thanks for helping with this, I preferred the option 1 and made changes.","commit_id":"eb0ba00fcb958a91a3bd8ab5bac76bea1f929165"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"3be53edcf76c7b45a03de221a75c82dae840c88e","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            launcher\u003djenkins.LAUNCHER_SSH,"},{"line_number":232,"context_line":"            launcher_params\u003dparams)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        actual \u003d jenkins_mock.call_args_list[1][0][0].get_full_url()"},{"line_number":235,"context_line":"        self.assertIn(u\u0027username%22%3A+%22juser\u0027, actual)"},{"line_number":236,"context_line":"        self.assertIn("},{"line_number":237,"context_line":"            u\u0027stapler-class%22%3A+%22hudson.plugins.sshslaves.SSHLauncher\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a6de080f","line":234,"updated":"2015-12-11 17:01:50.000000000","message":"I think it would be nice to add a short comment here explaining why we need to use assertIn instead of assertEquals.","commit_id":"52311e00514cecddc47fe0c31659275ad3c41bb0"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"7725fb08ae9ff0e10333ce12335a67fe6af510e2","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            launcher\u003djenkins.LAUNCHER_SSH,"},{"line_number":232,"context_line":"            launcher_params\u003dparams)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        actual \u003d jenkins_mock.call_args_list[1][0][0].get_full_url()"},{"line_number":235,"context_line":"        self.assertIn(u\u0027username%22%3A+%22juser\u0027, actual)"},{"line_number":236,"context_line":"        self.assertIn("},{"line_number":237,"context_line":"            u\u0027stapler-class%22%3A+%22hudson.plugins.sshslaves.SSHLauncher\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_507a62f2","line":234,"in_reply_to":"7a740942_a6de080f","updated":"2015-12-12 10:37:51.000000000","message":"Done","commit_id":"52311e00514cecddc47fe0c31659275ad3c41bb0"}]}
