)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2d506ab3f95ac39ef80a65dc887e433e18f03cb4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bernardo Vale \u003cbernardosilveiravale@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-22 23:21:00 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Should use fullname instead of name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifb23269169f2bba70721c67f91a028f7fc36f1d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_e9a6e553","line":7,"updated":"2017-04-25 13:25:26.000000000","message":"I\u0027d like to see more detail in this commit message.  Why should we use fullname instead of name?  In which context(s)?  What exactly is better about fullname vs. name?","commit_id":"dbfe67e58860c3a25eda48d93bc6ba58991f2a9d"}],"jenkins/__init__.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2d506ab3f95ac39ef80a65dc887e433e18f03cb4","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        jobs \u003d self.get_all_jobs(folder_depth)"},{"line_number":385,"context_line":"        for job in jobs:"},{"line_number":386,"context_line":"            if re.search(pattern, job[\u0027name\u0027]):"},{"line_number":387,"context_line":"                result.append(self.get_job_info(job[\u0027fullname\u0027], depth\u003ddepth))"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        return result"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_490ef93b","line":387,"updated":"2017-04-25 13:25:26.000000000","message":"So, we\u0027re calling get_job_info() with the fullname after using name for the search.  Is this appropriate?  Should we be doing the regex match on the fullname instead of the name?  How should the tests be updated to accommodate this change?  If the tests aren\u0027t currently testing this method, they probably should be updated to do so; if they *are* testing this method, then why haven\u0027t you needed to update them?","commit_id":"dbfe67e58860c3a25eda48d93bc6ba58991f2a9d"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"1ef1967c9e868ee5f599f1f44278306be410ac66","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        jobs \u003d self.get_all_jobs(folder_depth)"},{"line_number":385,"context_line":"        for job in jobs:"},{"line_number":386,"context_line":"            if re.search(pattern, job[\u0027name\u0027]):"},{"line_number":387,"context_line":"                result.append(self.get_job_info(job[\u0027fullname\u0027], depth\u003ddepth))"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        return result"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_eb0e1d31","line":387,"in_reply_to":"5ff73747_490ef93b","updated":"2017-05-03 21:58:08.000000000","message":"That comes from the patch that added support for the Cloudbees folder plugin: 7267eec4542696b48fea6a07ccdf34c6e887f75f  The bug report on https://bugs.launchpad.net/python-jenkins/+bug/1685575 has an example with the folder/jobs:\n\n job1\n frontend/front-build\n frontend/front-deploy\n\nThe bug hints about:\n\n\u003e Because we\u0027re not sending the folder name to _get_job_folder.\n\nSo although on line 386 we match both \u0027front-build\u0027 and \u0027front-deploy\u0027 jobs, we attempt to get their job information using solely the base name.  _get_job_folder thus yields nothing since no jobs exist by that name.\n\n\nSo indeed we need to pass the fullname, so get_job_info() can use the folder to look it up. The match will still be done solely on the job base name though which match the method description.\n\n\nThere are some tests in tests/jobs/test_info.py test_regex().  I gave it a try this evening, but eventually gave up trying to mock the jenkins_open return based on the Request given.\n\nI believe my summary above is sufficient to justify merging this without tests.","commit_id":"dbfe67e58860c3a25eda48d93bc6ba58991f2a9d"}]}