)]}'
{"id":"jjb%2Fpython-jenkins~675239","triplet_id":"jjb%2Fpython-jenkins~master~Idef50f5a31d55991698b6217f55f15a9308b8526","project":"jjb/python-jenkins","branch":"master","topic":"fix-Jenkins.reconfig_credential()","hashtags":[],"change_id":"Idef50f5a31d55991698b6217f55f15a9308b8526","subject":"Fix reconfig_credential() to send the xml data","status":"MERGED","created":"2019-08-08 02:26:00.000000000","updated":"2019-12-22 14:21:27.000000000","submitted":"2019-12-22 14:21:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"675239-1577024487577-d3a5649f","meta_rev_id":"37fd73faada2f92128d43bdcf92bc554ba3e1bf8","_number":675239,"virtual_id_number":675239,"owner":{"_account_id":9318,"name":"Jeff Schroeder","email":"jeffschroeder@computer.org","username":"SEJeff"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"value":0,"_account_id":31430,"name":"Brandon","email":"b_clodius@yahoo.com"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-22 14:21:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26429,"name":"Joe, Lee","email":"lj_2005@163.com","username":"joelee"},{"value":0,"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},{"value":0,"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"all":[{"value":0,"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"value":0,"_account_id":31430,"name":"Brandon","email":"b_clodius@yahoo.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26429,"name":"Joe, Lee","email":"lj_2005@163.com","username":"joelee"},{"value":0,"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},{"value":2,"date":"2019-12-16 14:37:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"all":[{"value":0,"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"value":0,"_account_id":31430,"name":"Brandon","email":"b_clodius@yahoo.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26429,"name":"Joe, Lee","email":"lj_2005@163.com","username":"joelee"},{"value":0,"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},{"value":1,"date":"2019-12-22 14:13:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"_account_id":26429,"name":"Joe, Lee","email":"lj_2005@163.com","username":"joelee"},{"_account_id":31430,"name":"Brandon","email":"b_clodius@yahoo.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-08 03:09:52.000000000","updated_by":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"reviewer":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"state":"REVIEWER"},{"updated":"2019-08-22 01:25:47.000000000","updated_by":{"_account_id":26429,"name":"Joe, Lee","email":"lj_2005@163.com","username":"joelee"},"reviewer":{"_account_id":26429,"name":"Joe, Lee","email":"lj_2005@163.com","username":"joelee"},"state":"REVIEWER"},{"updated":"2019-09-12 16:22:23.000000000","updated_by":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"reviewer":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"state":"REVIEWER"},{"updated":"2019-12-13 22:18:53.000000000","updated_by":{"_account_id":31430,"name":"Brandon","email":"b_clodius@yahoo.com"},"reviewer":{"_account_id":31430,"name":"Brandon","email":"b_clodius@yahoo.com"},"state":"REVIEWER"},{"updated":"2019-12-22 14:13:03.000000000","updated_by":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"reviewer":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"state":"REVIEWER"},{"updated":"2019-12-22 14:21:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"52a54941fab589290ca885420ee6f12866c97e58","author":{"_account_id":9318,"name":"Jeff Schroeder","email":"jeffschroeder@computer.org","username":"SEJeff"},"date":"2019-08-08 02:26:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3582d6302576198e1b4d187f9620edf3e00e534f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 02:50:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs https://logs.opendev.org/39/675239/1/check/build-openstack-sphinx-docs/53ac681/html/ : SUCCESS in 6m 37s\n- your-readthedocs-job-requires-attention https://logs.opendev.org/39/675239/1/check/your-readthedocs-job-requires-attention/ad460c9/ : FAILURE in 40s (non-voting)\n- openstack-tox-cover https://logs.opendev.org/39/675239/1/check/openstack-tox-cover/88aac5a/cover/ : SUCCESS in 4m 52s\n- openstack-tox-py35 https://logs.opendev.org/39/675239/1/check/openstack-tox-py35/66e2873/ : SUCCESS in 5m 25s\n- openstack-tox-py36 https://logs.opendev.org/39/675239/1/check/openstack-tox-py36/8cbd264/ : SUCCESS in 3m 30s\n- openstack-tox-linters https://logs.opendev.org/39/675239/1/check/openstack-tox-linters/6329189/ : SUCCESS in 4m 39s\n- openstack-tox-py27 https://logs.opendev.org/39/675239/1/check/openstack-tox-py27/6ca0b9c/ : SUCCESS in 4m 00s\n- openstack-tox-pypy https://logs.opendev.org/39/675239/1/check/openstack-tox-pypy/fc3c0e6/ : SUCCESS in 4m 07s\n- jjb-tox-cross-jenkins-job-builder https://logs.opendev.org/39/675239/1/check/jjb-tox-cross-jenkins-job-builder/5ac531b/ : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":1},{"id":"fc6f20a94869df8d8b4e481197f12e968fe3fa3e","author":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"date":"2019-08-08 03:10:13.000000000","message":"Patch Set 1:\n\nI\u0027m not too familiar with this code, anyone know if this is a safe change for JJB?","accounts_in_message":[],"_revision_number":1},{"id":"1f9f6284a3d322458ab92975e8f23f5f51fb06ad","author":{"_account_id":26429,"name":"Joe, Lee","email":"lj_2005@163.com","username":"joelee"},"date":"2019-08-22 01:25:47.000000000","message":"Patch Set 1: Code-Review+1\n\nI add the functions for credential. yes, it\u0027s a bug and this should fix it.","accounts_in_message":[],"_revision_number":1},{"id":"e794d63a19bb016b0b99f8aba75af7c0664e46a1","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2019-09-12 16:22:23.000000000","message":"Patch Set 1: Code-Review-1\n\nCommit message is not clear enough to explain what is fixed by this change. Apparently I am not the only one confused.","accounts_in_message":[],"_revision_number":1},{"id":"9ddeefce576ca27e50178f1614a3668939571ae4","author":{"_account_id":31430,"name":"Brandon","email":"b_clodius@yahoo.com"},"date":"2019-12-13 22:18:53.000000000","message":"Patch Set 1: Code-Review+1\n\nIf you look at the code for create_credential you will see config_xml argument is passed as data argument to jenkins url request.\n\nreconfig_credential is missing the passing of this required argument to the jenkins url request.  If XML is not passed then a credential cannot be updated.","accounts_in_message":[],"_revision_number":1},{"id":"657fe49f75e1de0553d6a60511d26e0c9cf8667d","author":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"date":"2019-12-16 14:36:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"957c8b019aad5827e8f26023b9a900e565d36eea","author":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"date":"2019-12-16 14:37:21.000000000","message":"Patch Set 2: Code-Review+2\n\nI took a stab at rewording the commit message. Hopefully it\u0027s more clear now but let me know if you think we can improve it more.","accounts_in_message":[],"_revision_number":2},{"id":"d93e3815bec7f0c3cfcc60ea63274efe21e3ad7f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-16 14:48:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c6149cff63a4ee089e4ea31730ab6b5 : SUCCESS in 5m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d8365ab9cbf04a10a686dd1e8591c952 : SUCCESS in 5m 30s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/784790015dca4a86af438ef508fc0772 : SUCCESS in 5m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c294e1826a1340268fb099bc9c140191 : SUCCESS in 4m 27s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/4ef759f7dbcc41469578b5e6c2f5806e : SUCCESS in 5m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/352018c2e8bd4a76a4f77553852f42fc : SUCCESS in 4m 40s\n- openstack-tox-pypy https://zuul.opendev.org/t/openstack/build/c8199ce4f7624301a9fecd3a59bc403b : SUCCESS in 5m 37s\n- jjb-tox-cross-jenkins-job-builder https://zuul.opendev.org/t/openstack/build/9ef6d01aea1b4637a3f301bcb540b6b3 : SUCCESS in 4m 49s","accounts_in_message":[],"_revision_number":2},{"id":"39cfbde5b10938a4cf3676efff0f724b32ff3363","author":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"date":"2019-12-22 14:13:03.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4e1657737ebe1f1770a5f0d64a4eaf515924cb5e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-22 14:13:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"6a29d1aa0207c2e02baba4b44c4ab5d95619f8a5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-22 14:21:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/04ffc171b4734227bed94c0e790fc46c : SUCCESS in 2m 52s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/f4e8e91833c94a4388ee8b6b23b6c139 : SUCCESS in 4m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/05fc653514a24e4283f9c80087afa364 : SUCCESS in 3m 12s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/2dbe4dcc5f864be08366cbb2908de605 : SUCCESS in 3m 08s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/632fdaf6b1c04214bd241afb62d42c52 : SUCCESS in 2m 59s\n- jjb-tox-cross-jenkins-job-builder https://zuul.opendev.org/t/openstack/build/f19363584adb4ac59586595a9e7e6dac : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":2},{"id":"710a5bd01c968b6acc6006b33fd8ea23a8430079","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-22 14:21:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9bf7f8150937e87d8165fe4ac9c14462f1aacfda","revisions":{"f63032de210c10a19778ee72b0f3a291fb871e9a":{"kind":"REWORK","_number":1,"created":"2019-08-08 02:26:00.000000000","uploader":{"_account_id":9318,"name":"Jeff Schroeder","email":"jeffschroeder@computer.org","username":"SEJeff"},"ref":"refs/changes/39/675239/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/jjb/python-jenkins","ref":"refs/changes/39/675239/1","commands":{"Checkout":"git fetch https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/1"}}},"commit":{"parents":[{"commit":"35f660a8b95e4ef1df7edcaf429085842b6fbae5","subject":"Merge \"When updating jobs the response body may be empty\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/jjb/python-jenkins/commit/35f660a8b95e4ef1df7edcaf429085842b6fbae5"}]}],"author":{"name":"Jeff Schroeder","email":"jeffschroeder@computer.org","date":"2019-08-08 02:05:03.000000000","tz":-300},"committer":{"name":"Jeff Schroeder","email":"jeffschroeder@computer.org","date":"2019-08-08 02:25:44.000000000","tz":-300},"subject":"Fix Jenkins.reconfig_credential() to send the xml","message":"Fix Jenkins.reconfig_credential() to send the xml\n\nPreviously, reconfig_credential() would pass empty `data` and\n`Content-Length: 0`.\n\nChange-Id: Idef50f5a31d55991698b6217f55f15a9308b8526\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/jjb/python-jenkins/commit/f63032de210c10a19778ee72b0f3a291fb871e9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/jjb/python-jenkins/commit/f63032de210c10a19778ee72b0f3a291fb871e9a"}]},"branch":"refs/heads/master"},"9bf7f8150937e87d8165fe4ac9c14462f1aacfda":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2019-12-16 14:36:26.000000000","uploader":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"ref":"refs/changes/39/675239/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/jjb/python-jenkins","ref":"refs/changes/39/675239/2","commands":{"Checkout":"git fetch https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/jjb/python-jenkins refs/changes/39/675239/2"}}},"commit":{"parents":[{"commit":"36c99d34366aa9b72b86a920fae138865b953d79","subject":"Merge \"new method: create_folder (with tests)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/jjb/python-jenkins/commit/36c99d34366aa9b72b86a920fae138865b953d79"}]}],"author":{"name":"Jeff Schroeder","email":"jeffschroeder@computer.org","date":"2019-08-08 02:05:03.000000000","tz":-300},"committer":{"name":"Thanh Ha","email":"zxiiro@gmail.com","date":"2019-12-16 14:32:50.000000000","tz":-300},"subject":"Fix reconfig_credential() to send the xml data","message":"Fix reconfig_credential() to send the xml data\n\nPreviously, reconfig_credential() passed empty `data` with\n`Content-Length: 0` to the credentials configuration rather\nthan the credentials data.\n\nThis patch fixes the issue by passing the config_xml data to\nthe configuration API to properly update the credential.\n\nChange-Id: Idef50f5a31d55991698b6217f55f15a9308b8526\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/jjb/python-jenkins/commit/9bf7f8150937e87d8165fe4ac9c14462f1aacfda"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/jjb/python-jenkins/commit/9bf7f8150937e87d8165fe4ac9c14462f1aacfda"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}