)]}'
{"jenkins/__init__.py":[{"author":{"_account_id":31965,"name":"Adam Romanek","email":"romanek.adam@gmail.com","username":"romanek-adam"},"change_message_id":"00cc1912fc20e97d4c2ce0cb2a291c5780f89797","unresolved":false,"context_lines":[{"line_number":117,"context_line":"BUILD_JOB \u003d \u0027%(folder_url)sjob/%(short_name)s/build\u0027"},{"line_number":118,"context_line":"STOP_BUILD \u003d \u0027%(folder_url)sjob/%(short_name)s/%(number)s/stop\u0027"},{"line_number":119,"context_line":"BUILD_WITH_PARAMS_JOB \u003d \u0027%(folder_url)sjob/%(short_name)s/buildWithParameters\u0027"},{"line_number":120,"context_line":"BUILD_INFO \u003d \u0027%(folder_url)sjob/%(short_name)s/%(number)s/api/json?depth\u003d%(depth)s\u0027"},{"line_number":121,"context_line":"BUILD_CONSOLE_OUTPUT \u003d \u0027%(folder_url)sjob/%(short_name)s/%(number)s/consoleText\u0027"},{"line_number":122,"context_line":"BUILD_ENV_VARS \u003d \u0027%(folder_url)sjob/%(short_name)s/%(number)s/injectedEnvVars/api/json\u0027 + \\"},{"line_number":123,"context_line":"    \u0027?depth\u003d%(depth)s\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_aa4cae76","line":120,"updated":"2020-11-20 09:02:11.000000000","message":"Could you maybe extend the tests, for example test_build.py, to include some test cases with matrix jobs?\n\nThat could be useful to avoid regression in the future.","commit_id":"a8b91267835ef1f42f9ec6ab2809fd6ff343402a"},{"author":{"_account_id":31965,"name":"Adam Romanek","email":"romanek.adam@gmail.com","username":"romanek-adam"},"change_message_id":"7a2c540faa8ea6785a5eede57b00d0bc30fd52da","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        \u0027\u0027\u0027Get build information dictionary."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        :param name: Job name, ``str``"},{"line_number":636,"context_line":"        :param number: Build number, ``str``"},{"line_number":637,"context_line":"        :param depth: JSON depth, ``int``"},{"line_number":638,"context_line":"        :returns: dictionary of build information, ``dict``"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d382cf7e_90b814f8","line":636,"updated":"2020-11-23 08:42:18.000000000","message":"It should accept both `int` and `str`, otherwise it breaks the API.","commit_id":"1ee5a7ee3038676c15447b1cc2bd2c61448f3cd7"},{"author":{"_account_id":215,"name":"Jon-Paul Sullivan","email":"j3p0uk@hotmail.com","username":"jonpaul-sullivan"},"change_message_id":"3fb0dacba5527f4ed9630a85d5b6626eaec1c272","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        \u0027\u0027\u0027Get build information dictionary."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        :param name: Job name, ``str``"},{"line_number":636,"context_line":"        :param number: Build number, ``str``"},{"line_number":637,"context_line":"        :param depth: JSON depth, ``int``"},{"line_number":638,"context_line":"        :returns: dictionary of build information, ``dict``"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"88dab727_128c5e50","line":636,"in_reply_to":"d382cf7e_90b814f8","updated":"2020-11-23 10:37:47.000000000","message":"An int happily passes into the function as python is not strongly typed.  I can add that it should be both int and str, certainly.","commit_id":"1ee5a7ee3038676c15447b1cc2bd2c61448f3cd7"}],"tests/test_build.py":[{"author":{"_account_id":31965,"name":"Adam Romanek","email":"romanek.adam@gmail.com","username":"romanek-adam"},"change_message_id":"7a2c540faa8ea6785a5eede57b00d0bc30fd52da","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    def test_simple(self, jenkins_mock):"},{"line_number":15,"context_line":"        jenkins_mock.return_value \u003d \"build console output...\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        build_info \u003d self.j.get_build_console_output(u\u0027Test Job\u0027, number\u003d\u002752\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"        self.assertEqual(build_info, jenkins_mock.return_value)"},{"line_number":20,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_20761dda","line":17,"updated":"2020-11-23 08:42:18.000000000","message":"Actually I\u0027d suggest to leave the existing tests as before (and pass numbers), to make sure the API still accepts them as before. And then a new set of tests should be added with the number parameter being a string.","commit_id":"1ee5a7ee3038676c15447b1cc2bd2c61448f3cd7"},{"author":{"_account_id":215,"name":"Jon-Paul Sullivan","email":"j3p0uk@hotmail.com","username":"jonpaul-sullivan"},"change_message_id":"3fb0dacba5527f4ed9630a85d5b6626eaec1c272","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    def test_simple(self, jenkins_mock):"},{"line_number":15,"context_line":"        jenkins_mock.return_value \u003d \"build console output...\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        build_info \u003d self.j.get_build_console_output(u\u0027Test Job\u0027, number\u003d\u002752\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"        self.assertEqual(build_info, jenkins_mock.return_value)"},{"line_number":20,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f7c7d20_9c015f34","line":17,"in_reply_to":"fffc6b78_20761dda","updated":"2020-11-23 10:37:47.000000000","message":"Sure, I\u0027ll change to mix them up a little, as there are so many duplicated tests that I am very reluctant to add a swathe more for this distinction.  The code is barely maintainable as it is.","commit_id":"1ee5a7ee3038676c15447b1cc2bd2c61448f3cd7"}]}