)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"e7608e11a981a156376163f530ff100796f17503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"03c97e39_e7c162a1","updated":"2023-03-21 09:24:49.000000000","message":"Indeed, the test jobs are broken and we have a fix pending at https://review.opendev.org/c/jjb/python-jenkins/+/865776 ;)","commit_id":"f86c9161209f1a13cf91a33f706b03734b76f100"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"c4778d4f4ee8a02179708505bba949c99934cd67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"244508c1_ffdd1465","updated":"2023-03-21 11:00:23.000000000","message":"Thank you for informing me about this. Do you happen to have any information regarding when it will be resolved?","commit_id":"f86c9161209f1a13cf91a33f706b03734b76f100"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"b9acace4272c2cdc177b4878513fe84cfaaa1e6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f7bcd02_a0b5c316","updated":"2023-03-21 09:14:14.000000000","message":"recheck\nThe tests are failing for no package \u0027python-dev\u0027 and file/directory \u0027tox\u0027 exists. This is not related to the changes I made. Please recheck.","commit_id":"f86c9161209f1a13cf91a33f706b03734b76f100"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"972f3b5d054cfdd731545245593f0aae825f6f4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86337004_595e4a1b","updated":"2023-03-21 10:37:11.000000000","message":"recheck after CI fix https://review.opendev.org/c/jjb/python-jenkins/+/865776","commit_id":"f86c9161209f1a13cf91a33f706b03734b76f100"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"ef022817e5119fe28837125d9efc95b2d074eeab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e46ae6e_fd285879","in_reply_to":"244508c1_ffdd1465","updated":"2023-03-21 11:06:24.000000000","message":"We got CI fixed via https://review.opendev.org/c/jjb/python-jenkins/+/865776 (which I approved after I got ping on IRC earlier today).\n\nIt is now failing on lines being too long which should be able to reproduce locally by running:\n\n tox -e linters\n\nAs for reviewing the code itself, it will need a bit of a time since this repository is not that active anymore. I will look at doing a pass of review over the week-end.","commit_id":"f86c9161209f1a13cf91a33f706b03734b76f100"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"35188c8ce3f2d89479c70c34f711bf51eec6d974","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b0f9f204_143e0f5c","in_reply_to":"3e46ae6e_fd285879","updated":"2023-03-21 11:15:41.000000000","message":"Yes, I will push the changes after fixing the issue.\nCertainly, please inform me if any further changes are necessary during your review of the code.","commit_id":"f86c9161209f1a13cf91a33f706b03734b76f100"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"61f7927f68b30b60a25ee15162dcceee9e6840a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"805a4c3d_734082fd","updated":"2023-03-24 06:15:41.000000000","message":"Though all parameters are significant, I never added them because they can be fetched for the individual node by get_node_info().\n\nI\u0027ve excluded some parameters from the node information, which were large, to reduce the time and payload when rest calls are made. For example, \"monitorData\" is a parameter containing much information.\n\nI\u0027ve included the parameters of utmost importance; if you think some other parameters are essential, please let me know, and I\u0027ll add them too. \n\nThe goal/ need of the function has been mentioned in the commit description.","commit_id":"5eb8afaf9b1ff61107a4eb01b7160dd5271accbb"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"7ad3e5897a90973b76a0de696d8cfa3ac2ae85ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"603d3b1e_bf025dd7","updated":"2025-06-15 10:00:11.000000000","message":"Hi Zuul, Ted, and Antoine,\n\nIt\u0027s been more than 2 years since I opened this pull request. Could someone please review it so it can be merged?\n\nPlease let me know if anything needs to be corrected.","commit_id":"8172edd32c6117b9957578a9cd9b75dc24e2f980"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"3ef3e1556a42ee6275d7ebf798accbc72feec635","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"522f74ff_98cb611f","updated":"2025-06-15 14:21:39.000000000","message":"Since I got the code review approval from @vsevolod.fedorov@gmail.com, what are the next steps to get this change merged into master?","commit_id":"6c2e3be09a78d1b5f9be894188b5b347086bd078"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"7a8bf0094568beb1b094546dfb9ae57108991c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"60fd08e4_c9ff1b35","in_reply_to":"0eba1c39_39d5c248","updated":"2025-06-15 14:29:19.000000000","message":"I\u0027m not sure if the other reviewer is still active, as my change request is over two years old. If you know another active reviewer, we can add them. Otherwise, we can proceed with your approval since Ted and Antoine already reviewed this in the past.\n\nIf Antoine was active, they would have reviewed in last 2 years.","commit_id":"6c2e3be09a78d1b5f9be894188b5b347086bd078"},{"author":{"_account_id":34567,"name":"Vsevolod Fedorov","email":"vsevolod.fedorov@gmail.com","username":"vsevolod-fedorov"},"change_message_id":"3311defed0338d16969d4957097bcbf044783b45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0eba1c39_39d5c248","in_reply_to":"522f74ff_98cb611f","updated":"2025-06-15 14:23:54.000000000","message":"Next would be workflow+1 from me or somebody else. I think it would be good to give second reviewer a chance to read this review too.","commit_id":"6c2e3be09a78d1b5f9be894188b5b347086bd078"},{"author":{"_account_id":34567,"name":"Vsevolod Fedorov","email":"vsevolod.fedorov@gmail.com","username":"vsevolod-fedorov"},"change_message_id":"f960ea87780552a6e8ebbd593fe49f194ff7dc25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"89824ef3_674cab3f","in_reply_to":"60fd08e4_c9ff1b35","updated":"2025-06-15 14:30:39.000000000","message":"Ok then...","commit_id":"6c2e3be09a78d1b5f9be894188b5b347086bd078"}],"jenkins/__init__.py":[{"author":{"_account_id":35874,"name":"Ted Chen","email":"ted.chen@barco.com"},"change_message_id":"ac328e366b4f51574fca2a7a143a0f4748ed7c6c","unresolved":true,"context_lines":[{"line_number":1550,"context_line":"                node_info[\u0027offlineCauseReason\u0027] \u003d c[\"offlineCauseReason\"]"},{"line_number":1551,"context_line":"                node_info[\u0027temporarilyOffline\u0027] \u003d c[\"temporarilyOffline\"]"},{"line_number":1552,"context_line":"                nodes_info.append(node_info)"},{"line_number":1553,"context_line":"            return nodes_info"},{"line_number":1554,"context_line":"        except (req_exc.HTTPError, BadStatusLine):"},{"line_number":1555,"context_line":"            raise BadHTTPException(\"Error communicating with server[%s]\""},{"line_number":1556,"context_line":"                                   % self.server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a41a4332_361db34d","line":1553,"updated":"2023-03-23 02:59:57.000000000","message":"Small suggestion\nThe Pythonic way doing this is list comprehension. May improve the performance in large scale data iteration.\nLike\n\n```\nreturn [\n    {\n        \"name\": c[\"displayName\"],\n        \"description\": c[\"description\"],\n        ...\n    }\n    for c in nodes_data[\"computer\"]\n]\n```","commit_id":"bb772c3497d4b7891060993c7acadd15dcfdb5f5"},{"author":{"_account_id":35866,"name":"Hitesh Malhotra","display_name":"Hitesh Malhotra","email":"hiteshmalhotra622@gmail.com","username":"hitesh1409"},"change_message_id":"09bee6b3169278cc21e1e8a6490777e85f4a5e5e","unresolved":false,"context_lines":[{"line_number":1550,"context_line":"                node_info[\u0027offlineCauseReason\u0027] \u003d c[\"offlineCauseReason\"]"},{"line_number":1551,"context_line":"                node_info[\u0027temporarilyOffline\u0027] \u003d c[\"temporarilyOffline\"]"},{"line_number":1552,"context_line":"                nodes_info.append(node_info)"},{"line_number":1553,"context_line":"            return nodes_info"},{"line_number":1554,"context_line":"        except (req_exc.HTTPError, BadStatusLine):"},{"line_number":1555,"context_line":"            raise BadHTTPException(\"Error communicating with server[%s]\""},{"line_number":1556,"context_line":"                                   % self.server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"70e2341e_4b2602be","line":1553,"in_reply_to":"a41a4332_361db34d","updated":"2023-03-24 06:17:54.000000000","message":"I\u0027ve added the mentioned changes; please check and let me know if you have further suggestions.","commit_id":"bb772c3497d4b7891060993c7acadd15dcfdb5f5"}]}