)]}'
{"jenkins/__init__.py":[{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"cc2fae65709e9f30f6516141b9c92e958963115c","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        :param from_name: Name of Jenkins job to copy from, ``str``"},{"line_number":342,"context_line":"        :param to_name: Name of Jenkins job to copy to, ``str``"},{"line_number":343,"context_line":"        \u0027\u0027\u0027"},{"line_number":344,"context_line":"        self.job_exists(from_name)"},{"line_number":345,"context_line":"        self.jenkins_open(urllib2.Request("},{"line_number":346,"context_line":"            self.server + COPY_JOB % locals(), \u0027\u0027))"},{"line_number":347,"context_line":"        if not self.job_exists(to_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_4f75bdf8","line":344,"updated":"2014-05-05 15:21:40.000000000","message":"is this ok?  get_job_info and job_exists don\u0027t work the same.  get_job_info raises an exception when no jobs are found while job_exists does not.  Would it not be better to make this a conditional?  something like..\n\nif not self.jobs_exists(from_name):\n  raise JenkinsException(\u0027job[%s] does not exist\u0027 % name)\n\nself.jenkins_open(urllib2.Request(self.server + COPY_JOB % locals(), \u0027\u0027))\nif not self.job_exists(to_name): \n    raise JenkinsException(\u0027create[%s] failed\u0027 % (to_name))","commit_id":"1b7638643458d0c385ffa13d6705a061685c77e8"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"c09d8e41c8fafb43e39748c9e295c2b1761eb018","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        :param from_name: Name of Jenkins job to copy from, ``str``"},{"line_number":342,"context_line":"        :param to_name: Name of Jenkins job to copy to, ``str``"},{"line_number":343,"context_line":"        \u0027\u0027\u0027"},{"line_number":344,"context_line":"        self.job_exists(from_name)"},{"line_number":345,"context_line":"        self.jenkins_open(urllib2.Request("},{"line_number":346,"context_line":"            self.server + COPY_JOB % locals(), \u0027\u0027))"},{"line_number":347,"context_line":"        if not self.job_exists(to_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_ae2123a1","line":344,"in_reply_to":"3ae8d1ca_ee952189","updated":"2014-05-28 16:12:21.000000000","message":"that would be a great idea.","commit_id":"1b7638643458d0c385ffa13d6705a061685c77e8"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"75933cac89fd748853a83e76026668505271be30","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        :param from_name: Name of Jenkins job to copy from, ``str``"},{"line_number":342,"context_line":"        :param to_name: Name of Jenkins job to copy to, ``str``"},{"line_number":343,"context_line":"        \u0027\u0027\u0027"},{"line_number":344,"context_line":"        self.job_exists(from_name)"},{"line_number":345,"context_line":"        self.jenkins_open(urllib2.Request("},{"line_number":346,"context_line":"            self.server + COPY_JOB % locals(), \u0027\u0027))"},{"line_number":347,"context_line":"        if not self.job_exists(to_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_f2b756f3","line":344,"in_reply_to":"9ad9bd40_4f75bdf8","updated":"2014-05-05 15:41:07.000000000","message":"Good catch. I should have paid more attention.","commit_id":"1b7638643458d0c385ffa13d6705a061685c77e8"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"5b2be8e6a9d37166f315bac3f54253b262ce9144","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        :param from_name: Name of Jenkins job to copy from, ``str``"},{"line_number":342,"context_line":"        :param to_name: Name of Jenkins job to copy to, ``str``"},{"line_number":343,"context_line":"        \u0027\u0027\u0027"},{"line_number":344,"context_line":"        self.job_exists(from_name)"},{"line_number":345,"context_line":"        self.jenkins_open(urllib2.Request("},{"line_number":346,"context_line":"            self.server + COPY_JOB % locals(), \u0027\u0027))"},{"line_number":347,"context_line":"        if not self.job_exists(to_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_ee952189","line":344,"in_reply_to":"9ad9bd40_f2b756f3","updated":"2014-05-27 12:08:36.000000000","message":"Sorry guys I missed that entirely. String replace does not work that well and indeed we need a condition as Khai said.\n\nTo avoid repeating the block:\n\n if not self.jobs_exists(from_name):\n  raise JenkinsException(\u0027job[%s] does not exist\u0027 % name)\n\nWhat do you think of wrapping that condition in yet another method like assert_job_exist(self, name) ?","commit_id":"1b7638643458d0c385ffa13d6705a061685c77e8"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"2a820f4da54438826d092508ab9c2062cc8d2c42","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            return True"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    def assert_job_exists(self, name,"},{"line_number":409,"context_line":"                          exception_message\u003d\u0027job[%s] does not exists\u0027):"},{"line_number":410,"context_line":"        \u0027\u0027\u0027"},{"line_number":411,"context_line":"        :param name: Name of Jenkins job, ``str``"},{"line_number":412,"context_line":"        :param exception_message: Message to use for the exception. Formatted"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_68c35c38","line":409,"updated":"2014-06-18 09:03:06.000000000","message":"Minor typo:\n\n - job[%s] does not exists\n + job[%s] does not exist","commit_id":"225b5546437b72a9a41eb693a297803680276473"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"b8af8c2ca55d9a2f57dede1bf37855a884a6779b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        :param name: Name of Jenkins job, ``str``"},{"line_number":412,"context_line":"        :param exception_message: Message to use for the exception. Formatted"},{"line_number":413,"context_line":"                                  with ``name``"},{"line_number":414,"context_line":"        :throws: :class:`JenkinsException` whenever the job does not exists"},{"line_number":415,"context_line":"        \u0027\u0027\u0027"},{"line_number":416,"context_line":"        if not self.job_exists(name):"},{"line_number":417,"context_line":"            raise JenkinsException(exception_message % name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_a8c64414","line":414,"updated":"2014-06-18 09:07:01.000000000","message":"And there is another typo in the message:\n\n - does not exists\n + does not exist","commit_id":"89388cdfdca5aef143edb8e0559c6e6471d8d0e7"}]}
