)]}'
{"tasks/config.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9f6c274bd2877253990a4e490d3ccdaf7db817ab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    puppet_environmentpath: \u0027$confdir/environments\u0027"},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - puppet_version \u003d\u003d \u00273\u0027"},{"line_number":14,"context_line":"    - puppet_environmentpath"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Create our config"},{"line_number":17,"context_line":"- name: Create puppet.conf from template"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_7ba26bb0","line":14,"updated":"2019-05-13 16:24:51.000000000","message":"This checks that puppet_environmentpath is a truthy value but the old check was specifically that the value was empty string.\n\nIs this an equivalent (or otherwise correct) update?","commit_id":"44cb40aafa64b1c26889a6de9c92bf993466eae1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"21aa3a44ff2a3c5b2f0df3876b4fd357e506696e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    puppet_environmentpath: \u0027$confdir/environments\u0027"},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - puppet_version \u003d\u003d \u00273\u0027"},{"line_number":14,"context_line":"    - puppet_environmentpath"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Create our config"},{"line_number":17,"context_line":"- name: Create puppet.conf from template"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_dba6f7ab","line":14,"in_reply_to":"dfbec78f_7ba26bb0","updated":"2019-05-13 16:27:17.000000000","message":"https://docs.ansible.com/ansible-lint/rules/default_rules.html E602 has \"Use when: var rather than when: var !\u003d \"\" (or conversely when: not var rather than when: var \u003d\u003d \"\")\"","commit_id":"44cb40aafa64b1c26889a6de9c92bf993466eae1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"40b86b0fc42142f57ceecde73fb3b2f049be32c9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    puppet_environmentpath: \u0027$confdir/environments\u0027"},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - puppet_version \u003d\u003d \u00273\u0027"},{"line_number":14,"context_line":"    - puppet_environmentpath"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Create our config"},{"line_number":17,"context_line":"- name: Create puppet.conf from template"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_5be9a7b4","line":14,"in_reply_to":"dfbec78f_dba6f7ab","updated":"2019-05-13 16:29:07.000000000","message":"I think this should be:\n\n  when:\n    - puppet_version \u003d\u003d \u00273\u0027\n    - not puppet_environmentpath\n\nGiven those docs (old code was \u003d\u003d \u0027\u0027 not !\u003d \u0027\u0027)","commit_id":"44cb40aafa64b1c26889a6de9c92bf993466eae1"}],"tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9f6c274bd2877253990a4e490d3ccdaf7db817ab","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    - name: Set management server puppet module dir to user-defined path"},{"line_number":96,"context_line":"      set_fact:"},{"line_number":97,"context_line":"        mgmt_puppet_module_dir: \"{{ puppet_basemodulepath }}\""},{"line_number":98,"context_line":"      when: puppet_basemodulepath"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    - name: Set management server puppet module dir"},{"line_number":101,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_fb95fb40","line":98,"updated":"2019-05-13 16:24:51.000000000","message":"This comparison and the one below imply the check on the earlier file was not updated properly. I think we may need a not as below?","commit_id":"44cb40aafa64b1c26889a6de9c92bf993466eae1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f8ef77638fa88f3c40f63436da652aa8a3045cc8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    - name: Set management server puppet module dir to user-defined path"},{"line_number":96,"context_line":"      set_fact:"},{"line_number":97,"context_line":"        mgmt_puppet_module_dir: \"{{ puppet_basemodulepath }}\""},{"line_number":98,"context_line":"      when: puppet_basemodulepath"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    - name: Set management server puppet module dir"},{"line_number":101,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_9be39fd9","line":98,"in_reply_to":"dfbec78f_fb95fb40","updated":"2019-05-13 16:28:17.000000000","message":"This should be fine, see https://docs.ansible.com/ansible-lint/rules/default_rules.html E602","commit_id":"44cb40aafa64b1c26889a6de9c92bf993466eae1"}]}