)]}'
{"bindep/main.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0f2a240ec967b1ca3839d25cc6a2bfd247c6f6a8","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    logging.info("},{"line_number":111,"context_line":"        \"All packages required by the following profiles are installed:\")"},{"line_number":112,"context_line":"    logging.info(\"  %s\" % \u0027, \u0027.join(profiles))"},{"line_number":113,"context_line":"    return 0"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_f65ed7e4","line":112,"updated":"2019-09-09 20:04:14.000000000","message":"I think these need to be wrapped in \"if not args.brief:\" to avoid returning content when -b/--brief is used and there are no packages to install, though due to some unfortunate circumstances I\u0027m not in a position to test that at the moment.","commit_id":"8a315671d7d119c379fa1202061f531d0f9d0d15"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"86424ccfd8d3399076ab0fd8b7a5efcdb43ea14c","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    logging.info("},{"line_number":111,"context_line":"        \"All packages required by the following profiles are installed:\")"},{"line_number":112,"context_line":"    logging.info(\"  %s\" % \u0027, \u0027.join(profiles))"},{"line_number":113,"context_line":"    return 0"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_973f0fb3","line":112,"updated":"2019-09-12 16:19:07.000000000","message":"It\u0027s unfortunately used as a print-alternative in the conditionals above, and is using format string interpolation there too, so I wouldn\u0027t reject the change on those grounds as it\u0027s merely following the local conventions already established in the same file. My main concern is that it does need to guard against returning output in brief mode because that\u0027s a de facto API (the output is intended for purposes like feeding directly to a package manager command line invocation, and an empty ouput along with a 0 exit code is the current signal that it\u0027s not required).","commit_id":"8a315671d7d119c379fa1202061f531d0f9d0d15"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"99e9968963164ee73a843f0aabb3af63474710e0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    if errors:"},{"line_number":108,"context_line":"        return 1"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    logging.info("},{"line_number":111,"context_line":"        \"All packages required by the following profiles are installed:\")"},{"line_number":112,"context_line":"    logging.info(\"  %s\" % \u0027, \u0027.join(profiles))"},{"line_number":113,"context_line":"    return 0"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_7765c1e0","line":112,"range":{"start_line":110,"start_character":4,"end_line":112,"end_character":46},"updated":"2019-09-12 07:36:07.000000000","message":"Logging is not supposed to be used like print. Operation needs to run in a single call. Also for logging \"%\" is not needed because it will expand arguments by itself.","commit_id":"8a315671d7d119c379fa1202061f531d0f9d0d15"}]}