)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"497ac3e59a1e79b3d4f2c9db4992add72683f522","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds yum and dnf atoms for platforms"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds new atoms that can be used to filter platforms: yum and dnf as"},{"line_number":10,"context_line":"there is a clear need to distinguish between rpm platforms using one"},{"line_number":11,"context_line":"or another."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`dnf` is used by python3 based distros like Fedora\u003e28,CentOS\u003e7,RHEL\u003e7"},{"line_number":14,"context_line":"while `yum` is used on older systems."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_d25b1083","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":11},"updated":"2019-02-28 09:03:59.000000000","message":"There are more RPM platforms than those using dnf and yum like the SUSE ones.","commit_id":"76d457eecae1f48574726692e55bc99ab8a3ddb9"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"34a11dc3b579f3a042324b92035bac86e6f57ec2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds yum and dnf atoms for platforms"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds new atoms that can be used to filter platforms: yum and dnf as"},{"line_number":10,"context_line":"there is a clear need to distinguish between rpm platforms using one"},{"line_number":11,"context_line":"or another."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`dnf` is used by python3 based distros like Fedora\u003e28,CentOS\u003e7,RHEL\u003e7"},{"line_number":14,"context_line":"while `yum` is used on older systems."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_dd76c1a4","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":11},"in_reply_to":"9fdfeff1_d25b1083","updated":"2019-02-28 09:22:14.000000000","message":"Indeed but the scope of the change is to enable us to distinguish between dnf and yum blends of fedora/centos/rhel, obviously without breaking any platforms.\n\nUser can still narrow down using AND conditions with dnf/yum, probably most will also add \"platform:redhat\" in\norder to limit the coverage.\n\nStill, i see no reason why the same logic would not apply\nto other platforms. I just didn\u0027t know what to add to others.","commit_id":"76d457eecae1f48574726692e55bc99ab8a3ddb9"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"497ac3e59a1e79b3d4f2c9db4992add72683f522","unresolved":false,"context_lines":[{"line_number":10,"context_line":"there is a clear need to distinguish between rpm platforms using one"},{"line_number":11,"context_line":"or another."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`dnf` is used by python3 based distros like Fedora\u003e28,CentOS\u003e7,RHEL\u003e7"},{"line_number":14,"context_line":"while `yum` is used on older systems."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This allows bindep.txt users to write future proof dependencies like:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"python3-lxml [platform:dnf]"},{"line_number":19,"context_line":"python2-lxml [platform:yum]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Before this users had to rely on hacks like including the operating"},{"line_number":22,"context_line":"system name and version [platform:centos-7] and negative variants,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_b2e68caf","line":19,"range":{"start_line":13,"start_character":0,"end_line":19,"end_character":27},"updated":"2019-02-28 09:03:59.000000000","message":"So, the problem you are solving is that bindep does not allow \"\u003e\" for the OS, correct?\n\nI find dnf and yum as names for platforms confusing.","commit_id":"76d457eecae1f48574726692e55bc99ab8a3ddb9"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"34a11dc3b579f3a042324b92035bac86e6f57ec2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"there is a clear need to distinguish between rpm platforms using one"},{"line_number":11,"context_line":"or another."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`dnf` is used by python3 based distros like Fedora\u003e28,CentOS\u003e7,RHEL\u003e7"},{"line_number":14,"context_line":"while `yum` is used on older systems."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This allows bindep.txt users to write future proof dependencies like:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"python3-lxml [platform:dnf]"},{"line_number":19,"context_line":"python2-lxml [platform:yum]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Before this users had to rely on hacks like including the operating"},{"line_number":22,"context_line":"system name and version [platform:centos-7] and negative variants,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_fd794592","line":19,"range":{"start_line":13,"start_character":0,"end_line":19,"end_character":27},"in_reply_to":"9fdfeff1_b2e68caf","updated":"2019-02-28 09:22:14.000000000","message":"Adding version comparison would be a major change, not only to develop but also to test.\n\nWell, the cause if the use of \"platform\" terms, probably there for historic reasons. In the end a term like atoms or tags would probably have being less confusing.","commit_id":"76d457eecae1f48574726692e55bc99ab8a3ddb9"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"5bb80f353e19feb310950c2c7971caee6d632cd7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"there is a clear need to distinguish between rpm based platforms using"},{"line_number":11,"context_line":"one of these."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`dnf` is used by python3 based distros like Fedora,CentOS\u003e7,RHEL\u003e7"},{"line_number":14,"context_line":"while `yum` is used on older systems."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This allows bindep.txt users to write future proof dependencies like:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fdfeff1_ee3e4c27","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":37},"updated":"2019-03-01 14:36:22.000000000","message":"this isn\u0027t true in the case of RHEL\u003e7 (assuming CentOS\u003e8) see other comment for upstream documentation.","commit_id":"cb63d47f65d7312f19d45ba8183aafbfd63acd00"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"baf0accb70e77ca901a1b651b4221ee049b784a1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This allows bindep.txt users to write future proof dependencies like:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"python3-lxml [(platform:redhat platform:dnf)]"},{"line_number":19,"context_line":"python-lxml [(platform:redhat platform:yum)]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Before this users had to rely on hacks like including the operating"},{"line_number":22,"context_line":"system name and version [platform:centos-7] and negative variants,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5fc1f717_76c14f80","line":19,"updated":"2019-03-11 23:30:21.000000000","message":"In summary, the concern is that the above turns into\n\n python-devel [platform:redhat !platform:fedora !platform:centos-8 !platform:rhel-8]\n python3-devel [platform:fedora platform:centos-8 platform:rhel-8]\n\nwhen we consider rhel+centos8?  \n\nThe main problem being, we have to filter out all the \"new\" (python3) distros from the \"platform:redhat\" match.\n\nAdditionally, should there be a rhel/centos-9 this would need updating?\n\n---\n\nI certainly see why you\u0027ve come to dnf/yum as the differentiator.  I agree with others though that this feels like an odd implementation thing to switch on, that we will have to live with forever.\n\nI think I\u0027d prefer to see this named \"redhat-python2\" and \"redhat-python3\".  I feel like this would abstract things.  It may be the case that the easiest way to define those variables in bindep is like this with a yum/dnf switch.  but it leaves us the option of defining them some other way too -- even just hard-coding lists of distros in bindep if need be.","commit_id":"cb63d47f65d7312f19d45ba8183aafbfd63acd00"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d1e12520b19e7b1111ee17efb9792504c64d9578","unresolved":false,"context_lines":[{"line_number":23,"context_line":"system name and version [platform:centos-7] and negative variants,"},{"line_number":24,"context_line":"something that would being broken as soon a new release is made."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Initial implementation covers RedHat flavored systems and MacOS which"},{"line_number":27,"context_line":"do come with an official Python version but is made in such way that we"},{"line_number":28,"context_line":"could enable it for any other platforms."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I506699fb0c80f8d9ca84e20154d1c282a08708bb"},{"line_number":31,"context_line":"Task: https://tree.taiga.io/project/tripleo-ci-board/task/809"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7faddb67_aca159f9","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":40},"updated":"2019-08-20 08:57:21.000000000","message":"This could be amended now that you\u0027ve added more distros.","commit_id":"a00850b270223631e20be5531d0fe8c72d5e9cc3"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"e30769f21324530c9762d84b3f61d796a0f1ecab","unresolved":false,"context_lines":[{"line_number":23,"context_line":"system name and version [platform:centos-7] and negative variants,"},{"line_number":24,"context_line":"something that would being broken as soon a new release is made."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Initial implementation covers RedHat flavored systems and MacOS which"},{"line_number":27,"context_line":"do come with an official Python version but is made in such way that we"},{"line_number":28,"context_line":"could enable it for any other platforms."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I506699fb0c80f8d9ca84e20154d1c282a08708bb"},{"line_number":31,"context_line":"Task: https://tree.taiga.io/project/tripleo-ci-board/task/809"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7faddb67_64ffd465","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":40},"in_reply_to":"7faddb67_aca159f9","updated":"2019-08-21 19:18:37.000000000","message":"Done","commit_id":"a00850b270223631e20be5531d0fe8c72d5e9cc3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a0a16428e109833d65f7fcab1cc724809c42bf31","unresolved":false,"context_lines":[{"line_number":23,"context_line":"system name and version [platform:centos-7] and negative variants,"},{"line_number":24,"context_line":"something that would being broken as soon a new release is made."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Initial implementation covers RedHat flavored, Ubuntu, Debian and MacOS"},{"line_number":27,"context_line":"which do come with an official Python version but is made in such way"},{"line_number":28,"context_line":"that we could enable it for any other platforms."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7faddb67_41dcff43","line":26,"updated":"2019-08-22 08:08:01.000000000","message":"Might be good to also add tests for the latter three cases, but I don\u0027t think we need to hold up this patch for that, I\u0027d also do this in a followup myself if needed.","commit_id":"5ff210229763bf2c83d61113b2c773de51497bb9"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"79c2fa25a3bcb0114a13b86972b11e1685201196","unresolved":false,"context_lines":[{"line_number":23,"context_line":"system name and version [platform:centos-7] and negative variants,"},{"line_number":24,"context_line":"something that would being broken as soon a new release is made."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Initial implementation covers RedHat flavored, Ubuntu, Debian and MacOS"},{"line_number":27,"context_line":"which do come with an official Python version but is made in such way"},{"line_number":28,"context_line":"that we could enable it for any other platforms."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7faddb67_26a0f642","line":26,"in_reply_to":"7faddb67_41dcff43","updated":"2019-08-23 09:33:23.000000000","message":"Done","commit_id":"5ff210229763bf2c83d61113b2c773de51497bb9"}],"README.rst":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"a42a31b7ecbbc8aee150380ee4e561bf56110596","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    openssh-server [platform:redhat]"},{"line_number":144,"context_line":"    openssh [platform:suse]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If you need to distinguish between operating systems where python3 or python3"},{"line_number":147,"context_line":"is the official interpreter, you can use `base-py2` and `base-py3` labels."},{"line_number":148,"context_line":"Keep in mind that only one would be exposed for a specific operating system"},{"line_number":149,"context_line":"even if the system could support installation of multiple python versions."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_b1395cf3","line":146,"updated":"2019-03-20 07:31:27.000000000","message":"I guess you mean \"... where python2 or python3 ...\" instead of 2x python3?","commit_id":"f8e42e446ab13b40a688e38ad36ce1658a6f88d6"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"a42a31b7ecbbc8aee150380ee4e561bf56110596","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    python3-lxml [(platform:redhat platform:base-py3)]"},{"line_number":152,"context_line":"    python-lxml [(platform:redhat platform:base-py2)]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"The example above with install lxml python modules on official python used"},{"line_number":155,"context_line":"by platform."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"To select Python3 development packages, the OpenStack CI default file uses::"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_312d6ca8","line":154,"updated":"2019-03-20 07:31:27.000000000","message":"s/with/will/ I guess","commit_id":"f8e42e446ab13b40a688e38ad36ce1658a6f88d6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7543677e26799d4eefc37731a37c0d5161fade75","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    python-lxml [(platform:redhat platform:base-py2)]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"The example above will install lxml python modules on official python used"},{"line_number":155,"context_line":"by platform."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"To select Python3 development packages, the OpenStack CI default file uses::"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fce034c_a26bd8b4","line":155,"updated":"2019-04-18 15:40:27.000000000","message":"I\u0027m concerned that these \"global\" labels are only implemented for red hat distros and osx. At the very least we should document that limitation.\n\nHow difficult would it be to add base-py* rules for all of the distros currently supported by bindep? I think for all current ubuntus they are base-py3, not sure about suse or debian or alpine.","commit_id":"edc80b0d4d27f712420e531a9f9100764f4b7d43"}],"bindep.txt":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f3502e28c4242e414f50c0c2290117028e0d4a0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fdfeff1_32fa9c42","updated":"2019-02-28 09:06:06.000000000","message":"why is this empty file needed?","commit_id":"76d457eecae1f48574726692e55bc99ab8a3ddb9"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"34a11dc3b579f3a042324b92035bac86e6f57ec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fdfeff1_dd9b21c6","in_reply_to":"9fdfeff1_32fa9c42","updated":"2019-02-28 09:22:14.000000000","message":"Not really, I will remove it and eventually add it in another change.\n\nThe main reason for adding it is that bindep chokes if run in a folder without a bindep.txt file, so testing \"bindep --platforms\" in the root of it own repo didn\u0027t work.\n\nIn any case this would be a separate issue to address.","commit_id":"76d457eecae1f48574726692e55bc99ab8a3ddb9"}],"bindep/depends.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9f82e36c08f9d9c80ed9fe5191e487641524128b","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                atoms.update(self.codenamebits(\"sles\", codename))"},{"line_number":386,"context_line":"                atoms.update(self.releasebits(\"sles\", release))"},{"line_number":387,"context_line":"            elif \"fedora\" in distro_id:"},{"line_number":388,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"28\") else \"dnf\")"},{"line_number":389,"context_line":"            elif \"centos\" in distro_id:"},{"line_number":390,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"8\") else \"dnf\")"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_b77af173","line":388,"updated":"2019-02-28 15:49:18.000000000","message":"Hasn\u0027t fedora been dnf since like 22? Not sure we need this switch for fedora","commit_id":"4325a60d3908feed2d6e1e8c2d204f6f80cf73e3"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"05ec8bd8e09b9303e232a0fa916a12cec5ca96ff","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                atoms.update(self.codenamebits(\"sles\", codename))"},{"line_number":386,"context_line":"                atoms.update(self.releasebits(\"sles\", release))"},{"line_number":387,"context_line":"            elif \"fedora\" in distro_id:"},{"line_number":388,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"28\") else \"dnf\")"},{"line_number":389,"context_line":"            elif \"centos\" in distro_id:"},{"line_number":390,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"8\") else \"dnf\")"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_b384445f","line":388,"in_reply_to":"9fdfeff1_b77af173","updated":"2019-03-01 13:56:21.000000000","message":"indeed, not a full bug because anything before 28 is already out of support anyway but I will fix it.","commit_id":"4325a60d3908feed2d6e1e8c2d204f6f80cf73e3"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"1a59cd5ec4826e5318074e4a1fa6fd723979f9d0","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                atoms.add(\"rhel\")"},{"line_number":344,"context_line":"                atoms.update(self.codenamebits(\"rhel\", codename))"},{"line_number":345,"context_line":"                atoms.update(self.releasebits(\"rhel\", release))"},{"line_number":346,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"8\") else \"dnf\")"},{"line_number":347,"context_line":"            elif distro_id \u003d\u003d \u0027rhel\u0027 and \u0027server\u0027 in distro.name().lower():"},{"line_number":348,"context_line":"                atoms.add(\"redhatenterpriseserver\")"},{"line_number":349,"context_line":"                atoms.update(self.codenamebits(\"redhatenterpriseserver\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_3afc8f70","line":346,"updated":"2019-03-01 13:52:06.000000000","message":"I thought RHEL 8 shipped with yum4, a wrapper to dnf. I am unsure if dnf command is actually present.","commit_id":"cb63d47f65d7312f19d45ba8183aafbfd63acd00"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f315c5c8c5884e3dbb73f849070a94427c751f5b","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                atoms.add(\"rhel\")"},{"line_number":344,"context_line":"                atoms.update(self.codenamebits(\"rhel\", codename))"},{"line_number":345,"context_line":"                atoms.update(self.releasebits(\"rhel\", release))"},{"line_number":346,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"8\") else \"dnf\")"},{"line_number":347,"context_line":"            elif distro_id \u003d\u003d \u0027rhel\u0027 and \u0027server\u0027 in distro.name().lower():"},{"line_number":348,"context_line":"                atoms.add(\"redhatenterpriseserver\")"},{"line_number":349,"context_line":"                atoms.update(self.codenamebits(\"redhatenterpriseserver\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_f19da46c","line":346,"in_reply_to":"9fdfeff1_0ef5d082","updated":"2019-03-04 17:58:30.000000000","message":"While \u0027yum\u0027 exists, it\u0027s basically a symlink to dnf. So they don\u0027t continue to behave the same.  man yum is basically dnf\u0027s man page.","commit_id":"cb63d47f65d7312f19d45ba8183aafbfd63acd00"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"5bb80f353e19feb310950c2c7971caee6d632cd7","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                atoms.add(\"rhel\")"},{"line_number":344,"context_line":"                atoms.update(self.codenamebits(\"rhel\", codename))"},{"line_number":345,"context_line":"                atoms.update(self.releasebits(\"rhel\", release))"},{"line_number":346,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"8\") else \"dnf\")"},{"line_number":347,"context_line":"            elif distro_id \u003d\u003d \u0027rhel\u0027 and \u0027server\u0027 in distro.name().lower():"},{"line_number":348,"context_line":"                atoms.add(\"redhatenterpriseserver\")"},{"line_number":349,"context_line":"                atoms.update(self.codenamebits(\"redhatenterpriseserver\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_0ef5d082","line":346,"in_reply_to":"9fdfeff1_1a518b62","updated":"2019-03-01 14:36:22.000000000","message":"The issue here is, RHEL 8 seems to default to yum as the package manager:\n\n  https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8-beta/html/8.0_beta_release_notes/new-features#software_management_2\n\nHowever, yum really is dnf here, with some magic sauce to keep backwards compat. So, I am unsure if we want to override the default to dnf for bindep.\n\nLets get ianw to review, he\u0027s been doing a lot of work on rhel8 and dib.","commit_id":"cb63d47f65d7312f19d45ba8183aafbfd63acd00"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"05ec8bd8e09b9303e232a0fa916a12cec5ca96ff","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                atoms.add(\"rhel\")"},{"line_number":344,"context_line":"                atoms.update(self.codenamebits(\"rhel\", codename))"},{"line_number":345,"context_line":"                atoms.update(self.releasebits(\"rhel\", release))"},{"line_number":346,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"8\") else \"dnf\")"},{"line_number":347,"context_line":"            elif distro_id \u003d\u003d \u0027rhel\u0027 and \u0027server\u0027 in distro.name().lower():"},{"line_number":348,"context_line":"                atoms.add(\"redhatenterpriseserver\")"},{"line_number":349,"context_line":"                atoms.update(self.codenamebits(\"redhatenterpriseserver\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_1a518b62","line":346,"in_reply_to":"9fdfeff1_3afc8f70","updated":"2019-03-01 13:56:21.000000000","message":"The purpose of this is to expose only the implicit/default package manager, not optional ones. Both yum and dnf coexisted for years but only one was official for a specific  distro-version combination.","commit_id":"cb63d47f65d7312f19d45ba8183aafbfd63acd00"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e9fdf4bb6326d7e5e42269e22ebcf1b99159d452","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                atoms.add(\"rhel\")"},{"line_number":344,"context_line":"                atoms.update(self.codenamebits(\"rhel\", codename))"},{"line_number":345,"context_line":"                atoms.update(self.releasebits(\"rhel\", release))"},{"line_number":346,"context_line":"                atoms.add(\"yum\" if release_version \u003c as_ver(\"8\") else \"dnf\")"},{"line_number":347,"context_line":"            elif distro_id \u003d\u003d \u0027rhel\u0027 and \u0027server\u0027 in distro.name().lower():"},{"line_number":348,"context_line":"                atoms.add(\"redhatenterpriseserver\")"},{"line_number":349,"context_line":"                atoms.update(self.codenamebits(\"redhatenterpriseserver\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_31d7acf1","line":346,"in_reply_to":"9fdfeff1_f19da46c","updated":"2019-03-04 18:04:20.000000000","message":"[stack@undercloud-0 ~]$ cat /etc/redhat-release \u0026\u0026 ls -al /usr/bin/yum\nRed Hat Enterprise Linux release 8.0 Beta (Ootpa)\nlrwxrwxrwx. 1 root root 5 Oct 15 09:25 /usr/bin/yum -\u003e dnf-3","commit_id":"cb63d47f65d7312f19d45ba8183aafbfd63acd00"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d1e12520b19e7b1111ee17efb9792504c64d9578","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            # https://wiki.debian.org/Python"},{"line_number":334,"context_line":"            # https://wiki.ubuntu.com/Python"},{"line_number":335,"context_line":"            if (distro_id \u003d\u003d \u0027ubuntu\u0027 and release_version \u003e\u003d"},{"line_number":336,"context_line":"                as_ver(\"16.04\")) or (distro_id \u003d\u003d \u0027debian\u0027 and"},{"line_number":337,"context_line":"                                     release_version \u003e\u003d as_ver(\"10\")):"},{"line_number":338,"context_line":"                    atoms.add(PY3)"},{"line_number":339,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_cc2135a0","line":336,"updated":"2019-08-20 08:57:21.000000000","message":"I\u0027m not sure I agree with the Ubuntu cutoff. Even on 18.04 the default \"python\" binary points to python2 for me.","commit_id":"a00850b270223631e20be5531d0fe8c72d5e9cc3"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"e30769f21324530c9762d84b3f61d796a0f1ecab","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            # https://wiki.debian.org/Python"},{"line_number":334,"context_line":"            # https://wiki.ubuntu.com/Python"},{"line_number":335,"context_line":"            if (distro_id \u003d\u003d \u0027ubuntu\u0027 and release_version \u003e\u003d"},{"line_number":336,"context_line":"                as_ver(\"16.04\")) or (distro_id \u003d\u003d \u0027debian\u0027 and"},{"line_number":337,"context_line":"                                     release_version \u003e\u003d as_ver(\"10\")):"},{"line_number":338,"context_line":"                    atoms.add(PY3)"},{"line_number":339,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_440ad878","line":336,"in_reply_to":"7faddb67_cc2135a0","updated":"2019-08-21 19:18:37.000000000","message":"Do not confuse what python executable points to with official python version. Due to some old PSF backed recommendation most py3 distros do not even have a python executable but they have \"python3\" installed.\n\nThe infamous document I am referring to is https://www.python.org/dev/peps/pep-0394/\n\nOne less official way to test which is default/prefered way to install it to see what happens when you try to install tox package. On newer distros I found it to install python3.\n\nOn the other hand keep in mind that we never said that we would only publish one of base-py2 or base-py3, so it may be possible to expose both if we decide is better (without breaking dependencies)","commit_id":"a00850b270223631e20be5531d0fe8c72d5e9cc3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"176dda84cb2979ab2ddd098a5540328c618df5de","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            if (distro_id \u003d\u003d \u0027ubuntu\u0027 and release_version \u003e\u003d"},{"line_number":336,"context_line":"                as_ver(\"16.04\")) or (distro_id \u003d\u003d \u0027debian\u0027 and"},{"line_number":337,"context_line":"                                     release_version \u003e\u003d as_ver(\"10\")):"},{"line_number":338,"context_line":"                    atoms.add(PY3)"},{"line_number":339,"context_line":"            else:"},{"line_number":340,"context_line":"                atoms.add(PY2)"},{"line_number":341,"context_line":"            self.platform \u003d Dpkg()"}],"source_content_type":"text/x-python","patch_set":16,"id":"7faddb67_e1be3dad","line":338,"updated":"2019-08-22 18:09:17.000000000","message":"Debian buster is python3 too, https://wiki.debian.org/Python#Supported_Python_Versions","commit_id":"5ff210229763bf2c83d61113b2c773de51497bb9"}],"bindep/tests/bindep.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d1e12520b19e7b1111ee17efb9792504c64d9578","unresolved":false,"context_lines":[{"line_number":87,"context_line":"python-lxml [!platform:gentoo !platform:fedora]"},{"line_number":88,"context_line":"# base-py3 covers CentOS\u003e\u003d8, Fedora\u003e\u003d28, RHEL\u003e\u003d8"},{"line_number":89,"context_line":"python3-lxml [(platform:redhat platform:base-py3)]"},{"line_number":90,"context_line":"# base-py2 covers CentOS\u003c8, Fedora\u003c28, RHEL\u003c8"},{"line_number":91,"context_line":"python-lxml [(platform:redhat platform:base-py2)]"},{"line_number":92,"context_line":"dev-python/lxml [platform:gentoo]"},{"line_number":93,"context_line":"# Note that python3-all-dev includes python3-all, added"}],"source_content_type":"text/plain","patch_set":14,"id":"7faddb67_2c19e978","line":90,"updated":"2019-08-20 08:57:21.000000000","message":"The code says py2 is set for Fedora\u003c23, not 28","commit_id":"a00850b270223631e20be5531d0fe8c72d5e9cc3"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"e30769f21324530c9762d84b3f61d796a0f1ecab","unresolved":false,"context_lines":[{"line_number":87,"context_line":"python-lxml [!platform:gentoo !platform:fedora]"},{"line_number":88,"context_line":"# base-py3 covers CentOS\u003e\u003d8, Fedora\u003e\u003d28, RHEL\u003e\u003d8"},{"line_number":89,"context_line":"python3-lxml [(platform:redhat platform:base-py3)]"},{"line_number":90,"context_line":"# base-py2 covers CentOS\u003c8, Fedora\u003c28, RHEL\u003c8"},{"line_number":91,"context_line":"python-lxml [(platform:redhat platform:base-py2)]"},{"line_number":92,"context_line":"dev-python/lxml [platform:gentoo]"},{"line_number":93,"context_line":"# Note that python3-all-dev includes python3-all, added"}],"source_content_type":"text/plain","patch_set":14,"id":"7faddb67_648274c9","line":90,"in_reply_to":"7faddb67_2c19e978","updated":"2019-08-21 19:18:37.000000000","message":"Yep, 23 is correct. Not that I do expect to see users using  versions with these numbers. Still, good idea to be historically correct ;)","commit_id":"a00850b270223631e20be5531d0fe8c72d5e9cc3"}]}