)]}'
{"bindep/depends.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"7ab5f5f25b746661ee79632a7a61e324dfc7a23a","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        return atoms"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def platform_profiles(self):"},{"line_number":307,"context_line":"        if platform.system() \u003d\u003d \u0027Darwin\u0027:"},{"line_number":308,"context_line":"            atoms \u003d set([\u0027darwin\u0027])"},{"line_number":309,"context_line":"            # detect available macos package managers"},{"line_number":310,"context_line":"            if os.system(\u0027which brew \u003e/dev/null\u0027) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_cc4eca95","side":"PARENT","line":307,"updated":"2019-10-18 23:04:27.000000000","message":"I\u0027m curious how this ends up matching on Linux... are you sure?","commit_id":"8c489f141d7154f65da05036f38f2d68e399ad57"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2519bc3bc06d985676e002a139ffef9db452c737","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        return atoms"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def platform_profiles(self):"},{"line_number":307,"context_line":"        if platform.system() \u003d\u003d \u0027Darwin\u0027:"},{"line_number":308,"context_line":"            atoms \u003d set([\u0027darwin\u0027])"},{"line_number":309,"context_line":"            # detect available macos package managers"},{"line_number":310,"context_line":"            if os.system(\u0027which brew \u003e/dev/null\u0027) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4c089a2c","side":"PARENT","line":307,"in_reply_to":"3fa7e38b_cc4eca95","updated":"2019-10-18 23:26:56.000000000","message":"Hit it while running tests; bindep/tests/test_depends.py:TestDepends.test_detects_darwin mocks out platform.system but not os.system.","commit_id":"8c489f141d7154f65da05036f38f2d68e399ad57"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"04459cc071aa64a306e0be282b7265157cd93b03","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if platform.system() \u003d\u003d \u0027Darwin\u0027:"},{"line_number":308,"context_line":"            atoms \u003d set([\u0027darwin\u0027])"},{"line_number":309,"context_line":"            # detect available macos package managers"},{"line_number":310,"context_line":"            if os.system(\u0027which brew \u003e/dev/null 2\u003e\u00261\u0027) \u003d\u003d 0:"},{"line_number":311,"context_line":"                atoms.add(\u0027brew\u0027)"},{"line_number":312,"context_line":"                atoms.add(PY2)"},{"line_number":313,"context_line":"                self.platform \u003d Brew()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8c6f72fb","line":310,"updated":"2019-10-18 23:02:52.000000000","message":"Whoops! Looks like this crept in with the macos support patch.","commit_id":"f124ce4d46a54d4bbfef422ee31e3ac787007649"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2519bc3bc06d985676e002a139ffef9db452c737","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if platform.system() \u003d\u003d \u0027Darwin\u0027:"},{"line_number":308,"context_line":"            atoms \u003d set([\u0027darwin\u0027])"},{"line_number":309,"context_line":"            # detect available macos package managers"},{"line_number":310,"context_line":"            if os.system(\u0027which brew \u003e/dev/null 2\u003e\u00261\u0027) \u003d\u003d 0:"},{"line_number":311,"context_line":"                atoms.add(\u0027brew\u0027)"},{"line_number":312,"context_line":"                atoms.add(PY2)"},{"line_number":313,"context_line":"                self.platform \u003d Brew()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_87242bb1","line":310,"in_reply_to":"3fa7e38b_8c6f72fb","updated":"2019-10-18 23:26:56.000000000","message":"I suppose another option would be to use distutils.spawn.find_executable() [1] or something instead of shelling out -- has the advantage of being available back on python2, unlike shutil.which() [2].\n\n[1] https://docs.python.org/3/distutils/apiref.html#module-distutils.spawn\n[2] https://docs.python.org/3/library/shutil.html#shutil.which","commit_id":"f124ce4d46a54d4bbfef422ee31e3ac787007649"}]}