)]}'
{"Makefile":[{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8a593c917122d7b8b3414d959950e5654c36daf4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".PHONY: into"},{"line_number":30,"context_line":"into: ## Starts bash inside docker image"},{"line_number":31,"context_line":"\tdocker run -it elastic-recheck /bin/bash"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9f560f44_f556e6cd","line":31,"updated":"2020-09-10 16:30:34.000000000","message":"tab spacing?","commit_id":"4ec0e400fc98f300a1e6a10698bf7971536fbd8e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"278ea8c5a02c5ba11cc9bc9ab46ee4f37ee7a4dd","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".PHONY: into"},{"line_number":30,"context_line":"into: ## Starts bash inside docker image"},{"line_number":31,"context_line":"\tdocker run -it elastic-recheck /bin/bash"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9f560f44_5fc23f35","line":31,"in_reply_to":"9f560f44_f556e6cd","updated":"2020-09-11 10:21:54.000000000","message":"Makefiles work only with tabs, it would not work with spaces.","commit_id":"4ec0e400fc98f300a1e6a10698bf7971536fbd8e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c2fb1d00aaee5503dc70d10ab16c54d1dc5678cf","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":".PHONY: into"},{"line_number":36,"context_line":"into: ## Starts bash inside docker image"},{"line_number":37,"context_line":"\t# podman engine requires `localhost/` prefix"},{"line_number":38,"context_line":"\t$(ENGINE) run -it $(IMAGE_TAG) /bin/bash"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9f560f44_b7460822","line":37,"range":{"start_line":37,"start_character":39,"end_line":37,"end_character":45},"updated":"2020-09-14 07:00:58.000000000","message":"where you mean on the IMAG_TAG ? \nwhy don\u0027t we add an if clause then?","commit_id":"54ae49644837adf156bacb86cca5c97082512b77"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"aeab7c5d2e8f4fa94a707ea49be537f6903a1b8c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"define PRINT_HELP_PYSCRIPT"},{"line_number":17,"context_line":"import re, sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"print(\"Usage: make \u003ctarget\u003e\\n\")"},{"line_number":20,"context_line":"cmds \u003d {}"},{"line_number":21,"context_line":"for line in sys.stdin:"},{"line_number":22,"context_line":"\tmatch \u003d re.match(r\u0027^([a-zA-Z_-]+):.*?## (.*)$$\u0027, line)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9f560f44_72bc6706","line":19,"updated":"2020-09-15 06:51:42.000000000","message":"this is OK\n[m@localhost elastic-recheck]$ make \nUsage: make \u003ctarget\u003e\n\n  build        Build image using docker\n  dive         Use `dive` tool to investigate container size\n  into         Starts bash inside docker image","commit_id":"88211997df2bb30c167f103774a5691e348d0ae0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"aeab7c5d2e8f4fa94a707ea49be537f6903a1b8c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\t$(ENGINE) build -t $(IMAGE_TAG) ."},{"line_number":38,"context_line":"\t@echo \"Image size: $$(docker image inspect --format\u003d\u0027scale\u003d0; {{.Size}}/1024/1024\u0027 $(IMAGE_TAG) | bc)MB\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".PHONY: into"},{"line_number":41,"context_line":"into: ## Starts bash inside docker image"},{"line_number":42,"context_line":"\t$(ENGINE) run -it $(IMAGE_TAG) /bin/bash"},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9f560f44_12440b19","line":40,"updated":"2020-09-15 06:51:42.000000000","message":"not sure that is OK\n\n[m@localhost elastic-recheck]$ make into\n/usr/bin/docker run -it localhost/elastic-recheck /bin/bash\nUnable to find image \u0027localhost/elastic-recheck:latest\u0027 locally\n/usr/bin/docker: Error response from daemon: Get \"http://localhost/v2/\": dial tcp [::1]:80: connect: connection refused.\n\n\nEDIT: ah probably i need to re-run it after building image (ongoing)\nEDIT2: yes it was OK after the image built:\n\n[m@localhost elastic-recheck]$ make into\n/usr/bin/docker run -it localhost/elastic-recheck /bin/bash","commit_id":"88211997df2bb30c167f103774a5691e348d0ae0"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"d0c2c11a838519abb5e74273a4670fbc6b3b5b5c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\t$(ENGINE) build -t $(IMAGE_TAG) ."},{"line_number":38,"context_line":"\t@echo \"Image size: $$(docker image inspect --format\u003d\u0027scale\u003d0; {{.Size}}/1024/1024\u0027 $(IMAGE_TAG) | bc)MB\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".PHONY: into"},{"line_number":41,"context_line":"into: ## Starts bash inside docker image"},{"line_number":42,"context_line":"\t$(ENGINE) run -it $(IMAGE_TAG) /bin/bash"},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9f560f44_f20b57d2","line":40,"in_reply_to":"9f560f44_12440b19","updated":"2020-09-15 06:57:18.000000000","message":"Expected, lets not over engineer (even more) this utility script, at least not now.","commit_id":"88211997df2bb30c167f103774a5691e348d0ae0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"aeab7c5d2e8f4fa94a707ea49be537f6903a1b8c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t$(ENGINE) run -it $(IMAGE_TAG) /bin/bash"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".PHONY: dive"},{"line_number":45,"context_line":"dive:  ## Use `dive` tool to investigate container size"},{"line_number":46,"context_line":"\t# https://github.com/wagoodman/dive"},{"line_number":47,"context_line":"\tdive $(IMAGE_TAG)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9f560f44_725107da","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":4},"updated":"2020-09-15 06:51:42.000000000","message":"this one seems broken? \n\n[m@localhost elastic-recheck]$ make dive\n# https://github.com/wagoodman/dive\ndive localhost/elastic-recheck\nmake: dive: Command not found\nmake: *** [Makefile:47: dive] Error 127","commit_id":"88211997df2bb30c167f103774a5691e348d0ae0"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"d0c2c11a838519abb5e74273a4670fbc6b3b5b5c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t$(ENGINE) run -it $(IMAGE_TAG) /bin/bash"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".PHONY: dive"},{"line_number":45,"context_line":"dive:  ## Use `dive` tool to investigate container size"},{"line_number":46,"context_line":"\t# https://github.com/wagoodman/dive"},{"line_number":47,"context_line":"\tdive $(IMAGE_TAG)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9f560f44_922f7b3d","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":4},"in_reply_to":"9f560f44_725107da","updated":"2020-09-15 06:57:18.000000000","message":"Also expected if you do not have the tool. I did not want to force anyone to use it but including a command to run it may prove helpful for debugging.\n\nHint: homebrew works for linux too, quite well, so \"brew install dive\" if you want to play with it (not needed).","commit_id":"88211997df2bb30c167f103774a5691e348d0ae0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9b87a9acd9b1c1a8cf7cfa56704b90978916634c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t$(ENGINE) run -it $(IMAGE_TAG) /bin/bash"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".PHONY: dive"},{"line_number":45,"context_line":"dive:  ## Use `dive` tool to investigate container size"},{"line_number":46,"context_line":"\t# https://github.com/wagoodman/dive"},{"line_number":47,"context_line":"\tdive $(IMAGE_TAG)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9f560f44_32cdcf5e","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":4},"in_reply_to":"9f560f44_922f7b3d","updated":"2020-09-15 07:13:09.000000000","message":"thanks i thought it was a subcommand of docker/podman :)\nrevoting","commit_id":"88211997df2bb30c167f103774a5691e348d0ae0"}]}