)]}'
{"elastic_recheck/elasticRecheck.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"66173cea05e92577a906fa748dfff4a4d6b19acf","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            event \u003d self.gerrit.getEvent()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"            failed_jobs \u003d Stream.parse_jenkins_failure("},{"line_number":324,"context_line":"                event, ci_username\u003dself.config.ci_username)"},{"line_number":325,"context_line":"            if not failed_jobs:"},{"line_number":326,"context_line":"                # nothing to see here, lets try the next event"},{"line_number":327,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_eb3cf0e2","side":"PARENT","line":324,"updated":"2020-09-16 06:35:59.000000000","message":"i am referring to this line 324 in my comment above.","commit_id":"9d37c88c8f7d85d8a79349866b35eb4bc0b824f8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"66173cea05e92577a906fa748dfff4a4d6b19acf","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return False"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        username \u003d event[\u0027author\u0027].get(\u0027username\u0027, \u0027\u0027)"},{"line_number":215,"context_line":"        if (username not in [self.config.ci_username, \u0027zuul\u0027]):"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if not (\"Build failed\" in"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0b3844ec","line":215,"range":{"start_line":215,"start_character":55,"end_line":215,"end_character":59},"updated":"2020-09-16 06:35:59.000000000","message":"why the need to explicitly add zuul afaics it was not present before on line 324","commit_id":"3901d2fd938d84562ea23b173aec08644466388f"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"559afc00675a63ae7d3c4a845bb45e2a88d57140","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return False"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        username \u003d event[\u0027author\u0027].get(\u0027username\u0027, \u0027\u0027)"},{"line_number":215,"context_line":"        if (username not in [self.config.ci_username, \u0027zuul\u0027]):"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if not (\"Build failed\" in"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c60123b8","line":215,"range":{"start_line":215,"start_character":55,"end_line":215,"end_character":59},"in_reply_to":"9f560f44_0b3844ec","updated":"2020-09-16 07:01:06.000000000","message":"That is how the original code was implemented, where zuul was hardcoded as a CI user. This allowed the code to work with multiple CI systems.\n\nI personally do not like this approach but changing it would clearly be outside the scope of this change.\n\nThe sole purpose of this change was as a preparatory work for config refactoring, basically removing usage of important constants from config.","commit_id":"3901d2fd938d84562ea23b173aec08644466388f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"aefd46f3b70c6f7812b7ffdbb5e17233ac0ce456","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return False"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        username \u003d event[\u0027author\u0027].get(\u0027username\u0027, \u0027\u0027)"},{"line_number":215,"context_line":"        if (username not in [self.config.ci_username, \u0027zuul\u0027]):"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if not (\"Build failed\" in"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7f3531db","line":215,"range":{"start_line":215,"start_character":55,"end_line":215,"end_character":59},"in_reply_to":"9f560f44_5411345d","updated":"2020-09-16 14:06:02.000000000","message":"ack, thanks for explaining.","commit_id":"3901d2fd938d84562ea23b173aec08644466388f"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"5a634c31daf4b5b128d247feca91aff6b463780c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return False"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        username \u003d event[\u0027author\u0027].get(\u0027username\u0027, \u0027\u0027)"},{"line_number":215,"context_line":"        if (username not in [self.config.ci_username, \u0027zuul\u0027]):"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if not (\"Build failed\" in"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5411345d","line":215,"range":{"start_line":215,"start_character":55,"end_line":215,"end_character":59},"in_reply_to":"9f560f44_54fdb46c","updated":"2020-09-16 14:04:19.000000000","message":"That is not the point. The main idea here is to make this refactoring without changing the code behavior. AFAIK, this does do exactly that as CI_USERNAME is jenkins and the default value of self.ci_username is still jenkins.","commit_id":"3901d2fd938d84562ea23b173aec08644466388f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c98a9fae28241fea1560698c7888848bbec67ce1","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return False"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        username \u003d event[\u0027author\u0027].get(\u0027username\u0027, \u0027\u0027)"},{"line_number":215,"context_line":"        if (username not in [self.config.ci_username, \u0027zuul\u0027]):"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if not (\"Build failed\" in"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ce6da3cd","line":215,"range":{"start_line":215,"start_character":55,"end_line":215,"end_character":59},"in_reply_to":"9f560f44_7f3531db","updated":"2020-09-17 07:03:31.000000000","message":"ok thanks for checking. i am still not 100% clear though. before it was matching username ONLY to config.ci_username. Now you are matching username to both config.ci_username AND zuul.\n\nI was just noticing the pattern. OK lets go then.","commit_id":"3901d2fd938d84562ea23b173aec08644466388f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e2020556bafcd82450c3efb5243c39d6c49b699b","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return False"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        username \u003d event[\u0027author\u0027].get(\u0027username\u0027, \u0027\u0027)"},{"line_number":215,"context_line":"        if (username not in [self.config.ci_username, \u0027zuul\u0027]):"},{"line_number":216,"context_line":"            return False"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if not (\"Build failed\" in"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_54fdb46c","line":215,"range":{"start_line":215,"start_character":55,"end_line":215,"end_character":59},"in_reply_to":"9f560f44_c60123b8","updated":"2020-09-16 13:53:13.000000000","message":"Can we set https://opendev.org/opendev/elastic-recheck/src/branch/master/elastic_recheck/config.py#L76 default value to zuul and then check ?","commit_id":"3901d2fd938d84562ea23b173aec08644466388f"}]}