)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"3c34e8d52682d2ba0f5664d314847903927de08d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update default gerrit namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to latest Gerrit documentation, 2.15.3, refs/for/\u0027branch\u0027"},{"line_number":10,"context_line":"should be used when pushing changes to Gerrit. Change the default"},{"line_number":11,"context_line":"behavior to refs/for/* instead of refs/publish/* which has been"},{"line_number":12,"context_line":"deprecated. This removes a warning from Gerrit remotes running the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_f8036d10","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":67},"updated":"2018-07-22 12:18:38.000000000","message":"\u0027refs/for/\u003cbranch\u003e\u0027 was the old behaviour, \u0027refs/publish/\u003cbranch\u003e\u0027 was supposed to be the new behaviour. At some point I do recall the Gerrit maintainers identifying that it was intended to deprecate the \u0027refs/for/*\u0027 behaviour, but I can\u0027t seem to find that. My understand was this was needed to facilitate \u0027refs/draft/\u003cbranch\u003e\u0027 and other endpoints to push changes to.\n\nSuggest that a question be posed to them before this is merged.","commit_id":"e70940b64bcf80c2a553a3ca337737f9359c363d"},{"author":{"_account_id":28727,"name":"Derek Waldner","email":"derek.waldner.os@gmail.com"},"change_message_id":"bffb67e844842e5e240ddb0eab1b762ed999cfb6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update default gerrit namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to latest Gerrit documentation, 2.15.3, refs/for/\u0027branch\u0027"},{"line_number":10,"context_line":"should be used when pushing changes to Gerrit. Change the default"},{"line_number":11,"context_line":"behavior to refs/for/* instead of refs/publish/* which has been"},{"line_number":12,"context_line":"deprecated. This removes a warning from Gerrit remotes running the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_c4aec8e3","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":67},"in_reply_to":"5f7c97a3_f8036d10","updated":"2018-07-23 01:37:08.000000000","message":"Going strictly off of discussions and source code, \u0027refs/for/*\u0027 is the expected behavior, and \u0027refs/publish/*\u0027 will be removed once tools that rely on it are updated, and they reference git-review specifically in the commit message here, https://github.com/GerritCodeReview/gerrit/commit/732e075ce860df57bcda239c08315e137011ede8#diff-96650d4ee8f5318f8f507b98f9310b0c.\n\nThe message from a gerrit remote that I use that spurred this is here, https://github.com/GerritCodeReview/gerrit/blob/7f1c017b6b559b5dfabf7cad9e38462b9cd87991/javatests/com/google/gerrit/acceptance/git/AbstractPushForReview.java#L2061. I am receiving this warning message with latest gerrit (2.15.?)","commit_id":"e70940b64bcf80c2a553a3ca337737f9359c363d"}],"git_review/cmd.py":[{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"3c34e8d52682d2ba0f5664d314847903927de08d","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"        ref \u003d \"drafts\""},{"line_number":1619,"context_line":"        if options.custom_script:"},{"line_number":1620,"context_line":"            run_custom_script(\"draft\")"},{"line_number":1621,"context_line":"    elif options.compatible:"},{"line_number":1622,"context_line":"        ref \u003d \"publish\""},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    cmd \u003d \"git push %s HEAD:refs/%s/%s\" % (remote, ref, branch)"},{"line_number":1625,"context_line":"    if options.topic is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5bf85b17","line":1622,"range":{"start_line":1621,"start_character":4,"end_line":1622,"end_character":23},"updated":"2018-07-22 12:18:38.000000000","message":"Some people are using the existing behaviour to ensure they can push to older versions of Gerrit, if the maintainers have dropped use of \u0027refs/publish/*\u0027 I believe \u0027refs/for/\u0027 should work for all releases since 2.6 so could just remove this.\n\nBut at the very least, should not change the current behaviour without some kind of heads up to existing users who were told to use this for older releases. See https://git.openstack.org/cgit/openstack-infra/git-review/tree/git-review.1?id\u003de70940b64bcf80c2a553a3ca337737f9359c363d#n70","commit_id":"e70940b64bcf80c2a553a3ca337737f9359c363d"},{"author":{"_account_id":28727,"name":"Derek Waldner","email":"derek.waldner.os@gmail.com"},"change_message_id":"bffb67e844842e5e240ddb0eab1b762ed999cfb6","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"        ref \u003d \"drafts\""},{"line_number":1619,"context_line":"        if options.custom_script:"},{"line_number":1620,"context_line":"            run_custom_script(\"draft\")"},{"line_number":1621,"context_line":"    elif options.compatible:"},{"line_number":1622,"context_line":"        ref \u003d \"publish\""},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    cmd \u003d \"git push %s HEAD:refs/%s/%s\" % (remote, ref, branch)"},{"line_number":1625,"context_line":"    if options.topic is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_89b6a9db","line":1622,"range":{"start_line":1621,"start_character":4,"end_line":1622,"end_character":23},"in_reply_to":"5f7c97a3_5bf85b17","updated":"2018-07-23 01:37:08.000000000","message":"I did find the bug asking for the \u0027compatible\u0027 switch to be added, https://bugs.launchpad.net/git-review/+bug/1005101 which added to my confusion, but it seems the maintainers have decided to not deprecate \u0027refs/for/*\u0027 and actually have decided to use it in favor of \u0027refs/publish/*\u0027\n\nBased on this, I would be in favor of removing the added compatibility option as well because \u0027refs/for\u0027 should work for everything since it was never actually deprecated. I haven\u0027t looked at the specific versions of gerrit that may have started to phase out \u0027refs/for/*\u0027 so those users might get a warning instead.\n\nFound discussion here regarding the topic of deprecating \u0027refs/for/*\u0027, https://groups.google.com/d/topic/repo-discuss/yf3dV8R6opE/discussion.","commit_id":"e70940b64bcf80c2a553a3ca337737f9359c363d"},{"author":{"_account_id":28902,"name":"Han-Wen NIenhuys","email":"hanwen@google.com","username":"hanwen"},"change_message_id":"829c41f757f652c0e8fcb427b3a59d258275b131","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"        ref \u003d \"drafts\""},{"line_number":1619,"context_line":"        if options.custom_script:"},{"line_number":1620,"context_line":"            run_custom_script(\"draft\")"},{"line_number":1621,"context_line":"    elif options.compatible:"},{"line_number":1622,"context_line":"        ref \u003d \"publish\""},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    cmd \u003d \"git push %s HEAD:refs/%s/%s\" % (remote, ref, branch)"},{"line_number":1625,"context_line":"    if options.topic is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_14299e99","line":1622,"range":{"start_line":1621,"start_character":4,"end_line":1622,"end_character":23},"in_reply_to":"5f7c97a3_89b6a9db","updated":"2018-08-13 17:24:40.000000000","message":"from 2.15 on Gerrit has no support for drafts anymore, so it be best to simply drop this entire if block and say\n\n  ref \u003d \"for\"","commit_id":"e70940b64bcf80c2a553a3ca337737f9359c363d"},{"author":{"_account_id":4720,"name":"David Ostrovsky","email":"david@ostrovsky.org","username":"d-ostrovsky"},"change_message_id":"944ea51f7d3e3ef191dab9e0088981ed8eaec65a","unresolved":false,"context_lines":[{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    parser.add_argument(\"--reviewers\", nargs\u003d\"+\","},{"line_number":1401,"context_line":"                        help\u003d\"Add reviewers to uploaded patch sets.\")"},{"line_number":1402,"context_line":"    parser.add_argument(\"-D\", \"--draft\", dest\u003d\"draft\", action\u003d\"store_true\","},{"line_number":1403,"context_line":"                        help\u003d\"Submit review as a draft\")"},{"line_number":1404,"context_line":"    parser.add_argument(\"-c\", \"--compatible\", dest\u003d\"compatible\","},{"line_number":1405,"context_line":"                        action\u003d\"store_true\","},{"line_number":1406,"context_line":"                        help\u003d\"Push change to refs/for/* for compatibility \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fd0a8223","side":"PARENT","line":1403,"range":{"start_line":1402,"start_character":4,"end_line":1403,"end_character":56},"updated":"2018-08-16 12:57:21.000000000","message":"Why was this changed? The commit message only advertized changing publish to for and not mentioned any draft workflow related changes.\n\nWhile it\u0027s correct, that draft workflow was removed started from 2.15 release, refs/drafts/branch is still supported, and would create WIP change or change edit, if change already exists.","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"},{"author":{"_account_id":28902,"name":"Han-Wen NIenhuys","email":"hanwen@google.com","username":"hanwen"},"change_message_id":"921dddd56923ae31ef5df2f5513a7ec27619e4c0","unresolved":false,"context_lines":[{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    parser.add_argument(\"--reviewers\", nargs\u003d\"+\","},{"line_number":1401,"context_line":"                        help\u003d\"Add reviewers to uploaded patch sets.\")"},{"line_number":1402,"context_line":"    parser.add_argument(\"-D\", \"--draft\", dest\u003d\"draft\", action\u003d\"store_true\","},{"line_number":1403,"context_line":"                        help\u003d\"Submit review as a draft\")"},{"line_number":1404,"context_line":"    parser.add_argument(\"-c\", \"--compatible\", dest\u003d\"compatible\","},{"line_number":1405,"context_line":"                        action\u003d\"store_true\","},{"line_number":1406,"context_line":"                        help\u003d\"Push change to refs/for/* for compatibility \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f83b7034","side":"PARENT","line":1403,"range":{"start_line":1402,"start_character":4,"end_line":1403,"end_character":56},"in_reply_to":"3f79a3b5_38424810","updated":"2018-08-16 13:20:18.000000000","message":"more to the point, we can\u0027t remove the drafts fallback in Gerrit until the callers stop using it, so it makes sense to remove it here too.","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"},{"author":{"_account_id":28902,"name":"Han-Wen NIenhuys","email":"hanwen@google.com","username":"hanwen"},"change_message_id":"3ed1b4f897deafcf5c0107e2239dbcee66ae8e9b","unresolved":false,"context_lines":[{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    parser.add_argument(\"--reviewers\", nargs\u003d\"+\","},{"line_number":1401,"context_line":"                        help\u003d\"Add reviewers to uploaded patch sets.\")"},{"line_number":1402,"context_line":"    parser.add_argument(\"-D\", \"--draft\", dest\u003d\"draft\", action\u003d\"store_true\","},{"line_number":1403,"context_line":"                        help\u003d\"Submit review as a draft\")"},{"line_number":1404,"context_line":"    parser.add_argument(\"-c\", \"--compatible\", dest\u003d\"compatible\","},{"line_number":1405,"context_line":"                        action\u003d\"store_true\","},{"line_number":1406,"context_line":"                        help\u003d\"Push change to refs/for/* for compatibility \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_38424810","side":"PARENT","line":1403,"range":{"start_line":1402,"start_character":4,"end_line":1403,"end_character":56},"in_reply_to":"3f79a3b5_fd0a8223","updated":"2018-08-16 13:05:10.000000000","message":"refs/drafts/BRANCH is deprecated today. If there is a need for WIP, private changes, or change edits, those should be implemented as separate options.\n\nIt\u0027s likely that the refs/drafts/ will also be removed in an upcoming gerrit release.","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"},{"author":{"_account_id":4720,"name":"David Ostrovsky","email":"david@ostrovsky.org","username":"d-ostrovsky"},"change_message_id":"944ea51f7d3e3ef191dab9e0088981ed8eaec65a","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"    ref \u003d \"publish\""},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"    if options.draft:"},{"line_number":1618,"context_line":"        ref \u003d \"drafts\""},{"line_number":1619,"context_line":"        if options.custom_script:"},{"line_number":1620,"context_line":"            run_custom_script(\"draft\")"},{"line_number":1621,"context_line":"    elif options.compatible:"},{"line_number":1622,"context_line":"        ref \u003d \"for\""},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    cmd \u003d \"git push %s HEAD:refs/%s/%s\" % (remote, ref, branch)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_58014404","side":"PARENT","line":1621,"range":{"start_line":1617,"start_character":4,"end_line":1621,"end_character":28},"updated":"2018-08-16 12:57:21.000000000","message":"Should be restored, and if at all, should be done in its own change.","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"},{"author":{"_account_id":28727,"name":"Derek Waldner","email":"derek.waldner.os@gmail.com"},"change_message_id":"13b66f9c5a526225ffb57d4999ebb3cd0c2d98dc","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"    ref \u003d \"publish\""},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"    if options.draft:"},{"line_number":1618,"context_line":"        ref \u003d \"drafts\""},{"line_number":1619,"context_line":"        if options.custom_script:"},{"line_number":1620,"context_line":"            run_custom_script(\"draft\")"},{"line_number":1621,"context_line":"    elif options.compatible:"},{"line_number":1622,"context_line":"        ref \u003d \"for\""},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    cmd \u003d \"git push %s HEAD:refs/%s/%s\" % (remote, ref, branch)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_18fe6c6a","side":"PARENT","line":1621,"range":{"start_line":1617,"start_character":4,"end_line":1621,"end_character":28},"in_reply_to":"3f79a3b5_58014404","updated":"2018-08-16 13:24:13.000000000","message":"I agree, it simplifies this commit and keeps my original goal intact.","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0c2adff18ec1805d433b4f33a23561c77135afd8","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"                        action\u003d\"store_true\","},{"line_number":1406,"context_line":"                        help\u003d\"Push change to refs/for/* for compatibility \""},{"line_number":1407,"context_line":"                             \"with Gerrit versions \u003c 2.3. Ignored if \""},{"line_number":1408,"context_line":"                             \"-D/--draft is used.\")"},{"line_number":1409,"context_line":"    parser.add_argument(\"-n\", \"--dry-run\", dest\u003d\"dry\", action\u003d\"store_true\","},{"line_number":1410,"context_line":"                        help\u003d\"Don\u0027t actually submit the branch for review\")"},{"line_number":1411,"context_line":"    parser.add_argument(\"-i\", \"--new-changeid\", dest\u003d\"regenerate\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b54a76a9","side":"PARENT","line":1408,"updated":"2018-08-21 18:27:27.000000000","message":"Agreed, I meant more as a heads up to users who might otherwise be surprised that -c returns a syntax error in the next release. Monty has added it to I249a3a4d0cf378b60bf43ce65d49416879d5517e so that\u0027ll be covered.","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"b640bccce9a538f0373b0bb733966c321c9773ba","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"                        action\u003d\"store_true\","},{"line_number":1406,"context_line":"                        help\u003d\"Push change to refs/for/* for compatibility \""},{"line_number":1407,"context_line":"                             \"with Gerrit versions \u003c 2.3. Ignored if \""},{"line_number":1408,"context_line":"                             \"-D/--draft is used.\")"},{"line_number":1409,"context_line":"    parser.add_argument(\"-n\", \"--dry-run\", dest\u003d\"dry\", action\u003d\"store_true\","},{"line_number":1410,"context_line":"                        help\u003d\"Don\u0027t actually submit the branch for review\")"},{"line_number":1411,"context_line":"    parser.add_argument(\"-i\", \"--new-changeid\", dest\u003d\"regenerate\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_85489087","side":"PARENT","line":1408,"updated":"2018-08-20 15:05:51.000000000","message":"We might want to mention this in release notes at a minimum, since it is basically dropping a feature (even if it\u0027s one for ancient Gerrit releases).","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"},{"author":{"_account_id":28947,"name":"Jonathan Nieder","email":"jrnieder@gmail.com"},"change_message_id":"f5bad123e30de4115a1d93721d1730be442b3f61","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"                        action\u003d\"store_true\","},{"line_number":1406,"context_line":"                        help\u003d\"Push change to refs/for/* for compatibility \""},{"line_number":1407,"context_line":"                             \"with Gerrit versions \u003c 2.3. Ignored if \""},{"line_number":1408,"context_line":"                             \"-D/--draft is used.\")"},{"line_number":1409,"context_line":"    parser.add_argument(\"-n\", \"--dry-run\", dest\u003d\"dry\", action\u003d\"store_true\","},{"line_number":1410,"context_line":"                        help\u003d\"Don\u0027t actually submit the branch for review\")"},{"line_number":1411,"context_line":"    parser.add_argument(\"-i\", \"--new-changeid\", dest\u003d\"regenerate\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3512e60a","side":"PARENT","line":1408,"in_reply_to":"3f79a3b5_85489087","updated":"2018-08-21 18:13:19.000000000","message":"This change makes the --compatible behavior the only behavior, so it should work fine across Gerrit versions (even the ancient ones).","commit_id":"de0d27144e5de4af6289c3d1476c55a3192bea70"}]}
