)]}'
{"git_review/cmd.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:gate","change_message_id":"14bb99f45eef9b792b140717229b7ab1754b83ca","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    rc, out \u003d run_command_status(*cmd, stdin\u003dstdin.encode(\u0027utf-8\u0027))"},{"line_number":181,"context_line":"    if rc:"},{"line_number":182,"context_line":"        return None"},{"line_number":183,"context_line":"    data \u003d dict(l.split(\u0027\u003d\u0027, 1) for l in out.splitlines())"},{"line_number":184,"context_line":"    return data[\u0027username\u0027], data[\u0027password\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6ae9c37e","line":183,"updated":"2020-09-03 14:03:18.000000000","message":"pep8: E741 ambiguous variable name \u0027l\u0027","commit_id":"3a92806e6b4d092587a07de0fa5424178aecece4"}],"git_review/tests/test_git_review.py":[{"author":{"_account_id":1054,"name":"Darragh Bailey","email":"daragh.bailey@gmail.com","username":"dbailey-k"},"change_message_id":"502fdf9eb36878a11c69107e3179983efaca9ec7","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        self._simple_change(\u0027test file modified\u0027, \u0027commit message for bug 456\u0027)"},{"line_number":410,"context_line":"        self._assert_branch_would_be(\u0027master%topic\u003dbug/456\u0027)"},{"line_number":411,"context_line":"        self._assert_branch_would_be(\u0027master\u0027, extra_args\u003d[\u0027-T\u0027])"},{"line_number":412,"context_line":"        self._run_git(\u0027config\u0027, \u0027gitreview.notopic\u0027, \u0027true\u0027)"},{"line_number":413,"context_line":"        self._assert_branch_would_be(\u0027master\u0027)"},{"line_number":414,"context_line":"        self._run_git(\u0027config\u0027, \u0027gitreview.notopic\u0027, \u0027false\u0027)"},{"line_number":415,"context_line":"        self._assert_branch_would_be(\u0027master%topic\u003dbug/456\u0027)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def test_git_review_T_t(self):"},{"line_number":418,"context_line":"        self.assertRaises(Exception, self._run_git_review, \u0027-T\u0027, \u0027-t\u0027, \u0027taz\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_afec7d91","line":415,"range":{"start_line":412,"start_character":8,"end_line":415,"end_character":60},"updated":"2020-02-04 11:34:49.000000000","message":"Should you be verifying that the option `-T` correctly overrides the config setting when set to true? Given this test appears to be focused on the CLI option rather than config options. And similarly should the `-t` correctly override the config option when set to `false` in the test above?\n\nI see there is a ConfigTest class at the top of this file so maybe one of the maintainers can clarify if there is a preference for how the tests are grouped.","commit_id":"9d10f8d5831f3900ecbdc2ab63e27c6d51f3a212"},{"author":{"_account_id":31067,"name":"Mattias Jernberg","email":"mattiasj@axis.com","username":"axis-mattiasj"},"change_message_id":"4a22ce790c1dac2e9fa15d8d59af72a71c1567aa","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        self._simple_change(\u0027test file modified\u0027, \u0027commit message for bug 456\u0027)"},{"line_number":410,"context_line":"        self._assert_branch_would_be(\u0027master%topic\u003dbug/456\u0027)"},{"line_number":411,"context_line":"        self._assert_branch_would_be(\u0027master\u0027, extra_args\u003d[\u0027-T\u0027])"},{"line_number":412,"context_line":"        self._run_git(\u0027config\u0027, \u0027gitreview.notopic\u0027, \u0027true\u0027)"},{"line_number":413,"context_line":"        self._assert_branch_would_be(\u0027master\u0027)"},{"line_number":414,"context_line":"        self._run_git(\u0027config\u0027, \u0027gitreview.notopic\u0027, \u0027false\u0027)"},{"line_number":415,"context_line":"        self._assert_branch_would_be(\u0027master%topic\u003dbug/456\u0027)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def test_git_review_T_t(self):"},{"line_number":418,"context_line":"        self.assertRaises(Exception, self._run_git_review, \u0027-T\u0027, \u0027-t\u0027, \u0027taz\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ca41d539","line":415,"range":{"start_line":412,"start_character":8,"end_line":415,"end_character":60},"in_reply_to":"3fa7e38b_afec7d91","updated":"2020-02-18 09:01:01.000000000","message":"As far as testing combos, yeah (but I think you swapped to logic, when false -T should override, and when true -t should override).\n\nstructure is unclear to me, test_git_review_F below does similar config tests in the same test. So clarification on preferred structure would probably be good.","commit_id":"9d10f8d5831f3900ecbdc2ab63e27c6d51f3a212"},{"author":{"_account_id":31067,"name":"Mattias Jernberg","email":"mattiasj@axis.com","username":"axis-mattiasj"},"change_message_id":"afd73fcd1fe90a0e9748dfa77d70ef87a6b6112f","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        self._simple_change(\u0027test file modified\u0027, \u0027commit message for bug 456\u0027)"},{"line_number":410,"context_line":"        self._assert_branch_would_be(\u0027master%topic\u003dbug/456\u0027)"},{"line_number":411,"context_line":"        self._assert_branch_would_be(\u0027master\u0027, extra_args\u003d[\u0027-T\u0027])"},{"line_number":412,"context_line":"        self._run_git(\u0027config\u0027, \u0027gitreview.notopic\u0027, \u0027true\u0027)"},{"line_number":413,"context_line":"        self._assert_branch_would_be(\u0027master\u0027)"},{"line_number":414,"context_line":"        self._run_git(\u0027config\u0027, \u0027gitreview.notopic\u0027, \u0027false\u0027)"},{"line_number":415,"context_line":"        self._assert_branch_would_be(\u0027master%topic\u003dbug/456\u0027)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def test_git_review_T_t(self):"},{"line_number":418,"context_line":"        self.assertRaises(Exception, self._run_git_review, \u0027-T\u0027, \u0027-t\u0027, \u0027taz\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_25ed3a01","line":415,"range":{"start_line":412,"start_character":8,"end_line":415,"end_character":60},"in_reply_to":"3fa7e38b_ca41d539","updated":"2020-02-18 10:11:20.000000000","message":"Added further tests for combination of options in PS3","commit_id":"9d10f8d5831f3900ecbdc2ab63e27c6d51f3a212"}]}