)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5c61b97cbcc25b9709175053e56feca1ec879573","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    rev: 19.10b0"},{"line_number":6,"context_line":"    hooks:"},{"line_number":7,"context_line":"      - id: black"},{"line_number":8,"context_line":"        language_version: python3"},{"line_number":9,"context_line":"  - repo: https://gitlab.com/pycqa/flake8.git"},{"line_number":10,"context_line":"    rev: 3.7.9"},{"line_number":11,"context_line":"    hooks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_3e65abe2","line":8,"updated":"2020-01-23 18:59:30.000000000","message":"Note that black requires python 3.6 or greater. Are we able to make that assertion here? and if so would that give users a nicer error message if they have older python3?","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"}],"doc/source/conf.py":[{"author":{"_account_id":13807,"name":"Thanh Ha","display_name":"zxiiro","email":"zxiiro@gmail.com","username":"zxiiro"},"change_message_id":"e7b6e2cf8e87fa19107f502d4a08d5cd11654c28","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# All configuration values have a default; values that are commented out"},{"line_number":13,"context_line":"# serve to show the default."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# import sys"},{"line_number":16,"context_line":"# import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# If extensions (or modules to document with autodoc) are in another directory,"},{"line_number":19,"context_line":"# add these directories to sys.path here. If the directory is relative to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_de281786","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":11},"updated":"2020-01-23 18:54:27.000000000","message":"Rather than commenting it out maybe just delete these lines?","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5c61b97cbcc25b9709175053e56feca1ec879573","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# All configuration values have a default; values that are commented out"},{"line_number":13,"context_line":"# serve to show the default."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# import sys"},{"line_number":16,"context_line":"# import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# If extensions (or modules to document with autodoc) are in another directory,"},{"line_number":19,"context_line":"# add these directories to sys.path here. If the directory is relative to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1e58ef22","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":11},"in_reply_to":"3fa7e38b_7e67a3ed","updated":"2020-01-23 18:59:30.000000000","message":"This file is also 99% autogenerated. We might add this to the exclusion list as a result. WIll help keep diffs against sphinx output cleaner.","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"517e26ebc7017430ba81958430a1614ab733e22f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# All configuration values have a default; values that are commented out"},{"line_number":13,"context_line":"# serve to show the default."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# import sys"},{"line_number":16,"context_line":"# import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# If extensions (or modules to document with autodoc) are in another directory,"},{"line_number":19,"context_line":"# add these directories to sys.path here. If the directory is relative to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7e67a3ed","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":11},"in_reply_to":"3fa7e38b_de281786","updated":"2020-01-23 18:56:17.000000000","message":"Because these lines are needed in case you remove comment line 21.  I don\u0027t really mind removing them.","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"}],"git_review/cmd.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"be08384e1fe12f9aa90e9c10a3eb0691be9bc8c2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def __init__(self, *args):"},{"line_number":97,"context_line":"        Exception.__init__(self, *args)"},{"line_number":98,"context_line":"        (self.rc, self.output, self.argv, self.envp) \u003d args"},{"line_number":99,"context_line":"        self.quickmsg \u003d dict("},{"line_number":100,"context_line":"            [(\"argv\", \" \".join(self.argv)), (\"rc\", self.rc), (\"output\", self.output)]"},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def __str__(self):"},{"line_number":104,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8769eff7","line":101,"range":{"start_line":99,"start_character":8,"end_line":101,"end_character":9},"updated":"2020-01-24 09:30:10.000000000","message":"respecting coding style is great, understanding code is better:\n\n self.quickmsg \u003d {\"argv\": ..., \"rc\": ..., \"output\": ...}","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"}],"git_review/tests/check_test_id_hashes.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"91c6ed5458041d7cd6ce5ddaede03ec3af54eab4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    print("},{"line_number":48,"context_line":"        \"Found a collision for test ids hash function: %s and %s\\n\""},{"line_number":49,"context_line":"        \"You should change _hash_test_id function in\""},{"line_number":50,"context_line":"        \" git_review/tests/__init__.py module to fit new set of test ids.\" % collision,"},{"line_number":51,"context_line":"        file\u003dsys.stderr,"},{"line_number":52,"context_line":"    )"},{"line_number":53,"context_line":"    return 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5ea7470a","line":50,"updated":"2020-01-23 19:00:20.000000000","message":"Line too long.","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"}],"pyproject.toml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5c61b97cbcc25b9709175053e56feca1ec879573","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \"setuptools \u003e\u003d 41.4.0\","},{"line_number":5,"context_line":"  \"setuptools_scm \u003e\u003d 3.3.3\","},{"line_number":6,"context_line":"  \"setuptools_scm_git_archive \u003e\u003d 1.1\","},{"line_number":7,"context_line":"  \"wheel \u003e\u003d 0.33.6\","},{"line_number":8,"context_line":"]"},{"line_number":9,"context_line":"build-backend \u003d \"setuptools.build_meta\""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-toml","patch_set":1,"id":"3fa7e38b_1e11cf50","line":7,"updated":"2020-01-23 18:59:30.000000000","message":"Shouldn\u0027t pbr be listed here too?","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"}],"setup.cfg":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5c61b97cbcc25b9709175053e56feca1ec879573","unresolved":false,"context_lines":[{"line_number":46,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,releasenotes,*lib/python*,*egg,build"},{"line_number":47,"context_line":"format \u003d pylint"},{"line_number":48,"context_line":"# E203: https://github.com/python/black/issues/315"},{"line_number":49,"context_line":"ignore \u003d D,E741,W503,W504,H,E501,E203"},{"line_number":50,"context_line":"# D ignores docstrings till we decide not to anymore"},{"line_number":51,"context_line":"# 88 is official black default:"},{"line_number":52,"context_line":"max-line-length \u003d 88"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3fa7e38b_5e3427df","line":49,"range":{"start_line":49,"start_character":26,"end_line":49,"end_character":27},"updated":"2020-01-23 18:59:30.000000000","message":"You aren\u0027t installing hacking anymore so don\u0027t need this right?","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5c61b97cbcc25b9709175053e56feca1ec879573","unresolved":false,"context_lines":[{"line_number":49,"context_line":"ignore \u003d D,E741,W503,W504,H,E501,E203"},{"line_number":50,"context_line":"# D ignores docstrings till we decide not to anymore"},{"line_number":51,"context_line":"# 88 is official black default:"},{"line_number":52,"context_line":"max-line-length \u003d 88"},{"line_number":53,"context_line":"show-source \u003d true"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3fa7e38b_3e3ccbbe","line":52,"updated":"2020-01-23 18:59:30.000000000","message":"Thinking about this, is there any benefit to running pycodestyle checks if using black? Black is going to assert its codestyle instead. One concern is that black will treat this is as suggestion and can go longer if it decides that makes for better code. So you can still end up with failures here from pycodestyle right?\n\npyflakes is probably still worth checking as it looks for semantic issues as well.","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"}],"tox.ini":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5c61b97cbcc25b9709175053e56feca1ec879573","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[testenv:linters]"},{"line_number":27,"context_line":"deps \u003d pre-commit\u003e\u003d1.21.0"},{"line_number":28,"context_line":"commands \u003d pre-commit run -a"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Kept for compatibility with current CI jobs"},{"line_number":31,"context_line":"[testenv:pep8]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_7e9c83bd","line":28,"updated":"2020-01-23 18:59:30.000000000","message":"Can we run flake8 + black directly and install them from pypi? THis will be much more reliable for CI than installing things from github (which is not very reliable at all).","commit_id":"336748f91059813d63ca87e19de5e868f48dfe6d"}]}