)]}'
{"git_review/tests/test_git_review.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c0b9ba0227b5c8f1a11db1e3c45c1b533b73a35a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        self._run_git(\u0027checkout\u0027, \u0027-b\u0027, \u0027test_branch\u0027)"},{"line_number":293,"context_line":"        self._run_git_sub(\u0027init\u0027)"},{"line_number":294,"context_line":"        self._unstaged_change_sub(change_text\u003d\u0027simple message\u0027)"},{"line_number":295,"context_line":"        self._run_git_review()"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_ignore_uncommitted_submodule_changes(self):"},{"line_number":298,"context_line":"        \"\"\"Test message displayed when staged changes are present.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ab178f2c_d2005ae2","line":295,"updated":"2021-07-07 17:53:06.000000000","message":"It\u0027s not clear to me what that would demonstrate. The git commands being run by git-review invocation shouldn\u0027t alter the submodules, but *if* they altered them in the same ways as they alter the superrepo then we wouldn\u0027t detect that by comparing the original and final states, as git-review tries to reset to the original state after the test rebase is performed.\n\nThe goal of this test and the one after it are to confirm that git-review can once again push changes when a dirty submodule is present. If we want to devise checks for whether git-review alters the contents of submodules in some way, we could certainly try to do so, but that would be something we haven\u0027t previously asserted in the testsuite and should be represented by one or more separate tests.","commit_id":"6c3f134ac37969560f56e8c8f44e845d82fcf130"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a8eded113f29b43ad8ef490371a0d11eafbfe345","unresolved":true,"context_lines":[{"line_number":292,"context_line":"        self._run_git(\u0027checkout\u0027, \u0027-b\u0027, \u0027test_branch\u0027)"},{"line_number":293,"context_line":"        self._run_git_sub(\u0027init\u0027)"},{"line_number":294,"context_line":"        self._unstaged_change_sub(change_text\u003d\u0027simple message\u0027)"},{"line_number":295,"context_line":"        self._run_git_review()"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_ignore_uncommitted_submodule_changes(self):"},{"line_number":298,"context_line":"        \"\"\"Test message displayed when staged changes are present.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"2a9b617c_ee068280","line":295,"updated":"2021-07-07 17:00:36.000000000","message":"We should assert the state of the submodule contents hasn\u0027t changed after running git review.","commit_id":"6c3f134ac37969560f56e8c8f44e845d82fcf130"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e7ee0d5f45a9569c99c81aef69e3390c61f48c35","unresolved":true,"context_lines":[{"line_number":292,"context_line":"        self._run_git(\u0027checkout\u0027, \u0027-b\u0027, \u0027test_branch\u0027)"},{"line_number":293,"context_line":"        self._run_git_sub(\u0027init\u0027)"},{"line_number":294,"context_line":"        self._unstaged_change_sub(change_text\u003d\u0027simple message\u0027)"},{"line_number":295,"context_line":"        self._run_git_review()"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_ignore_uncommitted_submodule_changes(self):"},{"line_number":298,"context_line":"        \"\"\"Test message displayed when staged changes are present.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9b09cf52_915c8c31","line":295,"in_reply_to":"2a9b617c_ee068280","updated":"2021-07-07 17:47:56.000000000","message":"Fungi pointed out that this only makes sense when using the autostash feature and the test suite doesn\u0027t currently support that. We can probably get away with git doing the right thing here and if this continues to cause problems for submodule users we can investigate more robust testing.","commit_id":"6c3f134ac37969560f56e8c8f44e845d82fcf130"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a8eded113f29b43ad8ef490371a0d11eafbfe345","unresolved":true,"context_lines":[{"line_number":300,"context_line":"        self._run_git(\u0027checkout\u0027, \u0027-b\u0027, \u0027test_branch\u0027)"},{"line_number":301,"context_line":"        self._run_git_sub(\u0027init\u0027)"},{"line_number":302,"context_line":"        self._uncommitted_change_sub(change_text\u003d\u0027simple message\u0027)"},{"line_number":303,"context_line":"        self._run_git_review()"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def test_rebase_no_remote_branch_msg(self):"},{"line_number":306,"context_line":"        \"\"\"Test message displayed where no remote branch exists.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"885f12e6_4db74e75","line":303,"updated":"2021-07-07 17:00:36.000000000","message":"We should assert the state of the submodule contents hasn\u0027t changed after running git review.","commit_id":"6c3f134ac37969560f56e8c8f44e845d82fcf130"}]}