)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35502,"name":"Tama McGlinn","email":"t.mcglinn@gmail.com","username":"tama"},"change_message_id":"c177446ed8791bb76dfbc3631c3dc943b165aaaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1df76907_d63a85ca","updated":"2022-11-09 11:15:24.000000000","message":"recheck","commit_id":"953ba6f4d58c61e9a96f847e8b2287c9082d573d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"81289d9e5972ffc70fa9e6dcce1e74668ef028d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"24bfb2a9_a529af18","updated":"2022-11-09 11:41:40.000000000","message":"Hallo new contributor, thanks for your submission. The remaining test failures are unrelated to your patch, I\u0027ll try to push a fix for those independently, so you do not have to worry about this.","commit_id":"fc3da480351e07cc5117b80af06fcaccf60fa051"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"26beeb14e8225799960b94ef4ffc8a1d171a1f30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"79965478_b8ea2e2a","updated":"2022-11-09 11:43:20.000000000","message":"I just noticed that you seem to be using your patched version to submit comments with new PSs, so this is inherently tested already, I like that :-)","commit_id":"fc3da480351e07cc5117b80af06fcaccf60fa051"},{"author":{"_account_id":35502,"name":"Tama McGlinn","email":"t.mcglinn@gmail.com","username":"tama"},"change_message_id":"fdc3c8ecadd29efe060c553f7f6aac88ad2138f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"915d1ee5_9be85347","in_reply_to":"79965478_b8ea2e2a","updated":"2022-11-09 14:06:49.000000000","message":"thanks for noticing; I am indeed already using this tool. I did not go looking for unit tests in this repository though; maybe we need to add some? I haven\u0027t even tried out messages with non-alphanumeric characters in them, for example. And documentation, probably?","commit_id":"fc3da480351e07cc5117b80af06fcaccf60fa051"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d690dd8db7bbee937898baf6ebc16aa845523772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d922ba7d_c27245f9","updated":"2022-11-09 13:16:47.000000000","message":"Rebased on top of the CI fix","commit_id":"95f3936edb0accbe65367544dd42eb0a8651e431"},{"author":{"_account_id":35502,"name":"Tama McGlinn","email":"t.mcglinn@gmail.com","username":"tama"},"change_message_id":"3d99fef672032fcc7b12e2f80a6f71c0be90162a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e20fbacd_8e7914a4","updated":"2022-11-10 10:11:36.000000000","message":"recheck","commit_id":"2481ec61c390d10346e17c24d7dbe06a48e8f569"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb577d1f402dc019b38ebaa68ac6a758d4f621c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a38550a3_7078a9a2","updated":"2022-11-23 11:42:34.000000000","message":"Adding testing would be nice, but I don\u0027t think it is required here. Also our test setup needs a major rework anyway in order to be able to run on current distro versions.","commit_id":"52752c85d3ea135693d3c17e855941740aebc9d5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7d37c0a562cdf4fe1334badd3fe3a6f6f86a23f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a3436e77_3a93ee78","updated":"2022-11-16 20:53:19.000000000","message":"Not approving as I think fungi may have hoped for some testing. That said I think we see it working on this change and it is an opt in feature so risk is low.","commit_id":"52752c85d3ea135693d3c17e855941740aebc9d5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ea4ffaf2a7cdb2e67e95f9b499c6d5fb9dff503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"faa1f4a4_1f06a04c","updated":"2022-11-15 13:50:15.000000000","message":"lgtm","commit_id":"52752c85d3ea135693d3c17e855941740aebc9d5"}],"git_review/cmd.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f20acdce65c8f0e0ac278385986624a889739c58","unresolved":true,"context_lines":[{"line_number":1538,"context_line":"                        help\u003d\"Control to whom email notifications are sent,\""},{"line_number":1539,"context_line":"                             \" defaults to ALL.\")"},{"line_number":1540,"context_line":"    parser.add_argument(\"--message\", dest\u003d\"message\","},{"line_number":1541,"context_line":"                        help\u003d\"Message to add to patch revision\")"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"    rebase_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1544,"context_line":"    rebase_group.add_argument(\"-R\", \"--no-rebase\", dest\u003d\"rebase\","}],"source_content_type":"text/x-python","patch_set":5,"id":"be65728f_775670be","line":1541,"updated":"2022-11-09 14:07:15.000000000","message":"Gerrit uses the term \"patch set description\", maybe stick to that?","commit_id":"95f3936edb0accbe65367544dd42eb0a8651e431"},{"author":{"_account_id":35502,"name":"Tama McGlinn","email":"t.mcglinn@gmail.com","username":"tama"},"change_message_id":"3d99fef672032fcc7b12e2f80a6f71c0be90162a","unresolved":false,"context_lines":[{"line_number":1538,"context_line":"                        help\u003d\"Control to whom email notifications are sent,\""},{"line_number":1539,"context_line":"                             \" defaults to ALL.\")"},{"line_number":1540,"context_line":"    parser.add_argument(\"--message\", dest\u003d\"message\","},{"line_number":1541,"context_line":"                        help\u003d\"Message to add to patch revision\")"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"    rebase_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":1544,"context_line":"    rebase_group.add_argument(\"-R\", \"--no-rebase\", dest\u003d\"rebase\","}],"source_content_type":"text/x-python","patch_set":5,"id":"aa819c98_6ff0dde7","line":1541,"in_reply_to":"be65728f_775670be","updated":"2022-11-10 10:11:36.000000000","message":"Done","commit_id":"95f3936edb0accbe65367544dd42eb0a8651e431"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f20acdce65c8f0e0ac278385986624a889739c58","unresolved":true,"context_lines":[{"line_number":1825,"context_line":"        push_options.append(\"notify\u003d%s\" % options.notify)"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"    if options.message is not None:"},{"line_number":1828,"context_line":"        escaped_message \u003d quote_plus(options.message)"},{"line_number":1829,"context_line":"        push_options.append(f\"m\u003d{escaped_message}\")"},{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"    if push_options:"}],"source_content_type":"text/x-python","patch_set":5,"id":"14003818_ee8d16d3","line":1828,"updated":"2022-11-09 14:07:15.000000000","message":"From the comment in https://review.opendev.org/Documentation/user-upload.html#patch_set_description I\u0027m not sure whether this quoting will be sufficient. On the other hand maybe we don\u0027t need to care about people wanting weird characters in their message?","commit_id":"95f3936edb0accbe65367544dd42eb0a8651e431"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb577d1f402dc019b38ebaa68ac6a758d4f621c7","unresolved":false,"context_lines":[{"line_number":1825,"context_line":"        push_options.append(\"notify\u003d%s\" % options.notify)"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"    if options.message is not None:"},{"line_number":1828,"context_line":"        escaped_message \u003d quote_plus(options.message)"},{"line_number":1829,"context_line":"        push_options.append(f\"m\u003d{escaped_message}\")"},{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"    if push_options:"}],"source_content_type":"text/x-python","patch_set":5,"id":"49ab5278_bf59099a","line":1828,"in_reply_to":"12fd295d_15c32078","updated":"2022-11-23 11:42:34.000000000","message":"I did some more testing, unescaped characters like \"~\" mentioned in the doc above will trigger an error:\n\ngit-review --message \"from ~here to /there\"\nfatal: invalid refspec \u0027HEAD:refs/for/master%topic\u003dfoobar,m\u003dfrom+~here+to+%2Fthere\u0027\n\nI think that works good enough.","commit_id":"95f3936edb0accbe65367544dd42eb0a8651e431"},{"author":{"_account_id":35502,"name":"Tama McGlinn","email":"t.mcglinn@gmail.com","username":"tama"},"change_message_id":"3d99fef672032fcc7b12e2f80a6f71c0be90162a","unresolved":true,"context_lines":[{"line_number":1825,"context_line":"        push_options.append(\"notify\u003d%s\" % options.notify)"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"    if options.message is not None:"},{"line_number":1828,"context_line":"        escaped_message \u003d quote_plus(options.message)"},{"line_number":1829,"context_line":"        push_options.append(f\"m\u003d{escaped_message}\")"},{"line_number":1830,"context_line":""},{"line_number":1831,"context_line":"    if push_options:"}],"source_content_type":"text/x-python","patch_set":5,"id":"12fd295d_15c32078","line":1828,"in_reply_to":"14003818_ee8d16d3","updated":"2022-11-10 10:11:36.000000000","message":"I believe it should be sufficient. I have used :.()!? and double quotes with: `git review --message \u0027NB: changed to \"patch set description\" as requested (by Dr. Jens)!?\u0027` (using single quotes necessary because otherwise bash dives in on the exclamation mark or the question mark and does weird things before even reaching cmd.py)","commit_id":"95f3936edb0accbe65367544dd42eb0a8651e431"}]}