)]}'
{"git_review/cmd.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"04ba4ecd2194a7fe67645e4e8d85ea3b9e3575ed","unresolved":true,"context_lines":[{"line_number":709,"context_line":"    # Reformat output to match ssh output"},{"line_number":710,"context_line":"    try:"},{"line_number":711,"context_line":"        for review in reviews:"},{"line_number":712,"context_line":"            review[\"number\"] \u003d str(review.pop(\"_number\"))"},{"line_number":713,"context_line":"            if \"revisions\" not in review:"},{"line_number":714,"context_line":"                continue"},{"line_number":715,"context_line":"            patchsets \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"6fe0c0bf_e29731bf","line":712,"updated":"2025-03-31 22:22:18.000000000","message":"Here we replace \"_number\" with \"number\" in the review info. In this change we try to use \"_number\" when fetching reviews but I think it should be \"number\" due to this line. Is that something that differs with ssh? We may need to have ssh normalize things too?","commit_id":"c16582058b83f6e060d8170b92f4cf96655c2279"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1061b112238135b3d5aee9018d4654489acc2a6f","unresolved":true,"context_lines":[{"line_number":709,"context_line":"    # Reformat output to match ssh output"},{"line_number":710,"context_line":"    try:"},{"line_number":711,"context_line":"        for review in reviews:"},{"line_number":712,"context_line":"            review[\"number\"] \u003d str(review.pop(\"_number\"))"},{"line_number":713,"context_line":"            if \"revisions\" not in review:"},{"line_number":714,"context_line":"                continue"},{"line_number":715,"context_line":"            patchsets \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"4bdbdcb6_ae9cd67e","line":712,"in_reply_to":"6fe0c0bf_e29731bf","updated":"2025-03-31 22:49:59.000000000","message":"Hashed out below at the usage site.","commit_id":"c16582058b83f6e060d8170b92f4cf96655c2279"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"04ba4ecd2194a7fe67645e4e8d85ea3b9e3575ed","unresolved":true,"context_lines":[{"line_number":1317,"context_line":"        raise ReviewNotFound(review)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    change_number \u003d review_info.get(\u0027number\u0027,"},{"line_number":1320,"context_line":"                                    review_info.get(\u0027_number\u0027, review))"},{"line_number":1321,"context_line":"    remote_branch \u003d review_info[\u0027branch\u0027]"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    if patchset_number is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"342057a1_35b5029f","line":1320,"updated":"2025-03-31 22:22:18.000000000","message":"It should be noted that change numbers are no longer unique in gerrit but they are unique per project so this should be a safe collision free method.\n\nAlso see comment about about using the \"_number\" key.","commit_id":"c16582058b83f6e060d8170b92f4cf96655c2279"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1061b112238135b3d5aee9018d4654489acc2a6f","unresolved":true,"context_lines":[{"line_number":1317,"context_line":"        raise ReviewNotFound(review)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    change_number \u003d review_info.get(\u0027number\u0027,"},{"line_number":1320,"context_line":"                                    review_info.get(\u0027_number\u0027, review))"},{"line_number":1321,"context_line":"    remote_branch \u003d review_info[\u0027branch\u0027]"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    if patchset_number is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"acc5f9ab_96ced51c","line":1320,"in_reply_to":"3199400a_64e1c7be","updated":"2025-03-31 22:49:59.000000000","message":"Got it.  Yeah, I think number should be sufficient.  I was probably just being paranoid and not trusting that we would always convert _number to number.","commit_id":"c16582058b83f6e060d8170b92f4cf96655c2279"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"337bac3b86e81ea34ba85dade2091776f8bd59e8","unresolved":true,"context_lines":[{"line_number":1317,"context_line":"        raise ReviewNotFound(review)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    change_number \u003d review_info.get(\u0027number\u0027,"},{"line_number":1320,"context_line":"                                    review_info.get(\u0027_number\u0027, review))"},{"line_number":1321,"context_line":"    remote_branch \u003d review_info[\u0027branch\u0027]"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    if patchset_number is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a013373a_680b546a","line":1320,"in_reply_to":"342057a1_35b5029f","updated":"2025-03-31 22:25:54.000000000","message":"Is this the place you\u0027re talking about in your other comment?  Because here, we try `number` first and then fall back to `_number`.","commit_id":"c16582058b83f6e060d8170b92f4cf96655c2279"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c48e999eaf70bdc80b575ee07f8815bc15d321ce","unresolved":true,"context_lines":[{"line_number":1317,"context_line":"        raise ReviewNotFound(review)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    change_number \u003d review_info.get(\u0027number\u0027,"},{"line_number":1320,"context_line":"                                    review_info.get(\u0027_number\u0027, review))"},{"line_number":1321,"context_line":"    remote_branch \u003d review_info[\u0027branch\u0027]"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"    if patchset_number is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3199400a_64e1c7be","line":1320,"in_reply_to":"a013373a_680b546a","updated":"2025-03-31 22:44:38.000000000","message":"Yes. I guess I\u0027m confused as to why we have to check both if we\u0027re popping \"_number\" out. But maybe ssh gives us _number and we don\u0027t pop it off like we do for http. That sprobably fine to clean up in another change just confusing.","commit_id":"c16582058b83f6e060d8170b92f4cf96655c2279"}]}