)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"af40f2fa8c4a69bc844c6cd26954fca5e090d824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7a542328_b8e9a0fa","updated":"2024-12-03 17:59:50.000000000","message":"Is there any situation where GIT_SSH_COMMAND/GIT_SSH are valid for performing git actions over ssh to gerrit but not valid for the gerrit query over ssh that this change modifies? I\u0027m worried that we might break a different set of users that don\u0027t want this behavior when they have GIT_SSH_COMMAND/GIT_SSH set, but I\u0027m not sure if that makes any sense.\n\nIf we are concerned about that then one solution may be to look for GIT_REVIEW_SSH_COMMAND and users of GIT_SSH_COMMAND that need gerrit queries to use the same command can set this other var and those that don\u0027t can set one or the other.","commit_id":"a0c8c56376a835a749f7c4526b2335a58f14a705"},{"author":{"_account_id":39208,"name":"Siddharth VP","display_name":"Siddharth VP","email":"siddharthvp@gmail.com","username":"siddharthvp"},"change_message_id":"fc1ae55c6d1bfd357e5a98ea2d624550028a92e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c32ef9c_c9d13788","updated":"2026-06-14 05:08:41.000000000","message":"We should also support `core.sshCommand` from git config. The environment variable gets precedence if both are defined.","commit_id":"a0c8c56376a835a749f7c4526b2335a58f14a705"},{"author":{"_account_id":37519,"name":"Jingyuan Liang","email":"jingyuanliang@google.com","username":"jingyuanliang"},"change_message_id":"f93e73033c8dec494a21dcc687959319a3486f1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"44bd67e6_2b557a82","in_reply_to":"7a542328_b8e9a0fa","updated":"2024-12-04 11:12:21.000000000","message":"I think this concern, valid or not, also applies to the original https://review.opendev.org/c/opendev/git-review/+/890043. So.. @dziewonski@fastmail.fm, thoughts?","commit_id":"a0c8c56376a835a749f7c4526b2335a58f14a705"}],"git_review/cmd.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"51b02043981cc31068b87a496593e57a84f68fcc","unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    ssh_command \u003d os.environ.get(\"GIT_SSH_COMMAND\")"},{"line_number":753,"context_line":"    if ssh_command:"},{"line_number":754,"context_line":"        ssh_command_args \u003d shlex.split(ssh_command)"},{"line_number":755,"context_line":"        output \u003d run_command_exc("},{"line_number":756,"context_line":"            exception, *ssh_command_args, \"-x\" + port_data, userhost,"},{"line_number":757,"context_line":"            \"gerrit\", \"query\","}],"source_content_type":"text/x-python","patch_set":2,"id":"fafa4325_adb414f4","line":754,"updated":"2024-11-12 14:03:19.000000000","message":"Nit: You could make ssh_command_args default to [os.environ.get(\"GIT_SSH\", \"ssh\")] rather than repeating nearly identical run_command_exc() calls.","commit_id":"f8a4fea3c09bca1fee803b1b602c1e4a3f1e06ee"},{"author":{"_account_id":37476,"name":"Suzan Song","display_name":"Suzan","email":"cool_watermelon@u.circlecat.org","username":"ssong"},"change_message_id":"d5cac4bebea4e2940bf370c4b4ec03768a80ef65","unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    ssh_command \u003d os.environ.get(\"GIT_SSH_COMMAND\")"},{"line_number":753,"context_line":"    if ssh_command:"},{"line_number":754,"context_line":"        ssh_command_args \u003d shlex.split(ssh_command)"},{"line_number":755,"context_line":"        output \u003d run_command_exc("},{"line_number":756,"context_line":"            exception, *ssh_command_args, \"-x\" + port_data, userhost,"},{"line_number":757,"context_line":"            \"gerrit\", \"query\","}],"source_content_type":"text/x-python","patch_set":2,"id":"db0c6e08_1d7967fb","line":754,"in_reply_to":"fafa4325_adb414f4","updated":"2024-11-13 03:09:37.000000000","message":"Thanks for the comment. I\u0027m new to this project. I guess I should commit another CL to add release note?","commit_id":"f8a4fea3c09bca1fee803b1b602c1e4a3f1e06ee"},{"author":{"_account_id":37519,"name":"Jingyuan Liang","email":"jingyuanliang@google.com","username":"jingyuanliang"},"change_message_id":"86fa08c0d97a3b17bca81f18742cc491de07988c","unresolved":true,"context_lines":[{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    if VERBOSE:"},{"line_number":750,"context_line":"        print(\"Query gerrit %s %s\" % (remote_url, query))"},{"line_number":751,"context_line":"    ssh_command_args \u003d shlex.split(os.environ.get(\u0027GIT_SSH_COMMAND\u0027,"},{"line_number":752,"context_line":"                                   os.environ.get(\u0027GIT_SSH\u0027, \u0027ssh\u0027)))"},{"line_number":753,"context_line":"    output \u003d run_command_exc("},{"line_number":754,"context_line":"        exception, *ssh_command_args, \"-x\" + port_data, userhost,"}],"source_content_type":"text/x-python","patch_set":5,"id":"8a6e97a0_bbd1baa5","line":751,"range":{"start_line":751,"start_character":29,"end_line":751,"end_character":34},"updated":"2024-11-28 06:30:12.000000000","message":"Hmm this doesn\u0027t match git\u0027s behavior when GIT_SSH contains spaces:\n\n```\n[hi on] jingyuanliang@jingyuanliang:/tmp/t51311$ echo $\u0027#!/bin/sh\\necho wrapped\u003e\u00262\\nexec ssh \"$@\"\u0027 \u003e\"ssh wrapper\"\n[hi on] jingyuanliang@jingyuanliang:/tmp/t51311$ chmod +x ssh\\ wrapper \n[hi on] jingyuanliang@jingyuanliang:/tmp/t51311$ GIT_SSH\u003d\"$(pwd)/ssh wrapper\" git clone ssh://git@github.com/kubernetes/kubernetes.git\nCloning into \u0027kubernetes\u0027...\nwrapped\nremote: Enumerating objects: 1593104, done.\nremote: Counting objects: 100% (27/27), done.\nremote: Compressing objects: 100% (23/23), done.\nremote: Total 1593104 (delta 8), reused 16 (delta 4), pack-reused 1593077 (from 1)\nReceiving objects: 100% (1593104/1593104), 1.05 GiB | 48.63 MiB/s, done.\nResolving deltas: 100% (1166501/1166501), done.\nUpdating files: 100% (26242/26242), done.\n[hi on] jingyuanliang@jingyuanliang:/tmp/t51311$ \n```","commit_id":"e607e51e1750764ed33440adb75f50d5b39523fd"},{"author":{"_account_id":37476,"name":"Suzan Song","display_name":"Suzan","email":"cool_watermelon@u.circlecat.org","username":"ssong"},"change_message_id":"9c29c57001931465fd2f3720d4a5c7ebf5e8efd1","unresolved":false,"context_lines":[{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    if VERBOSE:"},{"line_number":750,"context_line":"        print(\"Query gerrit %s %s\" % (remote_url, query))"},{"line_number":751,"context_line":"    ssh_command_args \u003d shlex.split(os.environ.get(\u0027GIT_SSH_COMMAND\u0027,"},{"line_number":752,"context_line":"                                   os.environ.get(\u0027GIT_SSH\u0027, \u0027ssh\u0027)))"},{"line_number":753,"context_line":"    output \u003d run_command_exc("},{"line_number":754,"context_line":"        exception, *ssh_command_args, \"-x\" + port_data, userhost,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a4e9b565_f5d5f243","line":751,"range":{"start_line":751,"start_character":29,"end_line":751,"end_character":34},"in_reply_to":"8a6e97a0_bbd1baa5","updated":"2024-11-29 07:31:58.000000000","message":"Done","commit_id":"e607e51e1750764ed33440adb75f50d5b39523fd"}]}