)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c5213990cbcedc04d9673cc0d6039d93571e1364","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-08-31 14:09:32 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add pyproject.toml for modern build compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds pyproject.toml to declare build dependencies (pbr\u003e\u003d6.0.0)"},{"line_number":10,"context_line":"which fixes ModuleNotFoundError with setuptools.extern.tomli on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc56bde_fad068ea","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":49},"updated":"2026-08-31 21:25:59.000000000","message":"As a nit I believe that the existing setup.py + setup.cfg + pbr + setuptools configuration is compatible with modern python build tools.\n\nThis is less about compatibility and about making things more reliable (since you can declare build depends).","commit_id":"ff14a33ee0c615cb9aa224607d6afe1a7241289e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c5213990cbcedc04d9673cc0d6039d93571e1364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c086c86_d140b5c9","updated":"2026-08-31 21:25:59.000000000","message":"Glean is still installed on platforms with older python. The CI for glean does cover some of these (like centos 9 python3.9 and ubuntu focal python3.8) so we should get some indication if this creates problems for older python. But I want to call out that for some projects continuing to use the old tooling that new tooling is backward compatible with may remain the correct course of action.\n\nIn this case the primary concern I have is that stephenfin has discussed dropping support for pyproject.toml in PBR on old platforms as figuring out toml support among other things is a much bigger headache there.","commit_id":"ff14a33ee0c615cb9aa224607d6afe1a7241289e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c4bcb101c70f0d50c0094f722b22f6faee0e42f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7d4a4a4_b2791968","updated":"2026-08-31 21:33:19.000000000","message":"May not actually be needed. Rechecking to see if diskimage-builder is still broken or not.","commit_id":"ff14a33ee0c615cb9aa224607d6afe1a7241289e"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"68d9db4fca71bbcf510b34958413243a1eddf2fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15e06399_0cd6cb96","updated":"2026-08-31 21:19:34.000000000","message":"lgtm for some definition of g. Matches similar things I have in other pbr-based projects I hack on.","commit_id":"ff14a33ee0c615cb9aa224607d6afe1a7241289e"}],"pyproject.toml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"68d9db4fca71bbcf510b34958413243a1eddf2fc","unresolved":true,"context_lines":[{"line_number":8,"context_line":"[project]"},{"line_number":9,"context_line":"name \u003d \"glean\""},{"line_number":10,"context_line":"license \u003d {text \u003d \"Apache-2.0\"}"},{"line_number":11,"context_line":"dynamic \u003d [\"version\", \"description\", \"readme\", \"authors\", \"classifiers\", \"dependencies\", \"entry-points\"]"}],"source_content_type":"text/x-toml","patch_set":1,"id":"03f322e1_d6e3ed07","line":11,"updated":"2026-08-31 21:19:34.000000000","message":"I \"love\" that we have to declare the dynamic fields.","commit_id":"ff14a33ee0c615cb9aa224607d6afe1a7241289e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c5213990cbcedc04d9673cc0d6039d93571e1364","unresolved":true,"context_lines":[{"line_number":8,"context_line":"[project]"},{"line_number":9,"context_line":"name \u003d \"glean\""},{"line_number":10,"context_line":"license \u003d {text \u003d \"Apache-2.0\"}"},{"line_number":11,"context_line":"dynamic \u003d [\"version\", \"description\", \"readme\", \"authors\", \"classifiers\", \"dependencies\", \"entry-points\"]"}],"source_content_type":"text/x-toml","patch_set":1,"id":"68e1699e_016eb3c1","line":11,"in_reply_to":"03f322e1_d6e3ed07","updated":"2026-08-31 21:25:59.000000000","message":"Do we need to? The PBR documentation does not document that and I tried to capture what I found to actually be necessary during experimentation when that stuff got documented in PBR. I guess things may have changed.","commit_id":"ff14a33ee0c615cb9aa224607d6afe1a7241289e"}]}
