)]}'
{"glean/cmd.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c62a8fce624fb36e74580299e2ea59b0b8e67171","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                            \"IPV6INIT\u003dyes\","},{"line_number":113,"context_line":"                            \"IPV6_AUTOCONF\u003dyes\","},{"line_number":114,"context_line":"                            \"IPV6_DEFROUTE\u003dyes\","},{"line_number":115,"context_line":"                            \"IPV6_FAILURE_FATAL\u003dno\"])"},{"line_number":116,"context_line":"        footer \u003d \"\\n\".join([\"ONBOOT\u003dyes\","},{"line_number":117,"context_line":"                            \"NM_CONTROLLED\u003d%s\" %"},{"line_number":118,"context_line":"                            (\"yes\" if args.use_nm else \"no\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8cd18f5a","line":115,"updated":"2019-10-04 15:42:23.000000000","message":"I think we only want to set these flags if ipv6 is configured in this manner according to the cloud config. See lines 376 and 377 for the networkd version of this.","commit_id":"55582658b9ded709a47b73790a2df9b91580765b"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"a13ff3060d070f47471ec95805e61bb617d3cd68","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                            \"IPV6INIT\u003dyes\","},{"line_number":113,"context_line":"                            \"IPV6_AUTOCONF\u003dyes\","},{"line_number":114,"context_line":"                            \"IPV6_DEFROUTE\u003dyes\","},{"line_number":115,"context_line":"                            \"IPV6_FAILURE_FATAL\u003dno\"])"},{"line_number":116,"context_line":"        footer \u003d \"\\n\".join([\"ONBOOT\u003dyes\","},{"line_number":117,"context_line":"                            \"NM_CONTROLLED\u003d%s\" %"},{"line_number":118,"context_line":"                            (\"yes\" if args.use_nm else \"no\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6cdf733a","line":115,"in_reply_to":"3fa7e38b_8cd18f5a","updated":"2019-10-04 15:46:20.000000000","message":"Shouldn\u0027t we always configure ipv6? I think NetworkManager does the right thing, even when ipv6 is not available, e.g. it just set linklocal addresses.","commit_id":"55582658b9ded709a47b73790a2df9b91580765b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f34046bb4b07d49d2ac3c620fac4d03e5550bedd","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    # Sort the interfaces by id so that we\u0027ll have consistent output order"},{"line_number":263,"context_line":"    for iname, interface in sorted("},{"line_number":264,"context_line":"            interfaces.items(), key\u003dlambda x: x[1][\u0027id\u0027]):"},{"line_number":265,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv6_dhcp\u0027:"},{"line_number":266,"context_line":"            continue"},{"line_number":267,"context_line":"        # sys_interfaces is pruned by --interface; if one of the"},{"line_number":268,"context_line":"        # raw_macs (or, *the* MAC for single interfaces) does not"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_efc35556","line":265,"updated":"2019-10-04 16:30:52.000000000","message":"Based on the code around lines 357-398 this isn\u0027t a valid type.","commit_id":"91b8045cfca0433c307828709633726a8d698ce6"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"ac15300d8df571dc1c6cdcfa4a5c99be20aeab5d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    # Sort the interfaces by id so that we\u0027ll have consistent output order"},{"line_number":263,"context_line":"    for iname, interface in sorted("},{"line_number":264,"context_line":"            interfaces.items(), key\u003dlambda x: x[1][\u0027id\u0027]):"},{"line_number":265,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv6_dhcp\u0027:"},{"line_number":266,"context_line":"            continue"},{"line_number":267,"context_line":"        # sys_interfaces is pruned by --interface; if one of the"},{"line_number":268,"context_line":"        # raw_macs (or, *the* MAC for single interfaces) does not"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_af7b1df2","line":265,"in_reply_to":"3fa7e38b_efc35556","updated":"2019-10-04 16:39:16.000000000","message":"alright, then let\u0027s keep the condition","commit_id":"91b8045cfca0433c307828709633726a8d698ce6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f34046bb4b07d49d2ac3c620fac4d03e5550bedd","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv4\u0027:"},{"line_number":301,"context_line":"            files_to_write.update("},{"line_number":302,"context_line":"                _write_rh_interface(interface_name, interface, args))"},{"line_number":303,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv6\u0027:"},{"line_number":304,"context_line":"            files_to_write[get_rh_interface_filename(interface_name)].append("},{"line_number":305,"context_line":"                \"\\n\" + \"\\n\".join(["},{"line_number":306,"context_line":"                    \"IPV6INIT\u003dyes\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8f898127","line":303,"updated":"2019-10-04 16:30:52.000000000","message":"Checking against the types on the lines below (as per comment above) I think type ipv6 isn\u0027t the type for stateless config. Instead it should be ipv6_slaac or ipv6_dhcpv6-stateless. Type ipv6 is likely the static interface type.","commit_id":"91b8045cfca0433c307828709633726a8d698ce6"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"ac15300d8df571dc1c6cdcfa4a5c99be20aeab5d","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv4\u0027:"},{"line_number":301,"context_line":"            files_to_write.update("},{"line_number":302,"context_line":"                _write_rh_interface(interface_name, interface, args))"},{"line_number":303,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv6\u0027:"},{"line_number":304,"context_line":"            files_to_write[get_rh_interface_filename(interface_name)].append("},{"line_number":305,"context_line":"                \"\\n\" + \"\\n\".join(["},{"line_number":306,"context_line":"                    \"IPV6INIT\u003dyes\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4f82a9ca","line":303,"in_reply_to":"3fa7e38b_8f898127","updated":"2019-10-04 16:39:16.000000000","message":"Done","commit_id":"91b8045cfca0433c307828709633726a8d698ce6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e148d2ae51e183befbebd52bb7025f2aaefe09f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                _write_rh_interface(interface_name, interface, args))"},{"line_number":303,"context_line":"        if interface[\u0027type\u0027] in (\"ipv6_slaac\", \"ipv6_dhcpv6_stateful\"):"},{"line_number":304,"context_line":"            files_to_write[get_rh_interface_filename("},{"line_number":305,"context_line":"                interface_name, distro)].append("},{"line_number":306,"context_line":"                    \"\\n\" + \"\\n\".join(["},{"line_number":307,"context_line":"                        \"IPV6INIT\u003dyes\","},{"line_number":308,"context_line":"                        \"IPV6_AUTOCONF\u003dyes\","}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b627d412","line":305,"range":{"start_line":305,"start_character":32,"end_line":305,"end_character":38},"updated":"2019-10-07 22:50:15.000000000","message":"This needs to be args.distro. This is why the ci jobs were failing.","commit_id":"21dbb27f2f3e8045038e407be51eebaafb49b76a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"633b1a3e78d88da061714735547acc163d7136ad","unresolved":false,"context_lines":[{"line_number":1335,"context_line":"            if any(filter(lambda iface: \u0027ipv6\u0027 in iface[\u0027type\u0027], interfaces)):"},{"line_number":1336,"context_line":"                of.write(\"\\n\" + \"\\n\".join(["},{"line_number":1337,"context_line":"                    \"NETWORKING_IPV6\u003dyes\","},{"line_number":1338,"context_line":"                    \"IPV6_AUTOCONF\u003dyes\"]))"},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"def write_ssh_keys(args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_f6f22c06","line":1338,"updated":"2019-10-07 22:30:17.000000000","message":"Maybe add this new block to line 1065 ish (with a check for is not suse). Then we don\u0027t have red hat handling code all over the place.\n\nAlso Is the network file a default if things are not specified otherwise in interface specific files? It would be good to understand why we need to set ipv6 and autoconf to true if we explicitly do it per interface where necessary.","commit_id":"21dbb27f2f3e8045038e407be51eebaafb49b76a"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"41219dc08106f67215b838cf6b67e1aa2f76128f","unresolved":false,"context_lines":[{"line_number":1335,"context_line":"            if any(filter(lambda iface: \u0027ipv6\u0027 in iface[\u0027type\u0027], interfaces)):"},{"line_number":1336,"context_line":"                of.write(\"\\n\" + \"\\n\".join(["},{"line_number":1337,"context_line":"                    \"NETWORKING_IPV6\u003dyes\","},{"line_number":1338,"context_line":"                    \"IPV6_AUTOCONF\u003dyes\"]))"},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"def write_ssh_keys(args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b6035442","line":1338,"in_reply_to":"3fa7e38b_561780a4","updated":"2019-10-07 23:00:50.000000000","message":"Arg, actually IPV6_AUTOCONF is set to no by default. Not sure it matters though.","commit_id":"21dbb27f2f3e8045038e407be51eebaafb49b76a"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"3843d0f8aaf087395724f1b7dc2346aec36c126d","unresolved":false,"context_lines":[{"line_number":1335,"context_line":"            if any(filter(lambda iface: \u0027ipv6\u0027 in iface[\u0027type\u0027], interfaces)):"},{"line_number":1336,"context_line":"                of.write(\"\\n\" + \"\\n\".join(["},{"line_number":1337,"context_line":"                    \"NETWORKING_IPV6\u003dyes\","},{"line_number":1338,"context_line":"                    \"IPV6_AUTOCONF\u003dyes\"]))"},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"def write_ssh_keys(args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_561780a4","line":1338,"in_reply_to":"3fa7e38b_f6f22c06","updated":"2019-10-07 22:49:52.000000000","message":"Next PS moves the block to line 1065.\n\nI don\u0027t know the precedence of network file and interface file, this is just a copy of what i found in cloud-init (which seems to work as expected for ipv6 on RedHat system): https://github.com/cloud-init/cloud-init/blob/f80f7f0d82eaf05e68419c7ac87bf5d4c934b796/cloudinit/net/sysconfig.py#L721","commit_id":"21dbb27f2f3e8045038e407be51eebaafb49b76a"},{"author":{"_account_id":20754,"name":"Donny Davis","email":"donny@fortnebula.com","username":"donnydavis"},"change_message_id":"2b3a41584b0beaee2514ec88ed497cfcb5d8c7ad","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv4\u0027:"},{"line_number":301,"context_line":"            files_to_write.update("},{"line_number":302,"context_line":"                _write_rh_interface(interface_name, interface, args))"},{"line_number":303,"context_line":"        if interface[\u0027type\u0027] in (\"ipv6_slaac\", \"ipv6_dhcpv6_stateful\"):"},{"line_number":304,"context_line":"            files_to_write[get_rh_interface_filename("},{"line_number":305,"context_line":"                interface_name, args.distro)].append("},{"line_number":306,"context_line":"                    \"\\n\" + \"\\n\".join(["}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b66cb436","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":71},"updated":"2019-10-07 22:54:49.000000000","message":"Does this also work for dhcpv6_stateless?","commit_id":"c52aab135318c0d25e447b287a4574e155bd1633"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"246f6e97a284065e6725ce0979903c5f384a5529","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"        if not _is_suse(args.distro):"},{"line_number":1067,"context_line":"            # Ensure the network file is similar to the one generated by"},{"line_number":1068,"context_line":"            # cloudinit"},{"line_number":1069,"context_line":"            with open(\"/etc/sysconfig/network\", \"w\") as of:"},{"line_number":1070,"context_line":"                of.write(\"\\n\".join([\"NETWORKING\u003dyes\","},{"line_number":1071,"context_line":"                                    \"NOZEROCONF\u003dyes\","},{"line_number":1072,"context_line":"                                    \"DEVTIMEOUT\u003d10\"]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_d9c0837f","line":1069,"updated":"2019-10-07 23:53:01.000000000","message":"Reading docs this file should also contain the hostname of the host.\n\n  HOSTNAME\u003d$fqdn\n\nI think we should add that in.","commit_id":"f31afea9789e8acc820806b22dcc51f6acbdfd81"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"c7ee7a8984bed43a6f45521f926abfa354bd2166","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"        if not _is_suse(args.distro):"},{"line_number":1067,"context_line":"            # Ensure the network file is similar to the one generated by"},{"line_number":1068,"context_line":"            # cloudinit"},{"line_number":1069,"context_line":"            with open(\"/etc/sysconfig/network\", \"w\") as of:"},{"line_number":1070,"context_line":"                of.write(\"\\n\".join([\"NETWORKING\u003dyes\","},{"line_number":1071,"context_line":"                                    \"NOZEROCONF\u003dyes\","},{"line_number":1072,"context_line":"                                    \"DEVTIMEOUT\u003d10\"]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_4b3a7298","line":1069,"in_reply_to":"3fa7e38b_d9c0837f","updated":"2019-10-08 13:06:46.000000000","message":"fwiw cloud-init doesn\u0027t set that configuration. how would you get the hostname here?","commit_id":"f31afea9789e8acc820806b22dcc51f6acbdfd81"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"246f6e97a284065e6725ce0979903c5f384a5529","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                    filter(lambda iface: \u0027ipv6\u0027 in iface[\u0027type\u0027], interfaces)"},{"line_number":1077,"context_line":"                        ):"},{"line_number":1078,"context_line":"                    of.write(\"\\n\" + \"\\n\".join(["},{"line_number":1079,"context_line":"                        \"NETWORKING_IPV6\u003dyes\","},{"line_number":1080,"context_line":"                        \"IPV6_AUTOCONF\u003dyes\"]))"},{"line_number":1081,"context_line":"    elif args.distro in \u0027gentoo\u0027:"},{"line_number":1082,"context_line":"        files_to_write.update("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_f940df09","line":1079,"updated":"2019-10-07 23:53:01.000000000","message":"This initializes the global ipv6 system. I think this should stay.","commit_id":"f31afea9789e8acc820806b22dcc51f6acbdfd81"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"246f6e97a284065e6725ce0979903c5f384a5529","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                        ):"},{"line_number":1078,"context_line":"                    of.write(\"\\n\" + \"\\n\".join(["},{"line_number":1079,"context_line":"                        \"NETWORKING_IPV6\u003dyes\","},{"line_number":1080,"context_line":"                        \"IPV6_AUTOCONF\u003dyes\"]))"},{"line_number":1081,"context_line":"    elif args.distro in \u0027gentoo\u0027:"},{"line_number":1082,"context_line":"        files_to_write.update("},{"line_number":1083,"context_line":"            write_gentoo_interfaces(interfaces, sys_interfaces)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_b94a6724","line":1080,"updated":"2019-10-07 23:53:01.000000000","message":"This however should be set per interface if we are doing autoconf on the interface.","commit_id":"f31afea9789e8acc820806b22dcc51f6acbdfd81"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"c7ee7a8984bed43a6f45521f926abfa354bd2166","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                        ):"},{"line_number":1078,"context_line":"                    of.write(\"\\n\" + \"\\n\".join(["},{"line_number":1079,"context_line":"                        \"NETWORKING_IPV6\u003dyes\","},{"line_number":1080,"context_line":"                        \"IPV6_AUTOCONF\u003dyes\"]))"},{"line_number":1081,"context_line":"    elif args.distro in \u0027gentoo\u0027:"},{"line_number":1082,"context_line":"        files_to_write.update("},{"line_number":1083,"context_line":"            write_gentoo_interfaces(interfaces, sys_interfaces)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_ab4a0624","line":1080,"in_reply_to":"3fa7e38b_b94a6724","updated":"2019-10-08 13:06:46.000000000","message":"Done","commit_id":"f31afea9789e8acc820806b22dcc51f6acbdfd81"}]}