)]}'
{"glean/cmd.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2991fda3dec6c3458258e27b863b9debe79da180","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"        log.debug(\"%s has active carrier, including\", iface)"},{"line_number":1130,"context_line":"        return True"},{"line_number":1131,"context_line":"    else:"},{"line_number":1132,"context_line":"        log.debug(\"%s does not have active carrier\", iface)"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"    if args.noop:"},{"line_number":1135,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f24194a7","line":1132,"updated":"2019-10-11 04:41:58.000000000","message":"emperical testing has shown that a virtio interface does *not* show a carrier in /sys when it is DOWN, and also does not show as \"dormant\" (i.e. is 0).\n\ni considered short-circuiting this for only virtio devices (check /sys/class/net/ens3/device/vendor for the virtio vendor, maybe), but this seemed more complex for something we want to get rid of anyway","commit_id":"cce59fe196904f0d6399e0eada6a5e15f6b44cb3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6f50d2ccd463d4341e6fed59e8360b3ea0e4eb2c","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"        # check if interface is up if not try and bring it up"},{"line_number":1262,"context_line":"        if interface_live(iface, sys_root, args):"},{"line_number":1263,"context_line":"            if_dict[iface] \u003d mac"},{"line_number":1264,"context_line":"            if called_from_udev:"},{"line_number":1265,"context_line":"                log.debug(\"Interface matched: %s (%s)\", iface, mac)"},{"line_number":1266,"context_line":"                sys_interfaces[mac] \u003d iface"},{"line_number":1267,"context_line":"                return sys_interfaces"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    # wait up to 9 seconds all interfaces to reach up"},{"line_number":1270,"context_line":"    log.debug(\"Waiting for interfaces to become active.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b500e303","line":1267,"range":{"start_line":1264,"start_character":12,"end_line":1267,"end_character":37},"updated":"2019-10-11 11:05:38.000000000","message":"To me it looks like this branch can never be hit after L1257, so remove it? Or comment it out with a reference to the hack above?","commit_id":"c521a4130b39860def4f859d71334053e8de095b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"18120aa9cefa559d1e3134e55149c59802b859af","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"        # check if interface is up if not try and bring it up"},{"line_number":1262,"context_line":"        if interface_live(iface, sys_root, args):"},{"line_number":1263,"context_line":"            if_dict[iface] \u003d mac"},{"line_number":1264,"context_line":"            if called_from_udev:"},{"line_number":1265,"context_line":"                log.debug(\"Interface matched: %s (%s)\", iface, mac)"},{"line_number":1266,"context_line":"                sys_interfaces[mac] \u003d iface"},{"line_number":1267,"context_line":"                return sys_interfaces"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    # wait up to 9 seconds all interfaces to reach up"},{"line_number":1270,"context_line":"    log.debug(\"Waiting for interfaces to become active.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_be8f5b21","line":1267,"range":{"start_line":1264,"start_character":12,"end_line":1267,"end_character":37},"in_reply_to":"3fa7e38b_b500e303","updated":"2019-10-11 22:35:58.000000000","message":"I agree I think this should be removed. Maybe put the log.debug line that we have here on line 1258 though.","commit_id":"c521a4130b39860def4f859d71334053e8de095b"}]}