)]}'
{"glean/init/glean.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34f3ec3202755bd37849cdc0564902921744e196","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        mount -o mode\u003d0700 \"${BLOCKDEV}\" /mnt/config || true"},{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"    glean --ssh --hostname $@"},{"line_number":51,"context_line":"else"},{"line_number":52,"context_line":"    glean $@"},{"line_number":53,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"c9724cfc_f3cfc99c","line":50,"updated":"2021-03-17 17:41:37.000000000","message":"btw what about using `exec glean ..`? This way you won\u0027t have a bash process floating around.","commit_id":"b57f0be4a794de4072de74cb266d3f3a6660641a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"53ae4bba87db185ea9547b0ed54883cba59962af","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        mount -o mode\u003d0700 \"${BLOCKDEV}\" /mnt/config || true"},{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"    glean --ssh --hostname $@"},{"line_number":51,"context_line":"else"},{"line_number":52,"context_line":"    glean $@"},{"line_number":53,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"153d9b86_01183ef2","line":50,"in_reply_to":"c9724cfc_f3cfc99c","updated":"2021-03-17 23:43:10.000000000","message":"Not a bad idea to use exec probably\n\nfrom the code, --hostname and --ssh both degrade gracefully if there is no metadata to doing nothing; i.e. they could be always passed to avoid this else statement.  not sure if that is more or less confusing.","commit_id":"b57f0be4a794de4072de74cb266d3f3a6660641a"}]}