)]}'
{"glean/install.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"46a976fcb32f449a7da6dc1a07b4918ff14c535d","unresolved":true,"context_lines":[{"line_number":128,"context_line":"                     \"with\" if args.use_nm else \"without\")"},{"line_number":129,"context_line":"            if args.use_nm:"},{"line_number":130,"context_line":"                service_file \u003d \u0027glean-nm@.service\u0027"},{"line_number":131,"context_line":"                if args.nm_early:"},{"line_number":132,"context_line":"                    install("},{"line_number":133,"context_line":"                        \u0027glean-early.service\u0027,"},{"line_number":134,"context_line":"                        \u0027/usr/lib/systemd/system/glean-early.service\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ae3ea37_c996e2ab","line":131,"updated":"2021-03-18 15:46:59.000000000","message":"I think we should capture why the early unit is used in addition to the nm unit and not as an alternative. Yesterday, I wrote a change that reduces two glean calls to one. This sort of double unit entry seems like it will be a likely candidate for similar future optimizations and if we know that is a bad idea we should write that down.","commit_id":"7d10bee64b1ce3da1fa281d3673a093980e77667"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"58d4ae86ff22a64a3ccaa89fdf1ccbd8f4fa106f","unresolved":true,"context_lines":[{"line_number":146,"context_line":"                        mode\u003d\u00270644\u0027,"},{"line_number":147,"context_line":"                        replacements\u003d{\u0027GLEANSH_PATH\u0027: p})"},{"line_number":148,"context_line":"                    subprocess.call("},{"line_number":149,"context_line":"                        [\u0027systemctl\u0027, \u0027enable\u0027, \u0027glean-early.service\u0027])"},{"line_number":150,"context_line":"            else:"},{"line_number":151,"context_line":"                service_file \u003d \u0027glean@.service\u0027"},{"line_number":152,"context_line":"            install("}],"source_content_type":"text/x-python","patch_set":3,"id":"5da405c5_65fd6e01","line":149,"updated":"2021-03-18 17:02:02.000000000","message":"Is this enable required? we do it above for gentoo, but don\u0027t seem to do it for glean-nm@.service.","commit_id":"3daacfdc26e6a9c7d49163927331d206be2e3a71"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d0404e3e9aecdf61549f1f713ad1e7e31d1ab70f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                        mode\u003d\u00270644\u0027,"},{"line_number":147,"context_line":"                        replacements\u003d{\u0027GLEANSH_PATH\u0027: p})"},{"line_number":148,"context_line":"                    subprocess.call("},{"line_number":149,"context_line":"                        [\u0027systemctl\u0027, \u0027enable\u0027, \u0027glean-early.service\u0027])"},{"line_number":150,"context_line":"            else:"},{"line_number":151,"context_line":"                service_file \u003d \u0027glean@.service\u0027"},{"line_number":152,"context_line":"            install("}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdedca4_8b9a26c0","line":149,"in_reply_to":"5da405c5_65fd6e01","updated":"2021-03-18 17:03:42.000000000","message":"This is necessary because udev isn\u0027t enabling this unit as with glean-nm@.service.","commit_id":"3daacfdc26e6a9c7d49163927331d206be2e3a71"}]}