)]}'
{"glean/cmd.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f3c87b7e1198614bbac3f3b2f2f055a318e7e5bc","unresolved":true,"context_lines":[{"line_number":998,"context_line":"        resolved_conf_fd.close()"},{"line_number":999,"context_line":"        # add the config to files to be written"},{"line_number":1000,"context_line":"        resolve_confs[\u0027/etc/systemd/resolved.conf\u0027] \u003d resolved_conf_output"},{"line_number":1001,"context_line":"    # make sure NetworkManager does not override our configuration"},{"line_number":1002,"context_line":"    if args.use_nm:"},{"line_number":1003,"context_line":"        install.install("},{"line_number":1004,"context_line":"            \u0027nm-no-resolv-handling.conf\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"769745fb_662aeb46","line":1001,"updated":"2021-03-22 03:24:26.000000000","message":"This doesn\u0027t work because \"nm-no-resolve-handling.conf\" is in the glean source, which is copied in by the install.py script during build time when it has the glean source directory.  This is running on the host at boot/runtime, so this file doesn\u0027t exist.\n\nto move it here, it would have to open/create this file and write the contents in directly.","commit_id":"ab686d9749206fdf3530afbd79446ed78682b3f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7179b2cabf15214fa7d26f99f63c5abe7ee9236c","unresolved":true,"context_lines":[{"line_number":998,"context_line":"        resolved_conf_fd.close()"},{"line_number":999,"context_line":"        # add the config to files to be written"},{"line_number":1000,"context_line":"        resolve_confs[\u0027/etc/systemd/resolved.conf\u0027] \u003d resolved_conf_output"},{"line_number":1001,"context_line":"    # make sure NetworkManager does not override our configuration"},{"line_number":1002,"context_line":"    if args.use_nm:"},{"line_number":1003,"context_line":"        install.install("},{"line_number":1004,"context_line":"            \u0027nm-no-resolv-handling.conf\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a63b705a_65ced896","line":1001,"in_reply_to":"769745fb_662aeb46","updated":"2021-03-22 10:17:09.000000000","message":"Unless you want to move away from pbr, everything under \"glean\" is always installed by it.\n\nWhat you describe is not how e.g. DIB simple-init element works: it uses the global \u0027glean install\u0027 after pip-installing glean.","commit_id":"ab686d9749206fdf3530afbd79446ed78682b3f3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5c5d260d2bf6df78b7d5db2fe926b90c1f5e68bb","unresolved":false,"context_lines":[{"line_number":998,"context_line":"        resolved_conf_fd.close()"},{"line_number":999,"context_line":"        # add the config to files to be written"},{"line_number":1000,"context_line":"        resolve_confs[\u0027/etc/systemd/resolved.conf\u0027] \u003d resolved_conf_output"},{"line_number":1001,"context_line":"    # make sure NetworkManager does not override our configuration"},{"line_number":1002,"context_line":"    if args.use_nm:"},{"line_number":1003,"context_line":"        install.install("},{"line_number":1004,"context_line":"            \u0027nm-no-resolv-handling.conf\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1303b8e2_19da4c17","line":1001,"in_reply_to":"a63b705a_65ced896","updated":"2021-03-23 04:09:16.000000000","message":"you\u0027re right, i\u0027d forgotten everything is copied in","commit_id":"ab686d9749206fdf3530afbd79446ed78682b3f3"}]}
