)]}'
{"glean/init/glean-early.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3989558ec113d496655a147c6b642b7cef49cd17","unresolved":true,"context_lines":[{"line_number":24,"context_line":"# available network interfaces."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# python-glean is installed alongside us and runs glean (the python"},{"line_number":27,"context_line":"# tool that acutally does stuff)."},{"line_number":28,"context_line":"_GLEAN_PATH\u003d$(dirname \"$0\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# NOTE(mnaser): Depending on the cloud, it may have `vfat` config drive which"}],"source_content_type":"text/x-sh","patch_set":12,"id":"b1565cbc_55ef1859","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":16},"updated":"2021-04-27 22:59:53.000000000","message":"Nit new typo. Don\u0027t push a new series for this though.","commit_id":"3cb334dbbb0fe33dd17100ad4621cc6360a85c23"}],"glean/init/glean-networkd.service":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3989558ec113d496655a147c6b642b7cef49cd17","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Before\u003dsystemd-networkd.service"},{"line_number":4,"context_line":"After\u003dglean-early.service"},{"line_number":5,"context_line":"Requires\u003dsystemd-networkd.service"},{"line_number":6,"context_line":"Wants\u003dglean-early.service"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[Service]"},{"line_number":9,"context_line":"Type\u003doneshot"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"43018afd_293d8436","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":25},"updated":"2021-04-27 22:59:53.000000000","message":"Typically I would say that glean-early.service should be a requires not a wants. But I guess if glean-early fails we want the udev units to do their absolute best to configure something that is workable so that things can be debugged.\n\nThat may be worth a comment? A followup change is fine.","commit_id":"3cb334dbbb0fe33dd17100ad4621cc6360a85c23"}],"glean/init/glean-nm@.service":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3989558ec113d496655a147c6b642b7cef49cd17","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dGlean for interface %I with NetworkManager"},{"line_number":3,"context_line":"Before\u003dnetwork-pre.target"},{"line_number":4,"context_line":"Wants\u003dnetwork-pre.target glean-early.service"},{"line_number":5,"context_line":"After\u003dlocal-fs.target glean-early.service"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Red Hat"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"caf8870a_bba83ab4","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":44},"updated":"2021-04-27 22:59:53.000000000","message":"Typically I would say that glean-early.service should be a requires not a wants. But I guess if glean-early fails we want the udev units to do their absolute best to configure something that is workable so that things can be debugged.\n\nThat may be worth a comment? A followup change is fine.","commit_id":"3cb334dbbb0fe33dd17100ad4621cc6360a85c23"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6e42ccdd4239fb58cf6a893201f7766597c423f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dGlean for interface %I with NetworkManager"},{"line_number":3,"context_line":"Before\u003dnetwork-pre.target"},{"line_number":4,"context_line":"Wants\u003dnetwork-pre.target glean-early.service"},{"line_number":5,"context_line":"After\u003dlocal-fs.target glean-early.service"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Red Hat"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"6adb2c44_11bbdc17","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":44},"in_reply_to":"caf8870a_bba83ab4","updated":"2021-04-27 23:32:17.000000000","message":"Yeah, I think I just defaulted to \"wants\" because in the man page it says \"This is the recommended way to hook start-up of one unit to the start-up of another unit.\" \n\nAs you say, if this is a requires then glean-early failure would kill this; while I don\u0027t expect glean-early to fail, if it did, I don\u0027t think that indicates this setup of the network should not try to run.","commit_id":"3cb334dbbb0fe33dd17100ad4621cc6360a85c23"}],"glean/init/glean@.service":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3989558ec113d496655a147c6b642b7cef49cd17","unresolved":true,"context_lines":[{"line_number":3,"context_line":"DefaultDependencies\u003dno"},{"line_number":4,"context_line":"Before\u003dnetwork-pre.target"},{"line_number":5,"context_line":"After \u003d glean-early.service"},{"line_number":6,"context_line":"Wants\u003dnetwork-pre.target glean-early.service"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Red Hat"},{"line_number":9,"context_line":"ConditionPathExists\u003d!/etc/sysconfig/network-scripts/ifcfg-%I"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"15af3ca8_9db9bccf","line":6,"updated":"2021-04-27 22:59:53.000000000","message":"Typically I would say that glean-early.service should be a requires not a wants. But I guess if glean-early fails we want the udev units to do their absolute best to configure something that is workable so that things can be debugged.\n\nThat may be worth a comment? A followup change is fine.","commit_id":"3cb334dbbb0fe33dd17100ad4621cc6360a85c23"}],"glean/install.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3989558ec113d496655a147c6b642b7cef49cd17","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    p \u003d pkg_resources.resource_filename(__name__, \"init\")"},{"line_number":30,"context_line":"    if not os.path.exists(os.path.join(p, \"glean.sh\")):"},{"line_number":31,"context_line":"        log.error(\"Unable to find glean.sh!\")"},{"line_number":32,"context_line":"        sys.exit(1)"},{"line_number":33,"context_line":"    return p"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ebecfd65_04a2c8f3","side":"PARENT","line":32,"updated":"2021-04-27 22:59:53.000000000","message":"Why do we remove this error handler?","commit_id":"2bfa1c440b942cf4530ef9c4bfa9f056f6033b85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6e42ccdd4239fb58cf6a893201f7766597c423f0","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    p \u003d pkg_resources.resource_filename(__name__, \"init\")"},{"line_number":30,"context_line":"    if not os.path.exists(os.path.join(p, \"glean.sh\")):"},{"line_number":31,"context_line":"        log.error(\"Unable to find glean.sh!\")"},{"line_number":32,"context_line":"        sys.exit(1)"},{"line_number":33,"context_line":"    return p"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"0ebd39c1_31541bc7","side":"PARENT","line":32,"in_reply_to":"ebecfd65_04a2c8f3","updated":"2021-04-27 23:32:17.000000000","message":"this should probably be in the other change but it\u0027s an optimisation as this is now sourced from the install; we don\u0027t really need to check if it is there as that is the job of the package installation.","commit_id":"2bfa1c440b942cf4530ef9c4bfa9f056f6033b85"}]}