)]}'
{"glean/cmd.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"877347476de7382bc31d955564b41762d5b4fcf7","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        if len(_interfaces) \u003e 1:"},{"line_number":331,"context_line":"            _interfaces \u003d ["},{"line_number":332,"context_line":"                x for x in _interfaces if not x[\u0027type\u0027].startswith(\u0027ipv6\u0027)]"},{"line_number":333,"context_line":"        assert(len(_interfaces) \u003d\u003d 1)"},{"line_number":334,"context_line":"        interface \u003d _interfaces[0]"},{"line_number":335,"context_line":"        logging.debug(\"Processing : %s -\u003e %s\" % (_name, interface))"},{"line_number":336,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv4\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"838449b4_4f8222c0","line":333,"updated":"2022-05-25 20:47:52.000000000","message":"Nit, if we end up with multiples for some reason you end up with an unconfigured interface which can make debugging really painful. I know the followup will address this by supporting ipv6. We should be sure to land both changes together for this reason.\n\nIf we do need to land them separately over time then we should probably update this to loop over the interfaces list and configure the first one found then exit. Then hopefully you get some networking.","commit_id":"4b03e53b278fa707f0d52a4b91d8f5df177b3783"}]}
