)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cc8c0407586b67a750358af8d8031d67cb5565d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f9af54a_928a5b26","updated":"2022-06-02 00:47:08.000000000","message":"merging this now the no-op release is out","commit_id":"0b250ab85e1334f93053f2beb1f2383dd92eb783"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b3279645edf8f5cb460c9c875914db7855d58fe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9466cf5a_2e4e8691","updated":"2022-06-02 20:45:54.000000000","message":"recheck","commit_id":"0b250ab85e1334f93053f2beb1f2383dd92eb783"}],"glean/cmd.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7c065c1d656ae3e60c5a85b5075cde92e6fcf45e","unresolved":true,"context_lines":[{"line_number":208,"context_line":"    for route in interface.get(\u0027routes\u0027, ()):"},{"line_number":209,"context_line":"        netmask \u003d utils.ipv6_netmask_length(route[\u0027netmask\u0027])"},{"line_number":210,"context_line":"        if route[\u0027network\u0027] \u003d\u003d \u0027::\u0027:"},{"line_number":211,"context_line":"            routes +\u003d \u0027default via {0}{1} dev {2} metric 1\\n\u0027.format("},{"line_number":212,"context_line":"                route[\u0027gateway\u0027],"},{"line_number":213,"context_line":"                (\"/%d\" % netmask) if netmask else \u0027\u0027,"},{"line_number":214,"context_line":"                name"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa295ef8_f364302b","line":211,"updated":"2022-05-31 20:01:54.000000000","message":"reviewer note : I found out that adding the default route here in route6-\u003cinterface\u003e doesn\u0027t work on older platforms.  The follow-on I41381bb65d980002c4ccfd2eca643ec51529360a moves this into IPV6DEFAULT_GW in the ifcfg-\u003cinterface\u003e file.\n\nWe could potentially squash this, but I did test this change as is on 8-stream and 9-stream on rax and ovh and just wanted to reflect the history of the development.","commit_id":"0b250ab85e1334f93053f2beb1f2383dd92eb783"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"209040519eadd311a5ff194c2fe0294233f67310","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        if len(_interfaces) \u003e 1:"},{"line_number":372,"context_line":"            files_to_write.update("},{"line_number":373,"context_line":"                _write_rh_interfaces(_name, _interfaces, args))"},{"line_number":374,"context_line":"        else:"},{"line_number":375,"context_line":"            assert(len(_interfaces) \u003d\u003d 1)"},{"line_number":376,"context_line":"            interface \u003d _interfaces[0]"},{"line_number":377,"context_line":"            logging.debug(\"Processing : %s -\u003e %s\" % (_name, interface))"}],"source_content_type":"text/x-python","patch_set":10,"id":"43d30bc8_abc9f270","line":374,"updated":"2022-05-31 20:52:23.000000000","message":"Why not let the loop in _write_rh_interfaces() handle this case too? length of one or two we should be able to loop and produce the right result? I guess you don\u0027t currently handle the manual case in the loop, but that should be doable?","commit_id":"0b250ab85e1334f93053f2beb1f2383dd92eb783"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"eb0b5497e1bed6dc3b9c13c9bf894c79df745588","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        if len(_interfaces) \u003e 1:"},{"line_number":372,"context_line":"            files_to_write.update("},{"line_number":373,"context_line":"                _write_rh_interfaces(_name, _interfaces, args))"},{"line_number":374,"context_line":"        else:"},{"line_number":375,"context_line":"            assert(len(_interfaces) \u003d\u003d 1)"},{"line_number":376,"context_line":"            interface \u003d _interfaces[0]"},{"line_number":377,"context_line":"            logging.debug(\"Processing : %s -\u003e %s\" % (_name, interface))"}],"source_content_type":"text/x-python","patch_set":10,"id":"67742c4c_8f95bee3","line":374,"in_reply_to":"43d30bc8_abc9f270","updated":"2022-05-31 21:32:56.000000000","message":"that\u0027s a good point this can probably be refactored.  let me try in a follow-on","commit_id":"0b250ab85e1334f93053f2beb1f2383dd92eb783"}]}
