)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0598e3b374b9eac973c628047a036b7837381231","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6ecffd1b_30531b59","updated":"2022-06-02 00:47:15.000000000","message":"merging this now the no-op release is out","commit_id":"6bdb47354e45b5047cf65a4b458eb809de640eb6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"21f35b9de9a2687db9bb8cb93a5e877d662d6b0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4d3d5319_54e1ff2a","updated":"2022-06-02 20:46:05.000000000","message":"recheck","commit_id":"6bdb47354e45b5047cf65a4b458eb809de640eb6"}],"glean/cmd.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee3650a17cb5980b30085ba98519c251bd80d597","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        else:"},{"line_number":218,"context_line":"            # Otherwise use \"policy routing\" mode.  The IPv4 mode is"},{"line_number":219,"context_line":"            # called \"Netmask Directives\" (ADDRESS0/GATEWAY0/NETMASK0)"},{"line_number":220,"context_line":"            # and it\u0027s not clear these support ipv6."},{"line_number":221,"context_line":"            netmask \u003d utils.ipv6_netmask_length(route[\u0027netmask\u0027])"},{"line_number":222,"context_line":"            routes +\u003d \u0027{0}{1} via {2}\\n\u0027.format("},{"line_number":223,"context_line":"                route[\u0027network\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9206a4eb_4c45f0a0","line":220,"updated":"2022-05-31 20:08:15.000000000","message":"c.f. https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/networking_guide/sec-configuring_static_routes_in_ifcfg_files","commit_id":"6bdb47354e45b5047cf65a4b458eb809de640eb6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"dcf54d90e689fcd39743b76280b954e6b26b252c","unresolved":true,"context_lines":[{"line_number":227,"context_line":"    # Only write the routes file if we have extra routes"},{"line_number":228,"context_line":"    route6_file \u003d _network_files(args.distro)[\u0027route6\u0027] + \u0027-%s\u0027 % name"},{"line_number":229,"context_line":"    if routes:"},{"line_number":230,"context_line":"        files[route6_file] \u003d routes"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    files[config_file] \u003d config_data"},{"line_number":233,"context_line":"    return files"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a913597_bf2bb7cc","line":230,"updated":"2022-05-31 20:55:04.000000000","message":"This case doesn\u0027t seem to be covered by the tests. At least judging by the diff in this change we only set the default gw in ifcg file when there are also separate routes. Probably not a huge deal but calling it out.","commit_id":"6bdb47354e45b5047cf65a4b458eb809de640eb6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a11c9c0477d6748f88b45b9f3c9f1c8d18b2a48f","unresolved":true,"context_lines":[{"line_number":227,"context_line":"    # Only write the routes file if we have extra routes"},{"line_number":228,"context_line":"    route6_file \u003d _network_files(args.distro)[\u0027route6\u0027] + \u0027-%s\u0027 % name"},{"line_number":229,"context_line":"    if routes:"},{"line_number":230,"context_line":"        files[route6_file] \u003d routes"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    files[config_file] \u003d config_data"},{"line_number":233,"context_line":"    return files"}],"source_content_type":"text/x-python","patch_set":4,"id":"45f93fed_1684674e","line":230,"in_reply_to":"4a913597_bf2bb7cc","updated":"2022-05-31 21:38:45.000000000","message":"RAX does give us an extra route which is set (e.g. at the bottom of https://review.opendev.org/c/opendev/glean/+/843758/4/glean/tests/fixtures/test/rax-iad.redhat.network.out).  So I think we are taking this path?","commit_id":"6bdb47354e45b5047cf65a4b458eb809de640eb6"}]}