)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8624e15cc17eff3bf3e364c0e8e2817eb4221c86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d55b9119_b0674273","updated":"2023-11-22 19:51:05.000000000","message":"Also adding Clark since it seems to be the only active other reviewer beyond Jeremy.","commit_id":"1cfd70c031c6cb7ee2cf3b21830bad4d090b2975"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d07401ac715caa92f94d4638e9c728b39caee2a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f88d6b91_812a3c64","updated":"2024-01-04 21:48:45.000000000","message":"Holding off for now, I need to resolve the overall path.","commit_id":"1cfd70c031c6cb7ee2cf3b21830bad4d090b2975"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"52b4a26122a11bca9c981cd4b903b943ac753091","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33174c9f_a8aa89fb","updated":"2023-11-22 19:50:11.000000000","message":"beep boop asking some ironic cores to maybe take a look.","commit_id":"1cfd70c031c6cb7ee2cf3b21830bad4d090b2975"}],"glean/cmd.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"04805bfa37982efdcbe59f2b898368b1f6ee662d","unresolved":true,"context_lines":[{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"        elif \u0027bond_mode\u0027 in interface:"},{"line_number":1088,"context_line":"            # We don\u0027t support bonding, so continuing."},{"line_number":1089,"context_line":"            interface_name \u003d interface.get(\u0027link\u0027, iname)"},{"line_number":1090,"context_line":"            continue"},{"line_number":1091,"context_line":"        else:"},{"line_number":1092,"context_line":"            interface_name \u003d sys_interfaces[interface[\u0027mac_address\u0027]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"234b5a03_9b0d92da","line":1089,"updated":"2023-12-05 21:16:52.000000000","message":"Nit this line isn\u0027t necessary as we continue and skip over the rest of the for loop iteration.","commit_id":"1cfd70c031c6cb7ee2cf3b21830bad4d090b2975"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"04805bfa37982efdcbe59f2b898368b1f6ee662d","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"        else:"},{"line_number":1092,"context_line":"            interface_name \u003d sys_interfaces[interface[\u0027mac_address\u0027]]"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        result +\u003d \u0027ip link set {} up\\n\u0027.format(interface_name)"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"        if interface[\u0027type\u0027] \u003d\u003d \u0027ipv4_dhcp\u0027:"},{"line_number":1097,"context_line":"            pid_file \u003d \u0027/var/run/udhcpc/{}.pid\u0027.format(interface_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"34b011ab_3acb877c","line":1094,"updated":"2023-12-05 21:16:52.000000000","message":"This might be a redundant ip link set up if using vlans above. Shouldn\u0027t be a problem though.","commit_id":"1cfd70c031c6cb7ee2cf3b21830bad4d090b2975"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"04805bfa37982efdcbe59f2b898368b1f6ee662d","unresolved":true,"context_lines":[{"line_number":1100,"context_line":"                       \u00272\u003e\u00261 \u0026\\n\u0027).format("},{"line_number":1101,"context_line":"                           pid_file,"},{"line_number":1102,"context_line":"                           interface_name)"},{"line_number":1103,"context_line":"        # elif \u0027ipv6_dhcp\u0027 in interface[\u0027type\u0027]:"},{"line_number":1104,"context_line":"        # Tinycore revolves around v4, and autoconfiguration for v6."},{"line_number":1105,"context_line":"        # So we really don\u0027t need to do anything as long as we get"},{"line_number":1106,"context_line":"        # link state up a nameserver."}],"source_content_type":"text/x-python","patch_set":3,"id":"4c195dd8_708243e5","line":1103,"updated":"2023-12-05 21:16:52.000000000","message":"Should this condition exist with a pass statement in order to be roughly equivalent to the ipv4_dhcp block above? In particular the else statement below will do a continue in the ipv6_dhcp case but not the ipv4_dhcp case. This means ipv4_dhcp acn also add static routes.\n\nAlternatively maybe add a continue to the ipv4_dhcp case as well.","commit_id":"1cfd70c031c6cb7ee2cf3b21830bad4d090b2975"}]}