)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0041f8a1f351c20388a146df05da218633a31973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8e901af_1ebd77af","updated":"2024-05-16 18:14:46.000000000","message":"As a note, the changes this change refers to have both merged.","commit_id":"d89a8e94126dc1527423a922971318340e025277"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"4de6567f2c5a64572a4474eaf58fb4129eebef3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4446ae1_2c0322a2","updated":"2024-05-16 18:49:38.000000000","message":"Looks good to me.\n\nI agree that the detection could be more robust but is acceptable for now.\n\nHolding off +A for a more experienced core as I\u0027m not 100% if there are ordering issues","commit_id":"d89a8e94126dc1527423a922971318340e025277"}],"glean/init/glean-early.sh":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"5905ed1f3b9daae747458aa1d17afba1e4e211ad","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#               comes with a capitalized label rather than all lowercase."},{"line_number":32,"context_line":"CONFIG_DRIVE_LABEL\u003d\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if grep -q \"ir_pub_id\" /proc/cmdline; then"},{"line_number":35,"context_line":"    # Ironic\u0027s DIB element will pull in and ensure the partition is mounted"},{"line_number":36,"context_line":"    # for configuration."},{"line_number":37,"context_line":"    echo \"Aborting glean-early.sh as the workload is an Ironic ramdisk.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"6e3e9d43_9558cae7","line":34,"updated":"2024-04-29 12:11:27.000000000","message":"I suppose this string is sufficiently complex as to minimize the risk of it appearing as a substring in some other unrelated parameter. Anchoring the beginning and/or end with expected separators (or line start) would help reduce the risk further, though, like \u0027\\(^\\| \\)ir_pub_id\u003d\u0027 maybe? It looks like the IPA change at least includes the trailing \u003d in its match.","commit_id":"d89a8e94126dc1527423a922971318340e025277"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b9e4503fa12dca46858fe8586bd79e022533128c","unresolved":true,"context_lines":[{"line_number":31,"context_line":"#               comes with a capitalized label rather than all lowercase."},{"line_number":32,"context_line":"CONFIG_DRIVE_LABEL\u003d\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if grep -q \"ir_pub_id\" /proc/cmdline; then"},{"line_number":35,"context_line":"    # Ironic\u0027s DIB element will pull in and ensure the partition is mounted"},{"line_number":36,"context_line":"    # for configuration."},{"line_number":37,"context_line":"    echo \"Aborting glean-early.sh as the workload is an Ironic ramdisk.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"42eb0507_23f6f3a7","line":34,"updated":"2024-05-16 19:28:53.000000000","message":"I think these sorts of magical behaviors should be avoided in glean. In particular we want its behavior to be as predictable as possible as early boot problems can be difficult to debug.\n\nSeparately I also question if glean needs to explicitly support anything like this at all. Glean\u0027s purpose is to be a boot time configurator that only works with config drive. It does not support metadata services (and doesn\u0027t intend to). That means skipping this step with glean is a noop and doesn\u0027t make sense for glean.\n\nIf people do want to mix other systems that manage the config drive and glean together I think it is reasonable for them to do so by controlling if/when this script runs at all (via systemd unit config for example) rather than modifying glean itself.","commit_id":"d89a8e94126dc1527423a922971318340e025277"}]}