)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"45e9f1af2220cc70605933e960ea21f54f2cbd5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c10c6e72_eb32e889","updated":"2024-07-12 16:11:19.000000000","message":"-1 as the opensuse thing inline will need to be sorted out as well as the general test problems.\n\nAs a note I\u0027m going on vacation after today and won\u0027t be able to rereview for a bit.","commit_id":"048ff8fd02ba616ff500f94e4ac3f1730638b03f"}],"glean/cmd.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"45e9f1af2220cc70605933e960ea21f54f2cbd5d","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        # Automatically generated, do not edit"},{"line_number":108,"context_line":"        BOOTPROTO\u003d{bootproto}"},{"line_number":109,"context_line":"        LLADDR\u003d{hwaddr}"},{"line_number":110,"context_line":"        STARTMODE\u003dauto"},{"line_number":111,"context_line":"        \"\"\")"},{"line_number":112,"context_line":"    else:"},{"line_number":113,"context_line":"        preamble \u003d textwrap.dedent(\"\"\"\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"675a64d6_7c006e7f","line":110,"updated":"2024-07-12 16:11:19.000000000","message":"OpenSUSE wasn\u0027t setting TYPE\u003dEthernet at all, but by moving that directive into _set_rh_bonding outside of the is_suse check the result is that suse now get this directive. This is one source of the test failures. The other source of the test failure is simply due to the order of the entries changing which is less problematic (just need to update the test strings to match).\n\nIn the case of suse I\u0027m not sure if TYPE\u003dEthernet is valid. If we can discover that it is then we can just update those test cases to match as well. However, if it isn\u0027t, then we\u0027ll need to update this change to preserve the old behavior. Or if we don\u0027t want to investigate to heavily just preserve the old behavior to avoid the potential regression.","commit_id":"048ff8fd02ba616ff500f94e4ac3f1730638b03f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5f89fc9ed3891f40471876fa205cf1889f9136b6","unresolved":true,"context_lines":[{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":""},{"line_number":1164,"context_line":"def get_dns_from_config_drive(net):"},{"line_number":1165,"context_line":"    # Create a single listing of all configured DNS entries so that whatever"},{"line_number":1166,"context_line":"    # OS level DNS resolution mechanisms are in place can perform round robin,"},{"line_number":1167,"context_line":"    # failoer, etc across them. Use a set to prevent duplicate entries."},{"line_number":1168,"context_line":"    dns_servers \u003d set()"}],"source_content_type":"text/x-python","patch_set":3,"id":"36f8f7cb_905a8ac7","line":1165,"updated":"2024-07-18 17:25:43.000000000","message":"It looks like these changes to edit how dns is handled got inserted into the change for TYPE\u003dEthernet setting.\n\nIt might be easiest to remove the relationship between these two chagnes and develop them on separate branches entirely? Just preserve the corresponding Change-Id: entries in the commit messages when you push and gerrit will get updates assocaited with the correct change.\n\nSeparately it looks like the TYPE\u003dEthernet testing issue with suse and other tests suddenly having that type set is still occuring. We should figure out what the best thing to do there is or just keep the existing behavior for those platforms and only change the red hat family of systems.\n\nFeel free to let me know if you ahve any questions about organizing the commits so they get lined up with the correct change.","commit_id":"6e5d80133ab5e90f38f0ebffa0db4d43653daf64"}]}