)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"961a9843d33b02ff0ffaf8db88d71f133d6b3740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c1761a6_24c7a3e0","updated":"2024-07-12 16:14:49.000000000","message":"I hesitate to -1 for this because the code isn\u0027t necessarily wrong. I just think we need to be better about capturing why we\u0027ve made this decisions as other choices seem equally valid after an initial review.\n\nAs a note I\u0027m going on vacation after today and won\u0027t be able to rereview for a bit.","commit_id":"23d30142c7611bb0d5bad6cb650532d41eee8fa5"}],"glean/cmd.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"961a9843d33b02ff0ffaf8db88d71f133d6b3740","unresolved":true,"context_lines":[{"line_number":1186,"context_line":"        if service.get(\u0027type\u0027, None) \u003d\u003d \u0027dns\u0027:"},{"line_number":1187,"context_line":"            global_dns_servers.add(service.get(\u0027address\u0027, None))"},{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"    # Prefer most to least specific DNS servers"},{"line_number":1190,"context_line":"    if subnet_dns_servers:"},{"line_number":1191,"context_line":"        final_dns_servers \u003d subnet_dns_servers"},{"line_number":1192,"context_line":"    elif network_dns_servers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ada002cc_e2ac6c82","line":1189,"updated":"2024-07-12 16:14:49.000000000","message":"Why do we prefer the most specific entries rather than returning a union of the lists? Typically I would expect if multiple nameservers are provided that we should use all of them and allow libc (or whatever is doing resolution) to round robin/fallback as appropriate.\n\nI think it would be good to justify and document these sorts of decisions even if that is only occuring in a comment in the code. That way we can understand use case needs in the future if others come along and want something different.","commit_id":"23d30142c7611bb0d5bad6cb650532d41eee8fa5"},{"author":{"_account_id":28397,"name":"Curt Moore","email":"curt.moore@gmail.com","username":"jcmoore"},"change_message_id":"3a490f84d963b56aaee4fe4744efe515e0bc0cb7","unresolved":true,"context_lines":[{"line_number":1186,"context_line":"        if service.get(\u0027type\u0027, None) \u003d\u003d \u0027dns\u0027:"},{"line_number":1187,"context_line":"            global_dns_servers.add(service.get(\u0027address\u0027, None))"},{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"    # Prefer most to least specific DNS servers"},{"line_number":1190,"context_line":"    if subnet_dns_servers:"},{"line_number":1191,"context_line":"        final_dns_servers \u003d subnet_dns_servers"},{"line_number":1192,"context_line":"    elif network_dns_servers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b760903_5991a959","line":1189,"in_reply_to":"ada002cc_e2ac6c82","updated":"2024-07-15 14:13:15.000000000","message":"Great points. I\u0027ve updated the patch to return an aggregated list of all configured DNS servers and documented the decision as to why we\u0027re doing things this way.","commit_id":"23d30142c7611bb0d5bad6cb650532d41eee8fa5"}]}