)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a9dd30bc48870849a0c29878223a3229eb4e0c20","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f6d6c7db_aea7cd2d","updated":"2025-10-31 08:53:04.000000000","message":"It wouldn\u0027t hurt to add:\n\nStory: 2011545\nStory: 2011546\n\nAbove the Change-Id\n\nSee: https://docs.openstack.org/contributors/common/git.html#footers","commit_id":"71c0959e87ce73855378c8dceb130a1540aa1d56"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"f8bdc560e2cdc0a6f170d0f29bb1052435b393fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84ef48a1_963de64c","in_reply_to":"f6d6c7db_aea7cd2d","updated":"2025-11-02 19:22:49.000000000","message":"Done","commit_id":"71c0959e87ce73855378c8dceb130a1540aa1d56"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"d64a33d215195f226419dd160db6ae453b1bb9c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"675fcfa0_756700e8","updated":"2025-10-30 21:13:23.000000000","message":"Please review 🙏. This is needed to add bonding support for Debian in Glean.\n\ni.e. this fixes https://storyboard.openstack.org/#!/story/2011546 and https://storyboard.openstack.org/#!/story/2011545","commit_id":"efdaa4b5dcc715f8e55c77921555d6247b5763dc"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a9dd30bc48870849a0c29878223a3229eb4e0c20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2b0b000b_5f385ba2","updated":"2025-10-31 08:53:04.000000000","message":"If I understand correctly that ifenslave has been removed.  Do you also need to update https://opendev.org/opendev/glean/src/branch/master/glean/cmd.py#L1082-L1083  ?","commit_id":"71c0959e87ce73855378c8dceb130a1540aa1d56"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"f8bdc560e2cdc0a6f170d0f29bb1052435b393fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c1f40d71_bf305083","in_reply_to":"2b0b000b_5f385ba2","updated":"2025-11-02 19:22:49.000000000","message":"@tony@bakeyournoodle.com This codepath is not used when distro\u003dnetworkd.\n\nI think using networkd when available is the way forward.","commit_id":"71c0959e87ce73855378c8dceb130a1540aa1d56"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"88154fd2f8d1ac076305ae0dd93436dc94b49a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff773eb7_b5df9fd9","updated":"2025-12-06 14:49:10.000000000","message":"@fungi@yuggoth.org foo@.service doesn\u0027t fallback to foo.service, those are different unit names. However foo@.service is automatically moved to foo.slice unit. \n\nNB: there is some doc at: https://www.freedesktop.org/software/systemd/man/latest/systemd.device#The%20udev%20Database","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"b93df317306f80dea5b0868b79d3d82edec66177","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fcc4ade0_7f601174","updated":"2025-12-05 08:50:58.000000000","message":"Can someone approve 🙏? This changeset has seen no activity since a month...","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"},{"author":{"_account_id":38759,"name":"László Jánosi","display_name":"janosin","email":"laszlo.janosi@nokia.com","username":"janosin"},"change_message_id":"2788c005a565a2d2eaf1fabbfac35cd08569d42b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5e8f778_97c6b9bb","updated":"2026-01-20 18:49:05.000000000","message":"Hello, I would like to add a bit related comment. After this change is merged the systemd.netdev generator kicks-in in cmd.py on the proper systems. I think the systemd.netdev config generator has a bug: this if https://opendev.org/opendev/glean/src/commit/10df0bd91b9bc5c9fd9cc02d75c0084cd4da29a7/glean/cmd.py#L708\nin cmd.py evaluates to True always, as \u0027bond_mode\u0027 is truthy. I.e. I think the current code generates a netdev file even for those interfaces that would not need such a file.\nDo you think this change set here could fix that issue as well, like \n\nif \u0027bond_mode\u0027 in interface or \u0027vlan_id\u0027 in interface:\n\nThank you!","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"},{"author":{"_account_id":38759,"name":"László Jánosi","display_name":"janosin","email":"laszlo.janosi@nokia.com","username":"janosin"},"change_message_id":"e6bd51ebae883327ba0d65abca6af4e0c9a8fe26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e491c573_c1b66573","updated":"2026-01-22 17:40:04.000000000","message":"I included the fix of that netdev generation beside other fixes in the change request:\nhttps://review.opendev.org/c/opendev/glean/+/974346","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"f8bdc560e2cdc0a6f170d0f29bb1052435b393fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5daac4b_78950aa8","updated":"2025-11-02 19:22:49.000000000","message":"Please review again (I\u0027ve amended the commit)","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b615326089f679e18b1e3e890304275bc3e5ea69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cb4708f8_e1fe19c2","updated":"2026-01-28 21:51:50.000000000","message":"See inline comments. Related to those comments is it possible to test this new auto detection functionality in the test suite?","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"c7c5f999f548e411f68d590c0abfc05ea080cceb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f28a5b94_ceff4e25","updated":"2025-12-06 16:58:10.000000000","message":"Yes.\n\nsystemd-networkd doesn\u0027t need this udev rule, because it\u0027s directly aware of devices changes (I don\u0027t know exactly how, but this involves systemd)","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"}],"glean/install.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"8e8ed9afc342d6c8bcb0798955bcfbc11f6770da","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                service_file,"},{"line_number":192,"context_line":"                \u0027/usr/lib/systemd/system/glean@.service\u0027,"},{"line_number":193,"context_line":"                mode\u003d\u00270644\u0027, replacements\u003dreplacements)"},{"line_number":194,"context_line":"            install("},{"line_number":195,"context_line":"                \u0027glean-udev.rules\u0027,"},{"line_number":196,"context_line":"                \u0027/etc/udev/rules.d/99-glean.rules\u0027,"},{"line_number":197,"context_line":"                mode\u003d\u00270644\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2edc921f_b016f002","line":194,"updated":"2025-10-30 21:29:17.000000000","message":"Is there a reason this is now moving into the else block (via indentation increase)?","commit_id":"efdaa4b5dcc715f8e55c77921555d6247b5763dc"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"8e0866efece31bde50b1c46d12bd2f8e5d4ed31e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                service_file,"},{"line_number":192,"context_line":"                \u0027/usr/lib/systemd/system/glean@.service\u0027,"},{"line_number":193,"context_line":"                mode\u003d\u00270644\u0027, replacements\u003dreplacements)"},{"line_number":194,"context_line":"            install("},{"line_number":195,"context_line":"                \u0027glean-udev.rules\u0027,"},{"line_number":196,"context_line":"                \u0027/etc/udev/rules.d/99-glean.rules\u0027,"},{"line_number":197,"context_line":"                mode\u003d\u00270644\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2d52445_86b2d5ac","line":194,"in_reply_to":"2edc921f_b016f002","updated":"2025-10-31 07:11:18.000000000","message":"The udev rule references the `glean@.service`, so it has no use when `glean@.service` is not installed.\n\nI have improved the commit message","commit_id":"efdaa4b5dcc715f8e55c77921555d6247b5763dc"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a9dd30bc48870849a0c29878223a3229eb4e0c20","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def detect_systemd_network():"},{"line_number":94,"context_line":"    if os.path.exists(\u0027/etc/gentoo-release\u0027):"},{"line_number":95,"context_line":"        # For backward compatibility, always une networkd on Gentoo"},{"line_number":96,"context_line":"        return True"},{"line_number":97,"context_line":"    return subprocess.call([\u0027systemctl\u0027, \u0027is-enabled\u0027, \u0027--quiet\u0027,"},{"line_number":98,"context_line":"                            \u0027systemd-networkd.service\u0027]) \u003d\u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"cb581c83_71b6d3d5","line":95,"range":{"start_line":95,"start_character":45,"end_line":95,"end_character":48},"updated":"2025-10-31 08:53:04.000000000","message":"nit: use","commit_id":"71c0959e87ce73855378c8dceb130a1540aa1d56"},{"author":{"_account_id":17509,"name":"Mathieu Parent","email":"math.parent@etik.com","username":"sathieu"},"change_message_id":"f8bdc560e2cdc0a6f170d0f29bb1052435b393fa","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def detect_systemd_network():"},{"line_number":94,"context_line":"    if os.path.exists(\u0027/etc/gentoo-release\u0027):"},{"line_number":95,"context_line":"        # For backward compatibility, always une networkd on Gentoo"},{"line_number":96,"context_line":"        return True"},{"line_number":97,"context_line":"    return subprocess.call([\u0027systemctl\u0027, \u0027is-enabled\u0027, \u0027--quiet\u0027,"},{"line_number":98,"context_line":"                            \u0027systemd-networkd.service\u0027]) \u003d\u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"0aef8e66_b5d7b50d","line":95,"range":{"start_line":95,"start_character":45,"end_line":95,"end_character":48},"in_reply_to":"cb581c83_71b6d3d5","updated":"2025-11-02 19:22:49.000000000","message":"Done","commit_id":"71c0959e87ce73855378c8dceb130a1540aa1d56"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b615326089f679e18b1e3e890304275bc3e5ea69","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    if os.path.exists(\u0027/etc/gentoo-release\u0027):"},{"line_number":95,"context_line":"        # For backward compatibility, always use networkd on Gentoo"},{"line_number":96,"context_line":"        return True"},{"line_number":97,"context_line":"    return subprocess.call([\u0027systemctl\u0027, \u0027is-enabled\u0027, \u0027--quiet\u0027,"},{"line_number":98,"context_line":"                            \u0027systemd-networkd.service\u0027]) \u003d\u003d 0"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":4,"id":"16d23ab1_088fa72d","line":98,"range":{"start_line":97,"start_character":4,"end_line":98,"end_character":61},"updated":"2026-01-28 21:51:50.000000000","message":"I don\u0027t think this is safe because platforms like Ubuntu enable systemd-networkd, but we do not configure networking via systemd-networkd on Ubuntu today.","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b615326089f679e18b1e3e890304275bc3e5ea69","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                             \"something else must configure networking or \""},{"line_number":120,"context_line":"                             \"it will be left unconfigured.\")"},{"line_number":121,"context_line":"    parser.add_argument(\"--use-networkd\", choices\u003d[\"true\", \"false\", \"auto\"],"},{"line_number":122,"context_line":"                        default\u003d\"auto\", help\u003d\"Use systemd-networkd\")"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    args \u003d parser.parse_args()"},{"line_number":125,"context_line":"    extra_args \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ef61e78_c2d4823b","line":122,"range":{"start_line":122,"start_character":32,"end_line":122,"end_character":38},"updated":"2026-01-28 21:51:50.000000000","message":"See above. I think that this default value should be false if we want to make this change safely so that users on platforms with platform specific network config can elect to use systemd-networkd directly instead of it being forced on them.","commit_id":"40005ef93164719925d78077038ffd3fc01cfef5"}]}