)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"55606023ebec4ffe5ea33e9964bca78f6c2293e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"135a1510_bf2223e3","updated":"2026-01-28 22:07:35.000000000","message":"-1 because this change doesn\u0027t fix the other DNS file write that can race multiple writers.\n\nThen I also listed a concern around whether or not it is actually backward compatible to do this change at install instead of runtime.","commit_id":"47a8514ee1e7d2740a25a37f4dc6984aa6dce25a"}],"glean/cmd.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"55606023ebec4ffe5ea33e9964bca78f6c2293e6","unresolved":true,"context_lines":[{"line_number":1256,"context_line":"        resolved_conf_output \u003d resolved_conf_fd.getvalue()"},{"line_number":1257,"context_line":"        resolved_conf_fd.close()"},{"line_number":1258,"context_line":"        # add the config to files to be written"},{"line_number":1259,"context_line":"        resolve_confs[\u0027/etc/systemd/resolved.conf\u0027] \u003d resolved_conf_output"},{"line_number":1260,"context_line":"    return resolve_confs"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c2d3e6df_b8c8efc1","line":1259,"updated":"2026-01-28 22:07:35.000000000","message":"I think the reason that this installation occurs at runtime instead of installation time is that you can run glean and tell it to skip dns management. If you do that then you would want network manager to configure dns or you\u0027d configure something else to do so and it would be your responsibility to disable it.\n\nFor example OpenDev does skip DNS here: https://opendev.org/opendev/zuul-providers/src/branch/master/dib-elements/nodepool-base/glean@.service.d/override.conf then we keep network manager away via: https://opendev.org/opendev/zuul-providers/src/branch/master/dib-elements/nodepool-base/finalise.d/89-boot-settings#L146-L172\n\nLooking at nm-no-resolv-handling.conf it uses a different mechanism than the one above. Any idea if it is safe to have these two different but overlapping configs? Mostly I\u0027m using this as a proxy for determining how safe this change is for other users of glean.\n\nAn alternative approach would be to continue to do the install at runtime, but do so atomically.","commit_id":"47a8514ee1e7d2740a25a37f4dc6984aa6dce25a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"55606023ebec4ffe5ea33e9964bca78f6c2293e6","unresolved":true,"context_lines":[{"line_number":1257,"context_line":"        resolved_conf_fd.close()"},{"line_number":1258,"context_line":"        # add the config to files to be written"},{"line_number":1259,"context_line":"        resolve_confs[\u0027/etc/systemd/resolved.conf\u0027] \u003d resolved_conf_output"},{"line_number":1260,"context_line":"    return resolve_confs"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"def get_config_drive_interfaces(net):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a13a534_ccc25c55","line":1260,"updated":"2026-01-28 22:07:35.000000000","message":"Note that this dictionary contains writes in it for at least one shared file (/etc/resolv.conf or /etc/systemd/resolved.conf). I don\u0027t think this change fixes the underlying issue only the problem for specific hardware due to the timing hitting /etc/NetworkManager/conf.d/nm-no-resolv-handling.conf instead of /etc/resolv.conf or /etc/systemd/resolved.conf.","commit_id":"47a8514ee1e7d2740a25a37f4dc6984aa6dce25a"}]}