)]}'
{"spec/acceptance/puppet_askbot_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"81fd9881bb219a8cf57d9dec1a1ce2c3cf590437","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    File.join(base_path, \u0027fixtures\u0027)"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  def preconditions_puppet_module"},{"line_number":10,"context_line":"    module_path \u003d File.join(pp_path, \u0027preconditions.pp\u0027)"},{"line_number":11,"context_line":"    File.read(module_path)"},{"line_number":12,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":45,"id":"5f7c97a3_f036f4e7","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":33},"updated":"2018-06-05 20:10:56.000000000","message":"(nit) I know this method already an established convention but this is technically a puppet manifest, not a puppet module","commit_id":"9c029a81da873b78b12dca9d219e5a292d5e8ec1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"691ddf63d5a2eceab9b6c4938000ce2275634264","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    File.join(base_path, \u0027fixtures\u0027)"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  def preconditions_puppet_module"},{"line_number":10,"context_line":"    module_path \u003d File.join(pp_path, \u0027preconditions.pp\u0027)"},{"line_number":11,"context_line":"    File.read(module_path)"},{"line_number":12,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":45,"id":"5f7c97a3_7092e44d","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":33},"in_reply_to":"5f7c97a3_f036f4e7","updated":"2018-06-05 20:23:20.000000000","message":"Done","commit_id":"9c029a81da873b78b12dca9d219e5a292d5e8ec1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"81fd9881bb219a8cf57d9dec1a1ce2c3cf590437","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    apply_manifest(preconditions_puppet_module, catch_failures: true)"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  def init_puppet_module"},{"line_number":19,"context_line":"    module_path \u003d File.join(pp_path, \u0027askbot.pp\u0027)"},{"line_number":20,"context_line":"    File.read(module_path)"},{"line_number":21,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":45,"id":"5f7c97a3_b0307cea","line":18,"range":{"start_line":18,"start_character":11,"end_line":18,"end_character":24},"updated":"2018-06-05 20:10:56.000000000","message":"(nit) same here","commit_id":"9c029a81da873b78b12dca9d219e5a292d5e8ec1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"691ddf63d5a2eceab9b6c4938000ce2275634264","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    apply_manifest(preconditions_puppet_module, catch_failures: true)"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  def init_puppet_module"},{"line_number":19,"context_line":"    module_path \u003d File.join(pp_path, \u0027askbot.pp\u0027)"},{"line_number":20,"context_line":"    File.read(module_path)"},{"line_number":21,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":45,"id":"5f7c97a3_1097f03c","line":18,"range":{"start_line":18,"start_character":11,"end_line":18,"end_character":24},"in_reply_to":"5f7c97a3_b0307cea","updated":"2018-06-05 20:23:20.000000000","message":"Done","commit_id":"9c029a81da873b78b12dca9d219e5a292d5e8ec1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"81fd9881bb219a8cf57d9dec1a1ce2c3cf590437","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  it \u0027should work with no errors\u0027 do"},{"line_number":24,"context_line":"    apply_manifest(init_puppet_module, catch_failures: true)"},{"line_number":25,"context_line":"  end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":45,"id":"5f7c97a3_70798491","line":25,"updated":"2018-06-05 20:10:56.000000000","message":"Would be good to have a second test with catch_changes: true, like in http://git.openstack.org/cgit/openstack-infra/puppet-cgit/tree/spec/acceptance/basic_spec.rb#n27","commit_id":"9c029a81da873b78b12dca9d219e5a292d5e8ec1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"691ddf63d5a2eceab9b6c4938000ce2275634264","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  it \u0027should work with no errors\u0027 do"},{"line_number":24,"context_line":"    apply_manifest(init_puppet_module, catch_failures: true)"},{"line_number":25,"context_line":"  end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":45,"id":"5f7c97a3_d0c9785a","line":25,"in_reply_to":"5f7c97a3_70798491","updated":"2018-06-05 20:23:20.000000000","message":"let me try that in a follow-on in case it explodes :)","commit_id":"9c029a81da873b78b12dca9d219e5a292d5e8ec1"}]}