)]}'
{"manifests/init.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"a3f2f34cd4e7939dafbd12239aa3d663c7f5b4f4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":96,"context_line":"    class { \u0027::selinux\u0027:"},{"line_number":97,"context_line":"        mode \u003d\u003e $selinux_mode"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"    if $selinux_mode !\u003d \"disabled\" {"},{"line_number":100,"context_line":"        include ::cgit::selinux"},{"line_number":101,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa1b9901_2d152948","line":98,"updated":"2015-08-19 15:29:04.000000000","message":"This seems a little overreaching to me, as this class might be managed somewhere else. I\u0027m surprised that we\u0027re managing it in cgit::lb as it\u0027s already managed in openstack_project::git. A downstream user might easily want to manage this in a server base class.","commit_id":"9180cdc756d8f20ee94e2bed2a378fb2b5044592"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ff50d7943370ab61a32ffb84ede3b0758d7248b1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":96,"context_line":"    class { \u0027::selinux\u0027:"},{"line_number":97,"context_line":"        mode \u003d\u003e $selinux_mode"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"    if $selinux_mode !\u003d \"disabled\" {"},{"line_number":100,"context_line":"        include ::cgit::selinux"},{"line_number":101,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa1b9901_52b4a680","line":98,"in_reply_to":"fa1b9901_107abc77","updated":"2015-08-19 22:45:58.000000000","message":"I just meant including the selinux class itself was overreaching. Looks like you took care of it in future patchsets.","commit_id":"9180cdc756d8f20ee94e2bed2a378fb2b5044592"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"55592d7846d9e1644b2c1f0d432c2070eb6448f0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":96,"context_line":"    class { \u0027::selinux\u0027:"},{"line_number":97,"context_line":"        mode \u003d\u003e $selinux_mode"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"    if $selinux_mode !\u003d \"disabled\" {"},{"line_number":100,"context_line":"        include ::cgit::selinux"},{"line_number":101,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa1b9901_107abc77","line":98,"in_reply_to":"fa1b9901_2d152948","updated":"2015-08-19 15:32:15.000000000","message":"How would you propose to include ::cgit::selinux conditionally based on selinux policy mode?","commit_id":"9180cdc756d8f20ee94e2bed2a378fb2b5044592"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"54182e3a4fed06fdd87b4a74eaed662d6ef8d26b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  include ::httpd"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":95,"context_line":"    if $::selinux_config_mode !\u003d \u0027disabled\u0027 {"},{"line_number":96,"context_line":"        include ::cgit::selinux"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_cc2d7da9","line":95,"updated":"2015-08-19 21:51:33.000000000","message":"I don\u0027t have this fact on my machine, where does it come from?","commit_id":"aa5300b920e3f08a1e2847ffe7a908d5c9bbfe5d"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f3a13c9d2b9fd7362515b954fbfc15e83f8631f9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  include ::httpd"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":95,"context_line":"    if $::selinux_config_mode !\u003d \u0027disabled\u0027 {"},{"line_number":96,"context_line":"        include ::cgit::selinux"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa1b9901_3277b2d4","line":95,"in_reply_to":"fa1b9901_cc2d7da9","updated":"2015-08-19 22:46:55.000000000","message":"I think more facts appear in facter | grep selinux when you have selinux enabled","commit_id":"aa5300b920e3f08a1e2847ffe7a908d5c9bbfe5d"}]}