)]}'
{"files/log-gearman-worker.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d679d211c6e6c2af0e051dfd41ee401b512d39df","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    OSLORE \u003d re.compile(OSLO_LOGMATCH)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def process(self, data):"},{"line_number":145,"context_line":"        msg \u003d data[\u0027message\u0027].encode(\u0027utf-8\u0027)"},{"line_number":146,"context_line":"        m \u003d self.OSLORE.match(msg)"},{"line_number":147,"context_line":"        if m:"},{"line_number":148,"context_line":"            data[\u0027severity\u0027] \u003d m.group(\u0027severity\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1b308356","line":145,"updated":"2018-08-06 16:59:36.000000000","message":"Oh yes, I copy-pastad from the crm114 filter without thinking about that.   Fixed in PS3","commit_id":"4f84b52b8f338fb9cfeb8237eacd72c204d9e96f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c1afdcde3b4df6112c803bc58eb2e29f48d11831","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    OSLORE \u003d re.compile(OSLO_LOGMATCH)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def process(self, data):"},{"line_number":145,"context_line":"        msg \u003d data[\u0027message\u0027].encode(\u0027utf-8\u0027)"},{"line_number":146,"context_line":"        m \u003d self.OSLORE.match(msg)"},{"line_number":147,"context_line":"        if m:"},{"line_number":148,"context_line":"            data[\u0027severity\u0027] \u003d m.group(\u0027severity\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c39a406d","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":45},"updated":"2018-08-03 22:58:02.000000000","message":"This will convert the message to binary string. This will work on python2 because binary strings are regexable but I am not sure it is right for python3?","commit_id":"4f84b52b8f338fb9cfeb8237eacd72c204d9e96f"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d679d211c6e6c2af0e051dfd41ee401b512d39df","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                        new_filters \u003d []"},{"line_number":210,"context_line":"                        for f in filters:"},{"line_number":211,"context_line":"                            try:"},{"line_number":212,"context_line":"                                f.process(out_event)"},{"line_number":213,"context_line":"                                new_filters.append(f)"},{"line_number":214,"context_line":"                            except FilterException:"},{"line_number":215,"context_line":"                                logging.exception(\"Exception filtering event: \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bb34ef4b","line":212,"updated":"2018-08-06 16:59:36.000000000","message":"Agreed, I changed this to a real filter in PS2.","commit_id":"4f84b52b8f338fb9cfeb8237eacd72c204d9e96f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c1afdcde3b4df6112c803bc58eb2e29f48d11831","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                        new_filters \u003d []"},{"line_number":210,"context_line":"                        for f in filters:"},{"line_number":211,"context_line":"                            try:"},{"line_number":212,"context_line":"                                f.process(out_event)"},{"line_number":213,"context_line":"                                new_filters.append(f)"},{"line_number":214,"context_line":"                            except FilterException:"},{"line_number":215,"context_line":"                                logging.exception(\"Exception filtering event: \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_037a7823","line":212,"updated":"2018-08-03 22:58:02.000000000","message":"It would probably be good if we could add the severity filter first, run f.process with it then check some value and break if set. That way we short circuit processing and avoid needing to run crm114 on messages we won\u0027t index.\n\nThe way we handle exceptions below by keeping a working list of filters makes this a bit complicated though.","commit_id":"4f84b52b8f338fb9cfeb8237eacd72c204d9e96f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"acf1340353e82f45b602b93160763ccbe5b28a7c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                                logging.exception(\"Exception filtering event: \""},{"line_number":225,"context_line":"                                                  \"%s\" % line.encode(\"utf-8\"))"},{"line_number":226,"context_line":"                        filters \u003d new_filters"},{"line_number":227,"context_line":"                        if out_event.get(\u0027severity\u0027) !\u003d \u0027DEBUG\u0027:"},{"line_number":228,"context_line":"                            self.logq.put(out_event)"},{"line_number":229,"context_line":"                finally:"},{"line_number":230,"context_line":"                    for f in all_filters:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7bf9777e","line":227,"updated":"2018-08-06 16:59:23.000000000","message":"Maybe change this to\n\n  if keep_line:\n    self.logq.put(out_event)\n\nTo keep it lined up with the new filtering.","commit_id":"8db1c470a4505849519576766944cdec720601bc"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"104199218276fb32981fbef4b51e3e6f338c46eb","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                                logging.exception(\"Exception filtering event: \""},{"line_number":225,"context_line":"                                                  \"%s\" % line.encode(\"utf-8\"))"},{"line_number":226,"context_line":"                        filters \u003d new_filters"},{"line_number":227,"context_line":"                        if out_event.get(\u0027severity\u0027) !\u003d \u0027DEBUG\u0027:"},{"line_number":228,"context_line":"                            self.logq.put(out_event)"},{"line_number":229,"context_line":"                finally:"},{"line_number":230,"context_line":"                    for f in all_filters:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bb0dcf91","line":227,"updated":"2018-08-06 17:01:07.000000000","message":"Yep!","commit_id":"8db1c470a4505849519576766944cdec720601bc"}]}
